8 comments:
File src/southbridge/intel/bd82x6x/me.h:
Patch Set #11, Line 193: #define CMOS_ME_STATE_DISABLED 1
Use tabs for alignment as above.
Make that boolean?
File src/southbridge/intel/bd82x6x/me_8.x.c:
Patch Set #11, Line 637: printk(BIOS_CRIT, "%s: mbp is not ready!\n", __func__);
Unrelated.
Patch Set #11, Line 758: BIOS_SPEW
Level *info* or *debug* would be more useful I guess.
Patch Set #11, Line 799: printk(BIOS_ERR, "ME: failed to enter Soft Temporary Disable mode\n");
{} around this branch.
Patch Set #11, Line 821: BIOS_INFO
Level *notice* would be more appropriate in my opinion.
File src/southbridge/intel/bd82x6x/me_common.c:
boolean
Patch Set #11, Line 28: #endif
Why is the distinction needed? Is it run in romstage and ramstage?
To view, visit change 37115. To unsubscribe, or for help writing mail filters, visit settings.