Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47017 ) Change subject: soc/intel/common: Create common Intel FSP reset code block ...................................................................... Patch Set 4: Code-Review+2 (1 comment) https://review.coreboot.org/c/coreboot/+/47017/4//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/47017/4//COMMIT_MSG@12 PS4, Line 12: require nit: require*d* -- To view, visit https://review.coreboot.org/c/coreboot/+/47017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I934b41affed7bb146f53ff6a4654fdbc6626101b Gerrit-Change-Number: 47017 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Subrata Banik <subi.banik@gmail.com> Gerrit-Comment-Date: Mon, 02 Nov 2020 10:38:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment