Thanks for reviving this!
5 comments:
Patch Set #4, Line 36: defined in the base tree.
Changing the alias feels wrong. But we can start with this behavior
and amend it if it ever fails us (e.g. make it a list of aliases?).
Alternatively, we could resolve the references right before an override
tree is applied or the tree is printed out in the end. This way,
aliases would have some kind of file scope.
Patch Set #4, Line 38: conflits
confli*c*ts
Patch Set #4, Line 862: free(alias);
This looks a bit odd now that we have a copy of the pointer in the `->ref`
list. I would prefer to just drop the free() or clean the whole list up
(which we know isn't necessary as sconfig is nearly done).
Patch Set #4, Line 874: if (!dev->chip_instance->ref)
Nit, technicallly this repeats the loop condition.
Patch Set #4, Line 1716: walk_device_tree(autogen, autohead, &base_root_dev, update_references);
Could we just do it as part of pass0()? If not, is there a reason to
interleave it with the printing, or could we do it above after applying
the override tree?
To view, visit change 35456. To unsubscribe, or for help writing mail filters, visit settings.