build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48073 )
Change subject: soc/mediatek/mt8192: add dramc power control ......................................................................
Patch Set 1:
(210 comments)
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_power.c:
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */ DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 2: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 3: #include <soc/dramc_power.h> DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 4: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 5: void __weak mainboard_set_regulator_vol(enum mtk_regulator regulator, DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 6: uint32_t voltage_uv) DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 7: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 8: dramc_info("%s not implemented!\n", __func__); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 9: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 10: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 11: uint32_t __weak mainboard_get_regulator_vol(enum mtk_regulator regulator) DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 12: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 13: dramc_info("%s not implemented!\n", __func__); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 14: return 0; DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 15: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 16: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 17: u32 get_vcore_value(const struct ddr_cali *cali) DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 18: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 19: #ifdef HQA_HV DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 20: return cali->vcore_voltage / 100 * 105; DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 21: #elif defined(HQA_LV) DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 22: return cali->vcore_voltage / 100 * 95; DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 23: #else DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 24: return cali->vcore_voltage; DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 25: #endif DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 26: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 27: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 28: u32 get_vdd1_value() DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 28: u32 get_vdd1_value() Bad function definition - u32 get_vdd1_value() should probably be u32 get_vdd1_value(void)
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 29: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 30: return VDD1_VOL; DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 31: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 32: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 33: u32 get_vdd2_value() DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 33: u32 get_vdd2_value() Bad function definition - u32 get_vdd2_value() should probably be u32 get_vdd2_value(void)
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 34: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 35: return VDD2_VOL; DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 36: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 37: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 38: u32 get_vddq_value() DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 38: u32 get_vddq_value() Bad function definition - u32 get_vddq_value() should probably be u32 get_vddq_value(void)
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 39: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 40: return VDDQ_VOL; DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 41: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 42: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 43: u32 get_vmddr_value() DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 43: u32 get_vmddr_value() Bad function definition - u32 get_vmddr_value() should probably be u32 get_vmddr_value(void)
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 44: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 45: return VMDDR_VOL; DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 46: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 47: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 48: void dramc_set_vcore_voltage(const struct ddr_cali *cali) DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 49: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 50: u32 vcore = get_vcore_value(cali); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 51: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 52: dramc_info("[%s]Set vcore voltage to %u\n", HQA_TAG, vcore); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 53: mainboard_set_regulator_vol(MTK_REGULATOR_VCORE, vcore); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 54: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 55: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 56: void dramc_set_vdd1_voltage() DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 56: void dramc_set_vdd1_voltage() Bad function definition - void dramc_set_vdd1_voltage() should probably be void dramc_set_vdd1_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 57: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 58: u32 vdd1 = get_vdd1_value(); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 59: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 60: dramc_info("[%s]Set DRAM vdd1 voltage to %u\n", HQA_TAG, vdd1); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 61: mainboard_set_regulator_vol(MTK_REGULATOR_VDD1, vdd1); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 62: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 63: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 64: void dramc_set_vdd2_voltage() DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 64: void dramc_set_vdd2_voltage() Bad function definition - void dramc_set_vdd2_voltage() should probably be void dramc_set_vdd2_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 65: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 66: u32 vdd2 = get_vdd2_value(); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 67: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 68: dramc_info("[%s]Set DRAM vdd2 voltage to %u\n", HQA_TAG, vdd2); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 69: mainboard_set_regulator_vol(MTK_REGULATOR_VDD2, vdd2); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 70: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 71: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 72: void dramc_set_vddq_voltage() DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 72: void dramc_set_vddq_voltage() Bad function definition - void dramc_set_vddq_voltage() should probably be void dramc_set_vddq_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 73: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 74: u32 vddq = get_vddq_value(); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 75: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 76: dramc_info("[%s]Set DRAM vddq voltage to %u\n", HQA_TAG, vddq); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 77: mainboard_set_regulator_vol(MTK_REGULATOR_VDDQ, vddq); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 78: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 79: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 80: void dramc_set_vmddr_voltage() DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 80: void dramc_set_vmddr_voltage() Bad function definition - void dramc_set_vmddr_voltage() should probably be void dramc_set_vmddr_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 81: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 82: u32 vmddr = get_vmddr_value(); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 83: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 84: dramc_info("[%s]Set vmddr voltage to %u\n", HQA_TAG, vmddr); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 85: mainboard_set_regulator_vol(MTK_REGULATOR_VMDDR, vmddr); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 86: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 87: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 88: u32 dramc_get_vcore_voltage() DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 88: u32 dramc_get_vcore_voltage() Bad function definition - u32 dramc_get_vcore_voltage() should probably be u32 dramc_get_vcore_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 89: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 90: return mainboard_get_regulator_vol(MTK_REGULATOR_VCORE); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 91: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 92: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 93: // TODO: use real interface trailing whitespace
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 94: u32 dramc_get_vdd1_voltage() DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 94: u32 dramc_get_vdd1_voltage() Bad function definition - u32 dramc_get_vdd1_voltage() should probably be u32 dramc_get_vdd1_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 95: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 96: return mainboard_get_regulator_vol(MTK_REGULATOR_VDD1); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 97: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 98: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 99: u32 dramc_get_vdd2_voltage() DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 99: u32 dramc_get_vdd2_voltage() Bad function definition - u32 dramc_get_vdd2_voltage() should probably be u32 dramc_get_vdd2_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 100: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 101: return mainboard_get_regulator_vol(MTK_REGULATOR_VDD2); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 102: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 103: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 104: u32 dramc_get_vddq_voltage() DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 104: u32 dramc_get_vddq_voltage() Bad function definition - u32 dramc_get_vddq_voltage() should probably be u32 dramc_get_vddq_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 105: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 106: return mainboard_get_regulator_vol(MTK_REGULATOR_VDDQ); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 107: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 108: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 109: u32 dramc_get_vmddr_voltage() DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 109: u32 dramc_get_vmddr_voltage() Bad function definition - u32 dramc_get_vmddr_voltage() should probably be u32 dramc_get_vmddr_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 110: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 111: return mainboard_get_regulator_vol(MTK_REGULATOR_VMDDR); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 112: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 113: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 114: void dramc_set_voltage(const struct ddr_cali *cali) DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 115: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 116: dramc_set_vcore_voltage(cali); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 117: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 118: dramc_set_vdd1_voltage(); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 119: dramc_set_vdd2_voltage(); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 120: dramc_set_vddq_voltage(); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 121: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 122: dramc_set_vmddr_voltage(); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 123: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 124: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 125: void dramc_dump_voltage() DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 125: void dramc_dump_voltage() Bad function definition - void dramc_dump_voltage() should probably be void dramc_dump_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 126: { DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 127: u32 vcore, vdd1, vdd2, vddq, vmddr; DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 128: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 129: vcore = dramc_get_vcore_voltage(); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 130: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 131: vdd1 = dramc_get_vdd1_voltage(); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 132: vdd2 = dramc_get_vdd2_voltage(); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 133: vddq = dramc_get_vddq_voltage(); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 134: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 135: vmddr = dramc_get_vmddr_voltage(); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 136: dramc_info("[Dump Dram Voltage] vcore: %u, vdd1:%u, vdd2:%u, vddq:%u, vmddr:%u\n" DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 137: , vcore, vdd1, vdd2, vddq, vmddr); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 138: } DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/dra... PS1, Line 139: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/dramc_power.h:
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */ DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 2: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 3: #ifndef __SOC_MEDIATEK_MT8192_DRAMC_POWER_H__ DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 4: #define __SOC_MEDIATEK_MT8192_DRAMC_POWER_H__ DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 5: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 6: #include <stdint.h> DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 7: #include <sys/types.h> DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 8: #include <soc/dramc_common_mt8192.h> DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 9: #include <soc/dramc_pi_api.h> DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 10: #include <soc/pll.h> DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 11: #include <soc/pll_common.h> DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 12: #include <soc/mt6359p.h> DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 13: #include <soc/regulator.h> DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 14: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 15: #ifdef HQA_HV DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 16: #define HQA_TAG "HV" DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 17: #define VDD1_VOL 1950000 DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 18: #define VDD2_VOL 1170000 DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 19: #define VDDQ_VOL 650000 DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 20: #define VMDDR_VOL 790000 DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 21: #elif defined(HQA_LV) DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 22: #define HQA_TAG "LV" DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 23: #define VDD1_VOL 1730000 DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 24: #define VDD2_VOL 1060000 DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 25: #define VDDQ_VOL 570000 DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 26: #define VMDDR_VOL 710000 DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 27: #else // by default: HQA_NV trailing whitespace
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 28: #define HQA_TAG "NV" DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 29: #define VDD1_VOL 1800000 DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 30: #define VDD2_VOL 1125000 DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 31: #define VDDQ_VOL 600000 DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 32: #define VMDDR_VOL 750000 DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 33: #endif DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 34: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 35: u32 get_vcore_value(const struct ddr_cali *cali); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 36: u32 get_vdd1_value(void); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 37: u32 get_vdd2_value(void); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 38: u32 get_vddq_value(void); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 39: u32 get_vmddr_value(void); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 40: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 41: u32 dramc_get_vcore_voltage(void); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 42: u32 dramc_get_vdd1_voltage(void); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 43: u32 dramc_get_vdd2_voltage(void); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 44: u32 dramc_get_vddq_voltage(void); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 45: u32 dramc_get_vmddr_voltage(void); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 46: void dramc_dump_voltage(void); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 47: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 48: void dramc_set_vcore_voltage(const struct ddr_cali *cali); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 49: void dramc_set_vdd1_voltage(void); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 50: void dramc_set_vdd2_voltage(void); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 51: void dramc_set_vddq_voltage(void); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 52: void dramc_set_vmddr_voltage(void); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 53: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 54: void dramc_set_voltage(const struct ddr_cali *cali); DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 55: DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 56: #endif /* __SOC_MEDIATEK_MT8192_DRAMC_PARAM_H__ */ DOS line endings
https://review.coreboot.org/c/coreboot/+/48073/1/src/soc/mediatek/mt8192/inc... PS1, Line 57: DOS line endings