Patch set 27:Code-Review +1
5 comments:
File src/mainboard/sifive/hifive-unleashed/Makefile.inc:
Patch Set #27, Line 24: ramstage-y += flash.c
isn't it sufficient to compile it in the stage that calls boot_device_init()? I guess that is bootblock?
File src/soc/sifive/fu540/include/soc/spi.h:
Patch Set #27, Line 172: typedef volatile struct {
I'd prefer not to have a typedef
File src/soc/sifive/fu540/spi_flash.c:
Patch Set #27, Line 39: static int _initialize_spi_flash_mmap(
move everything in here to initialize_spi_flash_mmap,
there's no need for a separate function.
Patch Set #27, Line 46: // Max desired SPI clock is 10MHz
same as above
add comment and explain what this function does, as done on initialize_spi_flash_direct
To view, visit change 30466. To unsubscribe, or for help writing mail filters, visit settings.