> Do we need to add new macros to soc/intel/common/block/include/intelblocks/gpio_defs.h
> for NF and GPO that will take HS ownership into account? Or should we ignore the
> value in the HOSTSW_OWN_* registers for NF and GPO pads and use standard macros from gpio_defs.h?

I don't think we should be adding macros which do not really match the architecture expectations. I think it would be better to make the tool ignore ownership bits if pad is not GPI.

View Change

To view, visit change 35643. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3e3b523c4f63dc2f91e9ccd16934e3a1b6e21fa
Gerrit-Change-Number: 35643
Gerrit-PatchSet: 16
Gerrit-Owner: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Andrey Petrov <andrey.petrov@gmail.com>
Gerrit-CC: Christian Walter <christian.walter@9elements.com>
Gerrit-CC: David Hendricks <david.hendricks@gmail.com>
Gerrit-CC: Furquan Shaikh <furquan@google.com>
Gerrit-CC: Maxim Polyakov <m.poliakov@yahoo.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Thu, 16 Apr 2020 01:52:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment