Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Shuo Liu, Tim Chu.

View Change

1 comment:

• Commit Message:

  • Patch Set #3, Line 9: Domain

    Sorry, the whole thing was my idea. Some thoughts: […]

    I'm not sure if I follow. Why would one report resources outside of `read_resources`?

    Also, if the HOB pointer doesn't change, wouldn't it be enough to cache it in a helper function?

    ```
    template<typename fsp_hob_type>
    fsp_hob_type *get_cached_fsp_hob(void)
    {
    	static fsp_hob_type *hob_ptr = NULL;
    	if (hob_ptr)
    		return hob_ptr;

    	hob_ptr = get_fsp_hob_real();
    	if (hob_ptr)
    		return hob_ptr;

    	die("%s: hob_ptr is NULL!", __func__);
    }
    ```

To view, visit change 81435. To unsubscribe, or for help writing mail filters, visit settings.