Some wording changes and other thoughts...
7 comments:
Add config MAINBOARD_OPTIONS and remove CONSOLE_OVERRIDE_LOGLEVEL,
it lets mainboard provide overridden function for getting configuration
values via get_option(). Currently it's only used for overriding
console log level.
I was trying to add to the file describing get_option but could not find it, any suggestion where I […]
It should match the code:
Documentation/lib/mb_option.md and update the index.md.
It's added into get_option() and when MAINBOARD_OPTIONS is selected,
it takes precedence and gets the config values from mainboard provided
overridden functions. Currently it's only used for overriding console
log level, so remove and replace config CONSOLE_OVERRIDE_LOGLEVEL with
it.
I've reworded this slightly. Please feel free to use o change any of it.
"The MAINBOARD_OPTION library adds a mainboard call to the coreboot option table get_option() function. Normally, the coreboot option table is accessed in cmos, but a mainboard may have other mechanisms to store options. This replaces the need for additional config options for overriding options. This initial implementation supports console log level. Remove and replace CONSOLE_OVERRIDE_LOGLEVEL."
Patch Set #12, Line 131: bool "Use mainboard overridden functions for getting configuration values"
"Use mainboard override functions"
Enable this option if coreboot shall read options from mainboard
overridden functions.
Enable this option to use mainboard override functions for additional customization and configurations.
if (strcmp(name, "debug_level") == 0) {
Another idea would be to make this a weak function and the mainboard implements the work of checking the option name and doing the override. I'd like other thoughts and opinions on this. Is there value in a option function dispatch here?
Maybe rename the files mb_option.*? option is a little generic to know what the file is for.
File src/mainboard/scaleway/tagada/Kconfig:
Patch Set #12, Line 9: EARLY_OVERRIDE_LOGLEVEL
I don't think this is needed. See comments in CB:45684
To view, visit change 45134. To unsubscribe, or for help writing mail filters, visit settings.