Attention is currently required from: Arthur Heymans, Nico Huber, Martin Roth, Tim Wawrzynczak, Julius Werner, Rob Barnes, Karthik Ramasubramanian.

View Change

2 comments:

• File src/cpu/x86/smm/smm_module_loader.c:

  • Patch Set #3, Line 562: cbmemc = cbmem_entry_find(CBMEM_ID_CONSOLE);

    nit: wrap in `if (CONFIG_CONSOLE_CBMEM)`?

    Done.

• File src/lib/cbmem_console.c:

  • Patch Set #3, Line 93: if (cbmemc != NULL && cbmemc_size > 0)

    nit: init_console_ptr() already checks both of these

    Yeah. I wanted to avoid making people go and trace `init_console_ptr`. But since you raised it, I'll remove it.

To view, visit change 62355. To unsubscribe, or for help writing mail filters, visit settings.