Attention is currently required from: David Wu, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Paul Menzel, Tarun.
View Change
2 comments:
Commit Message:
Patch Set #5, Line 8:
Please start by mentioning that the touchscreen does not work.
No, the touchscreen can work. But the default setting of SOC_TCHSCR_RST is native function 1. Set SOC_TCHSCR_RST to output low to prevent it pull high unexpectedly.
Patch Set #5, Line 10: Set SOC_TCHSCR_RST to output low in bootblock.
Why in bootblock? So, the delay can be reduced?
It's related to CB:79571. The reason of set EN_TCHSCR_PWR to output high in bootblock is because the delay time between EN_TCHSCR_PWR high --> SOC_TCHSCR_RST high is too short to meet spec. To extend the delay time, set EN_TCHSCR_PWR to output high from romstage_gpio_table to early_gpio_table.
Set SOC_TCHSCR_RST to output low in early_gpio_table is because the default setting of SOC_TCHSCR_RST is native function 1. To prevent it pull high unexpectedly, set it to output low in early_gpio_table.
To view, visit change 80000. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieebd3cf3c320bc895d036c372f792ec7b5d7ebf9
Gerrit-Change-Number: 80000
Gerrit-PatchSet: 5
Gerrit-Owner: Tyler Wang <tyler.wang@quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot@google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani@google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-Reviewer: Tarun <tstuli@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: David Wu <david_wu@quanta.corp-partner.google.com>
Gerrit-Attention: Eran Mitrani <mitrani@google.com>
Gerrit-Attention: Jakub Czapiga <czapiga@google.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal@google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot@google.com>
Gerrit-Attention: Tarun <tstuli@gmail.com>
Gerrit-Comment-Date: Fri, 26 Jan 2024 06:35:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: comment