Attention is currently required from: Andrey Petrov, Felix Singer, Kapil Porwal, Martin L Roth, Paul Menzel.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76927?usp=email )
Change subject: drivers/intel/fsp2_0: Add configurable compression for logo cbfs file
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS6:
Why is that FSP specific?
we are passing the BMP image to FSP since FSP1.1 hence, it ended up here. But agree some better refactor might be required to decouple this assumption.
File src/drivers/intel/fsp2_0/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/76927/comment/c8fe3d10_000c26ca :
PS6, Line 109: endif
: ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZ4),y)
How about: […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76927?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0aa5320632ae3f734004d2b1d495af11c2e1928
Gerrit-Change-Number: 76927
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Tue, 15 Aug 2023 04:46:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-MessageType: comment
