Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47684 )
Change subject: soc/tigerlake: Update early TCSS code to not call back and forth between mainboard and soc
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
I see some comments from earlier patchsets are still not addressed. […]
I addressed most of them just hadn't gone back to mark them as such marked them appropriately
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/47684/comment/e27897cb_7e0155a4
PS2, Line 296: __weak
This is what I am thinking: […]
looks good to me I'll add the changes related to port map in the next patch but this flow looks good. I will also rename the functions in the next patch because this was doing the only updates prior to the new changes. Is that appropriate? This patch is only meant to remove calling back and forth so I don't want to unnecessarily complicate that
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47684
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd50b0ffe1d56dffc3698e07c6e4bc4540d45e73
Gerrit-Change-Number: 47684
Gerrit-PatchSet: 4
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 03 Mar 2021 18:36:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment