2 Nov
2021
2 Nov
'21
1:16 a.m.
Attention is currently required from: Philip Chen, Douglas Anderson, Xuxin Xiong. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58624 )
Change subject: google/trogdor: Add backlight support for Parade ps8640 ......................................................................
Patch Set 8: Code-Review+2
(1 comment)
File src/drivers/parade/ps8640/ps8640.c:
https://review.coreboot.org/c/coreboot/+/58624/comment/02c92b16_069f894f PS7, Line 159: }
For with ps8640 bridge, we didn't need to operate more than 16 bytes, so we didn't test this. […]
Hmmm... yeah, you're right. Strange. I don't really understand how that works. Okay, better not touch it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58624
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief1bf56c89c8215427dcbddfc67e8bcd4c3607d2
Gerrit-Change-Number: 58624
Gerrit-PatchSet: 8
Gerrit-Owner: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Douglas Anderson dianders@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Philip Chen philipchen@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Philip Chen philipchen@google.com
Gerrit-Attention: Philip Chen philipchen@google.com
Gerrit-Attention: Douglas Anderson dianders@chromium.org
Gerrit-Attention: Philip Chen philipchen@chromium.org
Gerrit-Attention: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 02 Nov 2021 00:16:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com
Gerrit-MessageType: comment