3 comments:
File src/southbridge/intel/i82801gx/sata.c:
Patch Set #9, Line 54: struct southbridge_intel_i82801gx_config *config = dev->chip_info;
The whole part to check for AHCI support needs only be run […]
Done
File src/southbridge/intel/i82801gx/sata.c:
Patch Set #11, Line 64: return;
This still bails out too early. It should skip the `ahci_supported` part
but still to the SATA_MAP programming below.
Patch Set #11, Line 87: /* At this point, the new pci id will appear on the bus */
I think code flow could benefit here by further separating the support-check
from the hardware configuration. e.g.
if (config->sata_mode == SATA_MODE_AHCI) {
ahci_supported = lpc_dev && !(pci_read_config32(...) & AHCI_UNSUPPORTED);
if (!ahci_supported)
config->sata_mode = SATA_MODE_IDE_PLAIN;
}
switch (config->sata_mode) {
/* hw config */
}
To view, visit change 30822. To unsubscribe, or for help writing mail filters, visit settings.