Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik, V Sowmya, Vinay Kumar.
Vidya Gopalakrishnan has posted comments on this change by Vidya Gopalakrishnan. ( https://review.coreboot.org/c/coreboot/+/85184?usp=email )
Change subject: mb/google/brya/var/trulo: Update PL1 values as per silicon TDP
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
All comments incorporated
Commit Message:
https://review.coreboot.org/c/coreboot/+/85184/comment/7bc2250e_8ba2ce9b?usp... :
PS3, Line 7: Update PL1 and enable Charger device
Please make it two commits.
Done. Keeping current CL for PL1 update. Moved Charger enablement to CL 85227
https://review.coreboot.org/c/coreboot/+/85184/comment/a84919c8_87727fa6?usp... :
PS3, Line 13: TEST=Build and boot on Trulo board. Verified PL1 value is updated in DTT and sysfs interfaces. Also verified the source for TSR1 is updated to Charger in Passive Policy
Please re-flow for 72 characters per line.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85184?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I798c4f10e10a579f470e00dbdb77a84619ad796a
Gerrit-Change-Number: 85184
Gerrit-PatchSet: 4
Gerrit-Owner: Vidya Gopalakrishnan
vidya.gopalakrishnan@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Comment-Date: Thu, 21 Nov 2024 09:26:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org