Attention is currently required from: Martin L Roth, Subrata Banik, Nick Vaccaro, Yu-Ping Wu, Elyes Haouas, Boris Mittelberg.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72639 )
Change subject: ec/google/chromeec: clang-format ec_commands.h ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72639/comment/46a11bc7_445b3475 PS1, Line 14: future updates don't get overwhelmed : by inconsequential style changes
To solve the problem shouldn't we copy ec_commands. […]
either way, we need to run this file once through clang-format - either with coreboot's config or the EC's config - so the next ec_commands.h refresh patch isn't overwhelming.
if folks prefer this file to maintain the EC repo format, i'm fine with that.
Patchset:
PS1:
Are you using this one https://review.coreboot. […]
no, i'm using the checked-in one.
File src/ec/google/chromeec/ec_commands.h:
https://review.coreboot.org/c/coreboot/+/72639/comment/789a5703_e6d01651 PS1, Line 96: #define EC_LPC_ADDR_HOST_PARAM
consider moving the comment to a single line above this to prevent the weird wrapping: […]
since this patch is a strictly mechanical reformat, we shouldn't apply this change here. we do get this change for "free" with the ec_commands.h refresh from the cros EC repo. that's the next patch.