Patch Set 11:

Patch Set 11:

Patch Set 11:

(1 comment)

Not quite sure why that is. The build failure is not related to this change.
I just clone the coreboot.org repo and RankInDimm is indeed present in DIMM_INFO from
/src/vendorcode/intel/fsp/fsp2_0/glk/FspmUpd.h

But it's not in the apollolake fspupd which is causing the failures.

My build infrastructure did build for GLK, not apollolake (APL). Which is why I did not get this error.
This value will be set to 0 in the APL call. The originally missing RankInDimm bug was filed for GLK.
Aaron, in case this is also needed for APL, I would suggest that you please file a partner issue for APL, so that FSP team for APL can add that field in their UDP info.

View Change

1 comment:

• File 3rdparty/blobs:

  • Patch Set #5, Line 1:

    No, you should not add or delete the submodules pointer as part of your CL. […]

    Done

To view, visit change 31235. To unsubscribe, or for help writing mail filters, visit settings.