[coreboot-gerrit] Change in coreboot[master]: mb/google/corsola: Set GPIO to enable SD card bridge IC

[Hung-Te Lin (Code Review)]

Attention is currently required from: Rex-BC Chen, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60780 )

Change subject: mb/google/corsola: Set GPIO to enable SD card bridge IC
......................................................................

Patch Set 2:

(1 comment)

File src/mainboard/google/corsola/mainboard.c:

https://review.coreboot.org/c/coreboot/+/60780/comment/db63365e_be6c9632 
PS2, Line 46: 		if (CONFIG(BOARD_GOOGLE_KINGLER_COMMON))
            : 			gpio_output(GPIO_EN_PP3300_SDBRDG_X, 1);
            : 		else
            : 			mtk_msdc_configure_sdcard();
I'm confused. for SDCARD_INIT,

BOARD_GOOGLE_KINGLER_COMMON = y,
 BOARD_GOOGLE_KRABBY_COMMON = n,

So what's the case people will have SDCARD_INIT but not CONFIG(BOARD_GOOGLE_KINGLER_COMMON) ?

If no designs will be using the internal SDCard (due to WiFi?), then it's more correct to just say

if (CONFIG(SDCARD_INIT)) {
   ...
   /* External SD Card connected via USB */
   gpio_output(GPIO_EN_PP3300_SDBRDG_X, 1);
 }