May 2025 - coreboot-gerrit - mail.coreboot.org

[L] Change in coreboot[main]: ec/google: Add support for Realtek EC in ChromeOS EC
by Chao Jhan Bo (Code Review) May 29, 2025

May 29, 2025

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Chao Jhan Bo, Jon Murphy, Karthik Ramasubramanian, Paul Menzel, Subrata Banik. Hello Boris Mittelberg, Caveh Jalali, Keith Short, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87544?usp=email to look at the new patch set (#21). Change subject: ec/google: Add support for Realtek EC in ChromeOS EC ...................................................................... ec/google: Add support for Realtek EC in ChromeOS EC This commit adds the necessary infrastructure to support Realtek EC controllers RTS5912/RTS5915 within the ChromeOS EC framework. TEST=With this commit and 87702, flash to brox board with realtek rts5915 Boot normally and got those message from ap console: [DEBUG] Google Chrome EC uptime: 698.137 seconds [DEBUG] Google Chrome AP resets since EC boot: 6 [DEBUG] Google Chrome most recent AP reset causes: [DEBUG] 635.380: 8 reset: during EC initialization [DEBUG] 645.374: 32775 shutdown: entering G3 [DEBUG] 680.284: 8 reset: during EC initialization [DEBUG] 684.586: 8 reset: during EC initialization [DEBUG] Google Chrome EC reset flags at last EC boot: soft [DEBUG] PNP: 0c09.0 init finished in 284 msecs Change-Id: I44118c7b61a7efcee81acdd04be90b5022007a41 Signed-off-by: Jhan Bo Chao <jhan_bo_chao(a)realtek.com> --- M src/ec/google/chromeec/Kconfig M src/ec/google/chromeec/Makefile.mk M src/ec/google/chromeec/ec.h M src/ec/google/chromeec/ec_lpc.c A src/ec/google/chromeec/mec.c A src/ec/google/chromeec/rtk.c M src/ec/google/common/Kconfig 7 files changed, 244 insertions(+), 107 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/87544/21 -- To view, visit https://review.coreboot.org/c/coreboot/+/87544?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I44118c7b61a7efcee81acdd04be90b5022007a41 Gerrit-Change-Number: 87544 Gerrit-PatchSet: 21 Gerrit-Owner: Chao Jhan Bo <jhan_bo_chao(a)realtek.corp-partner.google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Keith Short <keithshort(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jon Murphy <jpmurphy(a)google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Chao Jhan Bo <jhan_bo_chao(a)realtek.corp-partner.google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>

1 0

[L] Change in coreboot[main]: ec/google: Add support for Realtek EC in ChromeOS EC
by Chao Jhan Bo (Code Review) May 29, 2025

May 29, 2025

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Chao Jhan Bo, Jon Murphy, Karthik Ramasubramanian, Paul Menzel, Subrata Banik. Hello Boris Mittelberg, Caveh Jalali, Keith Short, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87544?usp=email to look at the new patch set (#20). Change subject: ec/google: Add support for Realtek EC in ChromeOS EC ...................................................................... ec/google: Add support for Realtek EC in ChromeOS EC This commit adds the necessary infrastructure to support Realtek EC controllers RTS5912/RTS5915 within the ChromeOS EC framework. TEST=With this commit, emerge-brox coreboot depthcharge chromeos-bootimage -j success With this commit and 87702, build success flash to brox board with realtek rts5915 Boot normally and got those message from ap console: [DEBUG] Google Chrome EC uptime: 698.137 seconds [DEBUG] Google Chrome AP resets since EC boot: 6 [DEBUG] Google Chrome most recent AP reset causes: [DEBUG] 635.380: 8 reset: during EC initialization [DEBUG] 645.374: 32775 shutdown: entering G3 [DEBUG] 680.284: 8 reset: during EC initialization [DEBUG] 684.586: 8 reset: during EC initialization [DEBUG] Google Chrome EC reset flags at last EC boot: soft [DEBUG] PNP: 0c09.0 init finished in 284 msecs Change-Id: I44118c7b61a7efcee81acdd04be90b5022007a41 Signed-off-by: Jhan Bo Chao <jhan_bo_chao(a)realtek.com> --- M src/ec/google/chromeec/Kconfig M src/ec/google/chromeec/Makefile.mk M src/ec/google/chromeec/ec.h M src/ec/google/chromeec/ec_lpc.c A src/ec/google/chromeec/mec.c A src/ec/google/chromeec/rtk.c M src/ec/google/common/Kconfig 7 files changed, 244 insertions(+), 107 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/87544/20 -- To view, visit https://review.coreboot.org/c/coreboot/+/87544?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I44118c7b61a7efcee81acdd04be90b5022007a41 Gerrit-Change-Number: 87544 Gerrit-PatchSet: 20 Gerrit-Owner: Chao Jhan Bo <jhan_bo_chao(a)realtek.corp-partner.google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Keith Short <keithshort(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jon Murphy <jpmurphy(a)google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Chao Jhan Bo <jhan_bo_chao(a)realtek.corp-partner.google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/brox: Enable support for Realtek EC
by Chao Jhan Bo (Code Review) May 29, 2025

May 29, 2025

Attention is currently required from: Chao Jhan Bo, Karthik Ramasubramanian, Paul Menzel. Hello Karthik Ramasubramanian, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87702?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/brox: Enable support for Realtek EC ...................................................................... mb/google/brox: Enable support for Realtek EC TEST=With this commit and 87544 emerge-brox coreboot depthcharge chromeos-bootimage -j flash to brox board with realtek rts5915 Boot normally and got those message from ap console: [DEBUG] Google Chrome EC uptime: 698.137 seconds [DEBUG] Google Chrome AP resets since EC boot: 6 [DEBUG] Google Chrome most recent AP reset causes: [DEBUG] 635.380: 8 reset: during EC initialization [DEBUG] 645.374: 32775 shutdown: entering G3 [DEBUG] 680.284: 8 reset: during EC initialization [DEBUG] 684.586: 8 reset: during EC initialization [DEBUG] Google Chrome EC reset flags at last EC boot: soft [DEBUG] PNP: 0c09.0 init finished in 284 msecs Change-Id: I15cebd5e35fac737719bddad56ed5c42d4d5bef8 Signed-off-by: Jhan Bo Chao <jhan_bo_chao(a)realtek.com> --- M src/mainboard/google/brox/Kconfig M src/mainboard/google/brox/bootblock.c 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/87702/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/87702?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I15cebd5e35fac737719bddad56ed5c42d4d5bef8 Gerrit-Change-Number: 87702 Gerrit-PatchSet: 11 Gerrit-Owner: Chao Jhan Bo <jhan_bo_chao(a)realtek.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Keith Short <keithshort(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Chao Jhan Bo <jhan_bo_chao(a)realtek.corp-partner.google.com>

1 0

[L] Change in coreboot[main]: crossgcc: upgrade binutils from version 2.43 to 2.44
by Paul Menzel (Code Review) May 29, 2025

May 29, 2025

Attention is currently required from: Elyes Haouas, Martin L Roth. Paul Menzel has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86254?usp=email ) Change subject: crossgcc: upgrade binutils from version 2.43 to 2.44 ...................................................................... Patch Set 12: (1 comment) File util/crossgcc/patches/binutils-2.43.1_as-ipxe.patch: PS12: Mention the removal in the commit message? -- To view, visit https://review.coreboot.org/c/coreboot/+/86254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic78053f55c59de7af16fca0265d0d23fadfb20f6 Gerrit-Change-Number: 86254 Gerrit-PatchSet: 12 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 29 May 2025 17:36:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: crossgcc: Upgrade LLVM from 18.1.8 to 20.1.6
by Paul Menzel (Code Review) May 29, 2025

May 29, 2025

Attention is currently required from: Elyes Haouas. Paul Menzel has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/85986?usp=email ) Change subject: crossgcc: Upgrade LLVM from 18.1.8 to 20.1.6 ...................................................................... Patch Set 11: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85986/comment/09efb7d8_6300ebc6?us… : PS11, Line 8: How did you test this? https://review.coreboot.org/c/coreboot/+/85986/comment/8f240c83_03f1c037?us… : PS11, Line 8: Any build time or size changes? https://review.coreboot.org/c/coreboot/+/85986/comment/228a79ba_c4a7f4cb?us… : PS11, Line 8: Please mention the removal of `util/crossgcc/patches/clang-18.1.8.src_x86_baremetal.patch`, and best give the commit, if it was applied upstream. -- To view, visit https://review.coreboot.org/c/coreboot/+/85986?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4d12a0f46a9cddee1a06f584ff7193e81e7815a6 Gerrit-Change-Number: 85986 Gerrit-PatchSet: 11 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 29 May 2025 17:35:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: security/vboot: Back up CMOS data later boot phase
by Subrata Banik (Code Review) May 29, 2025

May 29, 2025

Attention is currently required from: Avi Uday, Intel coreboot Reviewers, Jayvik Desai, Julius Werner, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N, Wonkyu Kim, Yu-Ping Wu. Subrata Banik has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/87738?usp=email ) Change subject: security/vboot: Back up CMOS data later boot phase ...................................................................... Patch Set 18: (2 comments) File src/Kconfig: https://review.coreboot.org/c/coreboot/+/87738/comment/ec15de98_70dd4f20?us… : PS18, Line 1574: simultaneous accesses from other other SPI masters like CSE. > `Possible repeated word: 'other'` Please fix. https://review.coreboot.org/c/coreboot/+/87738/comment/764c265d_013592cc?us… : PS18, Line 1575: SOCs( ```SoCs (``` -- To view, visit https://review.coreboot.org/c/coreboot/+/87738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8836c14601beb56c614605b9840c8506d6d8536c Gerrit-Change-Number: 87738 Gerrit-PatchSet: 18 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Thu, 29 May 2025 17:14:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: security/vboot: Back up CMOS data later boot phase
by Wonkyu Kim (Code Review) May 29, 2025

May 29, 2025

Attention is currently required from: Avi Uday, Intel coreboot Reviewers, Jayvik Desai, Julius Werner, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N, Subrata Banik, Yu-Ping Wu. Wonkyu Kim has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/87738?usp=email ) Change subject: security/vboot: Back up CMOS data later boot phase ...................................................................... Patch Set 18: (3 comments) File src/Kconfig: https://review.coreboot.org/c/coreboot/+/87738/comment/6842c008_f76b0479?us… : PS17, Line 1567: DELAY_SPI_ACCESS > can we add depends on `Intel Platform` Kconfig to avoid impacting other SoC platforms Done https://review.coreboot.org/c/coreboot/+/87738/comment/fffbec93_ce69dc0e?us… : PS17, Line 1571: access > SPI write access Done https://review.coreboot.org/c/coreboot/+/87738/comment/b070f662_df236385?us… : PS17, Line 1573: boot controllers > nit […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/87738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8836c14601beb56c614605b9840c8506d6d8536c Gerrit-Change-Number: 87738 Gerrit-PatchSet: 18 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Thu, 29 May 2025 17:10:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: security/vboot: Back up CMOS data later boot phase
by Wonkyu Kim (Code Review) May 29, 2025

May 29, 2025

Attention is currently required from: Avi Uday, Intel coreboot Reviewers, Jayvik Desai, Julius Werner, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N, Wonkyu Kim, Yu-Ping Wu. Hello Avi Uday, Intel coreboot Reviewers, Jayvik Desai, Julius Werner, Kapil Porwal, Pranava Y N, Subrata Banik, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87738?usp=email to look at the new patch set (#18). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: security/vboot: Back up CMOS data later boot phase ...................................................................... security/vboot: Back up CMOS data later boot phase Introduce DELAY_SPI_ACCESS to save CMOS data later boot phase to avoid flash access delay by other boot controller. Intel has pre-CPU boot controllers(ex. CSE) which load non CPU FWs. Boot critical FWs are loaded before CPU reset and non boot critical boot FWs are loaded during CPU boot. If other controller accesses spi to load FWs, reading spi by CPU is ok but writing SPI time for saving CMOS data takes ~30ms sometimes. Saving CMOS data takes less than 1ms usually. Before this change, sometime it delays like below BS: callback (0x7386f908) @ src/security/vboot/vbnv_cmos.c:122 (32 ms) Atfer this change, the delay is less than 1 ms BS: callback (0x7386f908) @ src/security/vboot/vbnv_cmos.c:122 (0 ms) TEST 1. enable DEBUG_BOOT_STATE 2. check time BS: callback (0x7386f908) @ src/security/vboot/vbnv_cmos.c:120 (0 ms) Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com> Change-Id: I8836c14601beb56c614605b9840c8506d6d8536c --- M src/Kconfig M src/security/vboot/vbnv_cmos.c 2 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/87738/18 -- To view, visit https://review.coreboot.org/c/coreboot/+/87738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8836c14601beb56c614605b9840c8506d6d8536c Gerrit-Change-Number: 87738 Gerrit-PatchSet: 18 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[S] Change in coreboot[main]: mb/hp/snb_ivb_desktops: Add gfx_uma_size options up to 1 GB
by Angel Pons (Code Review) May 29, 2025

May 29, 2025

Attention is currently required from: Keith Hui, Walter Sonius. Angel Pons has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/87192?usp=email ) Change subject: mb/hp/snb_ivb_desktops: Add gfx_uma_size options up to 1 GB ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87192?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id89290a673b0e5dbc72c11c097aeb70d410adeab Gerrit-Change-Number: 87192 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Walter Sonius <walterav1984(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Walter Sonius <walterav1984(a)gmail.com> Gerrit-Comment-Date: Thu, 29 May 2025 16:48:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: crossgcc: Upgrade LLVM from 18.1.8 to 20.1.6
by Elyes Haouas (Code Review) May 29, 2025

May 29, 2025

Attention is currently required from: Elyes Haouas. Hello Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85986?usp=email to look at the new patch set (#11). Change subject: crossgcc: Upgrade LLVM from 18.1.8 to 20.1.6 ...................................................................... crossgcc: Upgrade LLVM from 18.1.8 to 20.1.6 Change-Id: I4d12a0f46a9cddee1a06f584ff7193e81e7815a6 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc D util/crossgcc/patches/clang-18.1.8.src_x86_baremetal.patch D util/crossgcc/sum/clang-18.1.8.src.tar.xz.cksum A util/crossgcc/sum/clang-20.1.6.src.tar.xz.cksum D util/crossgcc/sum/clang-tools-extra-18.1.8.src.tar.xz.cksum A util/crossgcc/sum/clang-tools-extra-20.1.6.src.tar.xz.cksum D util/crossgcc/sum/cmake-18.1.8.src.tar.xz.cksum A util/crossgcc/sum/cmake-20.1.6.src.tar.xz.cksum D util/crossgcc/sum/compiler-rt-18.1.8.src.tar.xz.cksum A util/crossgcc/sum/compiler-rt-20.1.6.src.tar.xz.cksum D util/crossgcc/sum/libunwind-18.1.8.src.tar.xz.cksum A util/crossgcc/sum/libunwind-20.1.6.src.tar.xz.cksum D util/crossgcc/sum/lld-18.1.8.src.tar.xz.cksum A util/crossgcc/sum/lld-20.1.6.src.tar.xz.cksum D util/crossgcc/sum/llvm-18.1.8.src.tar.xz.cksum A util/crossgcc/sum/llvm-20.1.6.src.tar.xz.cksum 16 files changed, 8 insertions(+), 37 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/85986/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/85986?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4d12a0f46a9cddee1a06f584ff7193e81e7815a6 Gerrit-Change-Number: 85986 Gerrit-PatchSet: 11 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0