May 2025 - coreboot-gerrit - mail.coreboot.org

[S] Change in blobs[main]: soc/mediatek/mt8196: Update libbl31.a to version 16297.0.0
by Yidi Lin (Code Review) May 30, 2025

May 30, 2025

Yidi Lin has submitted this change. ( https://review.coreboot.org/c/blobs/+/87882?usp=email ) Change subject: soc/mediatek/mt8196: Update libbl31.a to version 16297.0.0 ...................................................................... soc/mediatek/mt8196: Update libbl31.a to version 16297.0.0 libbl31.a, version 16297.0.0, reduces the dependency on ATF framework and other MediaTek drivers. arm-trusted-firmware repo needs the following commit to link this library at the build time. commit 02309a84fbfb8b3469aa7dba52ea15c9bf2a768d Merge: fbab861f7 5be0e2259 Author: Govindraj Raja <govindraj.raja(a)arm.com> Date: Tue May 27 15:07:44 2025 +0000 Merge changes Ia29fd72f,I31b359ce,I1296aaff,I30e1ee7f,Ib4a3593e, ... into integration BUG=b:414543140, b:412560091 TEST=1. Update atf repo to includes the commit 02309a84fbfb. 2. Specify MTKLIB_PATH for mt8196 by reverting CB:87414 3. emerge-rauru coreboot chromeos-bootimage 4. Ensure the device booting to shell Change-Id: I5a0a0f6f689c0a11fc2db8fd036c121116540520 Signed-off-by: Yidi Lin <yidilin(a)google.com> --- M soc/mediatek/mt8196/libbl31.a M soc/mediatek/mt8196/libbl31.a.md5 M soc/mediatek/mt8196/libbl31_release_note.txt 3 files changed, 17 insertions(+), 1 deletion(-) Approvals: Yu-Ping Wu: Verified; Looks good to me, approved diff --git a/soc/mediatek/mt8196/libbl31.a b/soc/mediatek/mt8196/libbl31.a index f758652..e1e280f 100644 --- a/soc/mediatek/mt8196/libbl31.a +++ b/soc/mediatek/mt8196/libbl31.a Binary files differ diff --git a/soc/mediatek/mt8196/libbl31.a.md5 b/soc/mediatek/mt8196/libbl31.a.md5 index 7aa5560..248f9c6 100644 --- a/soc/mediatek/mt8196/libbl31.a.md5 +++ b/soc/mediatek/mt8196/libbl31.a.md5 @@ -1 +1 @@ -0316f5be548efda05e915d2cd7d0f179 *libbl31.a +62c9955b9dec3d7b62a0ae4fcfcb5c32 *libbl31.a diff --git a/soc/mediatek/mt8196/libbl31_release_note.txt b/soc/mediatek/mt8196/libbl31_release_note.txt index c0f5c9b..57ac47b 100644 --- a/soc/mediatek/mt8196/libbl31_release_note.txt +++ b/soc/mediatek/mt8196/libbl31_release_note.txt @@ -1,3 +1,19 @@ +# 16297.0.0 + +1. Included patches: + +- CL:*8009011 CHROMIUM: feat(mt8196): add version info for the static library +- CL:*8011910 feat(mt8196): add smmu_sid drivers +- CL:*8258897 FROMLIST: feat(mt8196): add MMinfra support +- CL:*8207835 feat(mt8196): add CPU QoS driver +- CL:*8207834 feat(mt8196): add MT8196 SMPU driver +- CL:*8258896 FROMLIST: refactor(mediatek): update EMI stub implementation +- CL:*8240599 feat(mediatek): add APIs exposed to the static library +- CL:*8008748 FROMLIST: fix(mt8196): add whole-archive option to prebuilt library +- CL:*7046297 feat(mt8196): add private UFS driver +- CL:*8207833 feat(mt8196): add SMMU driver for PM +- CL:*8207832 feat(mt8196): enable appropriate errata + # 16174.21.0 1. Included patches: -- To view, visit https://review.coreboot.org/c/blobs/+/87882?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I5a0a0f6f689c0a11fc2db8fd036c121116540520 Gerrit-Change-Number: 87882 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: ec/google/chromeec: Add SPI/I2C EC communication files to bootblock
by Subrata Banik (Code Review) May 30, 2025

May 30, 2025

Attention is currently required from: Boris Mittelberg, Caveh Jalali. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87904?usp=email ) Change subject: ec/google/chromeec: Add SPI/I2C EC communication files to bootblock ...................................................................... ec/google/chromeec: Add SPI/I2C EC communication files to bootblock This commit updates `ec/google/chromeec/Makefile.mk` to properly include source files for SPI and I2C Embedded Controller (EC) communication in the bootblock. Previously, essential APIs (e.g., `google_chromeec_command` and `crosec_command_proto`) were missing during EC code compilation in the bootblock, leading to linker errors. This patch resolves these compilation issues by ensuring: * `ec_spi.c` is included when `CONFIG_EC_GOOGLE_CHROMEEC_SPI` is enabled. * `crosec_proto.c` is included if either `CONFIG_EC_GOOGLE_CHROMEEC_SPI` or `CONFIG_EC_GOOGLE_CHROMEEC_I2C` is enabled. This ensures all required EC communication components are part of the bootblock, allowing systems like `google/quenbi` that use the SPI EC interface to build successfully. Change-Id: I1d05f582a1685503118797e1788c9bc2ac191168 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/ec/google/chromeec/Makefile.mk 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/87904/1 diff --git a/src/ec/google/chromeec/Makefile.mk b/src/ec/google/chromeec/Makefile.mk index 54d4040..b634a49 100644 --- a/src/ec/google/chromeec/Makefile.mk +++ b/src/ec/google/chromeec/Makefile.mk @@ -22,6 +22,10 @@ bootblock-y += ec.c bootblock-$(CONFIG_EC_GOOGLE_CHROMEEC_LPC) += ec_lpc.c +bootblock-$(CONFIG_EC_GOOGLE_CHROMEEC_SPI) += ec_spi.c +ifeq ($(CONFIG_EC_GOOGLE_CHROMEEC_SPI)$(CONFIG_EC_GOOGLE_CHROMEEC_I2C),y) +bootblock-y += crosec_proto.c +endif ramstage-y += ec.c crosec_proto.c vstore.c usbc_mux.c ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC_I2C) += ec_i2c.c ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC_LPC) += ec_lpc.c -- To view, visit https://review.coreboot.org/c/coreboot/+/87904?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d05f582a1685503118797e1788c9bc2ac191168 Gerrit-Change-Number: 87904 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/bluey: Increase bootblock size to 120KB
by Subrata Banik (Code Review) May 30, 2025

May 30, 2025

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87903?usp=email ) Change subject: mb/google/bluey: Increase bootblock size to 120KB ...................................................................... mb/google/bluey: Increase bootblock size to 120KB The bootblock size for the Google Bluey mainboard has been increased from 96KB to 120KB. This change is necessary to accommodate the growing size of the bootblock image, which now exceeds the previous 96KB limit. This expansion ensures that the complete bootblock code, including critical initialization routines and potentially new features, fits within its allocated flash region. TEST=Able to build google/quenbi. Change-Id: I7bf2c8c6c540327f1b4233ee5ba4e0703d1200f9 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/bluey/chromeos.fmd 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/87903/1 diff --git a/src/mainboard/google/bluey/chromeos.fmd b/src/mainboard/google/bluey/chromeos.fmd index 0ad818b..1bea2f9 100644 --- a/src/mainboard/google/bluey/chromeos.fmd +++ b/src/mainboard/google/bluey/chromeos.fmd @@ -3,7 +3,7 @@ FLASH@0x0 CONFIG_ROM_SIZE { WP_RO 4M { RO_SECTION 0x3c4000 { - BOOTBLOCK 96K + BOOTBLOCK 120K COREBOOT(CBFS) FMAP@0x3c0000 0x1000 GBB 0x2f00 -- To view, visit https://review.coreboot.org/c/coreboot/+/87903?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7bf2c8c6c540327f1b4233ee5ba4e0703d1200f9 Gerrit-Change-Number: 87903 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/ocelot/var/ocelot: remove unused gpios
by 9elements QA (Code Review) May 30, 2025

May 30, 2025

9elements QA has posted comments on this change by Nick Vaccaro. ( https://review.coreboot.org/c/coreboot/+/87870?usp=email ) Change subject: mb/google/ocelot/var/ocelot: remove unused gpios ...................................................................... Patch Set 2: Automatic boot test returned (PASS/FAIL/TOTAL): 11 / 1 / 12 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/241881 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/241879 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/241878 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/241877 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/241876 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/241875 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/241874 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/241873 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/241872 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/241871 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/241870 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/241869 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/87870?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ife444cef816ca2b69db466661c63935f72836554 Gerrit-Change-Number: 87870 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Fri, 30 May 2025 15:34:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/trulo/var/pujjocento: Update gpio setting for DDI-B
by Paul Menzel (Code Review) May 30, 2025

May 30, 2025

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Kun Liu, Nick Vaccaro, Subrata Banik. Paul Menzel has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/87900?usp=email ) Change subject: mb/google/trulo/var/pujjocento: Update gpio setting for DDI-B ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/87900/comment/7b12e1ad_5485fee6?us… : PS3, Line 9: hardware schematic If you have it handy, having the version/file name, would be great. -- To view, visit https://review.coreboot.org/c/coreboot/+/87900?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I61ef761df7936fb42d4fe68a2b5cd2fa649b7b33 Gerrit-Change-Number: 87900 Gerrit-PatchSet: 3 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Fri, 30 May 2025 14:51:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/trulo/var/pujjocento: Update gpio setting for DDI-B
by Kun Liu (Code Review) May 30, 2025

May 30, 2025

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87900?usp=email to look at the new patch set (#3). Change subject: mb/google/trulo/var/pujjocento: Update gpio setting for DDI-B ...................................................................... mb/google/trulo/var/pujjocento: Update gpio setting for DDI-B Modify according to the hardware schematic as follows: GPP_A20 ---> GPP_A18 GPP_E20 ---> GPP_H15 GPP_E21 ---> GPP_H17 BUG=b:409254508 BRANCH=none TEST=emerge-nissa coreboot chromeos-bootimage. Change-Id: I61ef761df7936fb42d4fe68a2b5cd2fa649b7b33 Signed-off-by: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/pujjocento/gpio.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/87900/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/87900?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I61ef761df7936fb42d4fe68a2b5cd2fa649b7b33 Gerrit-Change-Number: 87900 Gerrit-PatchSet: 3 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[S] Change in coreboot[main]: mb/google/trulo/var/pujjocento: Update gpio setting for DDI-B
by Kun Liu (Code Review) May 30, 2025

May 30, 2025

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik. Kun Liu has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/87900?usp=email ) Change subject: mb/google/trulo/var/pujjocento: Update gpio setting for DDI-B ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/87900/comment/0c0beb14_45d74e91?us… : PS1, Line 9: Changes for DDI-B, GPP_A18/DDSP_HPDB, GPP_H15/DDPB_CTRLCLK, : GPP_H17/DDPB_CTRLDATA > Please make it a sentence, and also mention the source. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/87900?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I61ef761df7936fb42d4fe68a2b5cd2fa649b7b33 Gerrit-Change-Number: 87900 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Fri, 30 May 2025 09:52:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: mb/google/trulo/var/pujjocento: Update gpio setting for DDI-B
by Kun Liu (Code Review) May 30, 2025

May 30, 2025

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Kun Liu, Nick Vaccaro, Subrata Banik. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87900?usp=email to look at the new patch set (#2). Change subject: mb/google/trulo/var/pujjocento: Update gpio setting for DDI-B ...................................................................... mb/google/trulo/var/pujjocento: Update gpio setting for DDI-B Modify according to the hardware schematic as follows: GPP_A20 --->GPP_A18 GPP_E20 --->GPP_H15 GPP_E21 --->GPP_H17 BUG=b:409254508 BRANCH=none TEST=emerge-nissa coreboot chromeos-bootimage. Change-Id: I61ef761df7936fb42d4fe68a2b5cd2fa649b7b33 Signed-off-by: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/pujjocento/gpio.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/87900/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87900?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I61ef761df7936fb42d4fe68a2b5cd2fa649b7b33 Gerrit-Change-Number: 87900 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>

1 0

[L] Change in coreboot[main]: ec/google: Add support for Realtek EC in ChromeOS EC
by Paul Menzel (Code Review) May 30, 2025

May 30, 2025

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Chao Jhan Bo, Jon Murphy, Karthik Ramasubramanian, Keith Short, Subrata Banik. Paul Menzel has posted comments on this change by Chao Jhan Bo. ( https://review.coreboot.org/c/coreboot/+/87544?usp=email ) Change subject: ec/google: Add support for Realtek EC in ChromeOS EC ...................................................................... Patch Set 21: (5 comments) File src/ec/google/chromeec/rtk.c: https://review.coreboot.org/c/coreboot/+/87544/comment/3778992d_0c51e607?us… : PS21, Line 70: initial initiated? https://review.coreboot.org/c/coreboot/+/87544/comment/2b7db855_5bc88605?us… : PS21, Line 71: need need*s* https://review.coreboot.org/c/coreboot/+/87544/comment/6a437a1a_d5cd4648?us… : PS21, Line 71: emi EMI https://review.coreboot.org/c/coreboot/+/87544/comment/e19b3f14_2fa45c09?us… : PS21, Line 71: acpi ACPI https://review.coreboot.org/c/coreboot/+/87544/comment/7cea50cc_d40fe118?us… : PS21, Line 74: printk(BIOS_INFO, "RTS5915 EMI initial.\n"); Add it to the end, or do two: printk(BIOS_INFO, "RTS5915 EMI: start init …\n"); […] printk(BIOS_INFO, "done\n"); (If it’s multi-threaded that won’t work though, so then only one message at the end?) -- To view, visit https://review.coreboot.org/c/coreboot/+/87544?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I44118c7b61a7efcee81acdd04be90b5022007a41 Gerrit-Change-Number: 87544 Gerrit-PatchSet: 21 Gerrit-Owner: Chao Jhan Bo <jhan_bo_chao(a)realtek.corp-partner.google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Keith Short <keithshort(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jon Murphy <jpmurphy(a)google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Keith Short <keithshort(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Chao Jhan Bo <jhan_bo_chao(a)realtek.corp-partner.google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Fri, 30 May 2025 09:37:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/fatcat: Update flash layout
by Paul Menzel (Code Review) May 30, 2025

May 30, 2025

Attention is currently required from: Avi Uday, Jayvik Desai, Kapil Porwal, Pranava Y N, Subrata Banik. Paul Menzel has posted comments on this change by Pranava Y N. ( https://review.coreboot.org/c/coreboot/+/87860?usp=email ) Change subject: mb/google/fatcat: Update flash layout ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/87860/comment/27fb8262_df2d6cb6?us… : PS3, Line 7: Update flash layout More specific: fmap: Add 1 MB from SI_BIOS to SI_All -- To view, visit https://review.coreboot.org/c/coreboot/+/87860?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I615b26ccdbbf3cfcc18dfb5917e13f0700ba673c Gerrit-Change-Number: 87860 Gerrit-PatchSet: 3 Gerrit-Owner: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 30 May 2025 09:32:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0