May 2025 - coreboot-gerrit - mail.coreboot.org

[S] Change in coreboot[main]: mb/starlabs/starlite_adl: Add CFR option to use native panel resolution
by Alicja Michalska (Code Review) May 1, 2025

May 1, 2025

Attention is currently required from: Matt DeVillier, Sean Rhodes. Alicja Michalska has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/87494?usp=email ) Change subject: mb/starlabs/starlite_adl: Add CFR option to use native panel resolution ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/87494?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I275b5f8455fed58c0167e3a69db27bbc21577db0 Gerrit-Change-Number: 87494 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Thu, 01 May 2025 02:43:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook: Add CFR option to use native panel resolution
by Alicja Michalska (Code Review) May 1, 2025

May 1, 2025

Attention is currently required from: Matt DeVillier, Sean Rhodes. Alicja Michalska has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/87493?usp=email ) Change subject: mb/starlabs/starbook: Add CFR option to use native panel resolution ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/87493?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia75727f393744caf9062763e6118c1e2601512fa Gerrit-Change-Number: 87493 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Thu, 01 May 2025 02:42:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/starlabs/starfighter: Add CFR option to use native panel resolution
by Alicja Michalska (Code Review) May 1, 2025

May 1, 2025

Attention is currently required from: Matt DeVillier, Sean Rhodes. Alicja Michalska has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/87495?usp=email ) Change subject: mb/starlabs/starfighter: Add CFR option to use native panel resolution ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/mainboard/starlabs/starfighter/cfr.c: https://review.coreboot.org/c/coreboot/+/87495/comment/e294f891_06261b73?us… : PS1, Line 170: . \n? -- To view, visit https://review.coreboot.org/c/coreboot/+/87495?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9e39258ce0171aab425150679d1ce30d69b2b1ef Gerrit-Change-Number: 87495 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Thu, 01 May 2025 02:42:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libgfxinit[main]: common/dp_aux_request: Add support for TGL
by Alicja Michalska (Code Review) May 1, 2025

May 1, 2025

Attention is currently required from: Angel Pons, Jérémy Compostella, Nico Huber, Tim Wawrzynczak. Alicja Michalska has posted comments on this change by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67497?usp=email ) Change subject: common/dp_aux_request: Add support for TGL ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: Just bumped into this patch while reviewing other stuff. I believe that's what I was missing to have DisplayPort working on my port. Should we re-base it and push for merge? -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67497?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I5f2ae7f1a5961c7a8c28e3091bab94a40000ba10 Gerrit-Change-Number: 67497 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 01 May 2025 02:38:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: AUTHORS: Update list to 25.03
by Alicja Michalska (Code Review) May 1, 2025

May 1, 2025

Attention is currently required from: Martin L Roth. Alicja Michalska has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/87381?usp=email ) Change subject: AUTHORS: Update list to 25.03 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Didn't we have similar policy to Linux (real name, proper sign-off)? I see many contributors using either just their first name, or a nickname so I'm curious. -- To view, visit https://review.coreboot.org/c/coreboot/+/87381?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I23f38bd125a8369e0a636c4d1602c783f6730a0a Gerrit-Change-Number: 87381 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Thu, 01 May 2025 02:32:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[NoOp] Change in coreboot[main]: mb/lenovo/m900_tiny: Update VBT to build 1037 with Kaby Lake gfx support
by Alicja Michalska (Code Review) May 1, 2025

May 1, 2025

Attention is currently required from: Alexander Couzens, Krystian Hebel, Michał Kopeć, Michał Żygowski. Alicja Michalska has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/84873?usp=email ) Change subject: mb/lenovo/m900_tiny: Update VBT to build 1037 with Kaby Lake gfx support ...................................................................... Patch Set 8: Code-Review+1 (1 comment) Patchset: PS8: LGTM (assuming KBL VBT can be used on SKL CPUs as well) -- To view, visit https://review.coreboot.org/c/coreboot/+/84873?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e108d4ad8bf0663f3e1fa32145e40ea9babeac5 Gerrit-Change-Number: 84873 Gerrit-PatchSet: 8 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 01 May 2025 02:29:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/msi/{ms7d25,ms7e06}/devicetree.cb: Add fan control config
by Alicja Michalska (Code Review) May 1, 2025

May 1, 2025

Attention is currently required from: Michał Kopeć, Michał Żygowski. Alicja Michalska has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/87478?usp=email ) Change subject: mb/msi/{ms7d25,ms7e06}/devicetree.cb: Add fan control config ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: NIT/thinking loudly: It would be neat to have fan options exposed to end-users in form of CFR (or other method) to be able to configure it from EDK2. (Maybe a good idea to write small piece of generic code that could be imported as headers for SIO/EC fan control?) Of course in Linux you can always use pwmconfig for this, but as we all know, Windows isn't so smart... and (sadly) some people are still using it, -- To view, visit https://review.coreboot.org/c/coreboot/+/87478?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iba142c2ad683962ee2c007f387e87adc77352dad Gerrit-Change-Number: 87478 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Thu, 01 May 2025 02:27:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/msi/{ms7d25,ms7e06}: Mimic the vendor BIOS early SIO init
by Alicja Michalska (Code Review) May 1, 2025

May 1, 2025

Attention is currently required from: Michał Kopeć, Michał Żygowski. Alicja Michalska has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/87477?usp=email ) Change subject: mb/msi/{ms7d25,ms7e06}: Mimic the vendor BIOS early SIO init ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/87477?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I058560733e3f5bb8c6df7d5401efad87911d3f4a Gerrit-Change-Number: 87477 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Thu, 01 May 2025 02:23:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: util: Add Microchip EC FW tool
by Alicja Michalska (Code Review) May 1, 2025

May 1, 2025

Attention is currently required from: Patrick Rudolph, Paul Menzel. Alicja Michalska has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/87428?usp=email ) Change subject: util: Add Microchip EC FW tool ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Patchset: PS6: Wouldn't it be better to specify FMAP region, rather than having to provide it's name to the tool? For example: `MCEC_FW`? Other than that, LGTM 😊 -- To view, visit https://review.coreboot.org/c/coreboot/+/87428?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3b74c9f65643ad4437de29d4aed307b1a2b33286 Gerrit-Change-Number: 87428 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 01 May 2025 02:20:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: allocator_v4: Re-enable top-down allocation for edk2
by Alicja Michalska (Code Review) May 1, 2025

May 1, 2025

Attention is currently required from: Felix Singer, Matt DeVillier, Sean Rhodes. Alicja Michalska has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/87504?usp=email ) Change subject: allocator_v4: Re-enable top-down allocation for edk2 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Have you checked all (modern) SoCs? Last time I tried your fork with top-down alloc, it broke iGPU on TGL-H. Sure, there are only two boards in coreboot with this specific SoC (sys76/oryp8, erying/tgl) but still... I can re-test that to make sure though. -- To view, visit https://review.coreboot.org/c/coreboot/+/87504?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0e9b0d02bbf30878aef37a97d6a743a402700fc7 Gerrit-Change-Number: 87504 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Thu, 01 May 2025 02:09:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0