May 2025 - coreboot-gerrit - mail.coreboot.org

[XS] Change in coreboot[main]: payloads/libpayload/Makefile.mk: Replace nm with $(NM)
by NyeonWoo Kim (Code Review) May 31, 2025

May 31, 2025

NyeonWoo Kim has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/87906?usp=email ) Change subject: payloads/libpayload/Makefile.mk: Replace nm with $(NM) ...................................................................... payloads/libpayload/Makefile.mk: Replace nm with $(NM) I got 'nm' usage error when i built coreinfo payload. nm: unrecognized option '--no-weak' it seems that this is occurred by using nm for host, not for coreboot. So, I replace nm with $(NM) Change-Id: I0a0a04b351c9131b1238e8cc7e63e396820494d9 Signed-off-by: NyeonWoo Kim <knw0507(a)naver.com> --- M payloads/libpayload/Makefile.mk 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/87906/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/87906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0a0a04b351c9131b1238e8cc7e63e396820494d9 Gerrit-Change-Number: 87906 Gerrit-PatchSet: 2 Gerrit-Owner: NyeonWoo Kim Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: payloads/libpayload/Makefile.mk: Replace nm with $(NM)
by NyeonWoo Kim (Code Review) May 31, 2025

May 31, 2025

NyeonWoo Kim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87906?usp=email ) Change subject: payloads/libpayload/Makefile.mk: Replace nm with $(NM) ...................................................................... payloads/libpayload/Makefile.mk: Replace nm with $(NM) I got 'nm' usage error when i built coreinfo payload. nm: unrecognized option '--no-weak' it seems that this is occured by using nm for host, not for coreboot. So, I replace nm with $(NM) Change-Id: I0a0a04b351c9131b1238e8cc7e63e396820494d9 Signed-off-by: NyeonWoo Kim <knw0507(a)naver.com> --- M payloads/libpayload/Makefile.mk 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/87906/1 diff --git a/payloads/libpayload/Makefile.mk b/payloads/libpayload/Makefile.mk index 8c6b287..08249c2 100644 --- a/payloads/libpayload/Makefile.mk +++ b/payloads/libpayload/Makefile.mk @@ -110,8 +110,8 @@ $(obj)/libpayload.a: $(foreach class,$(libraries),$$($(class)-objs)) printf " AR $(subst $(CURDIR)/,,$(@))\n" printf "create $@\n$(foreach objc,$(filter-out %.a,$^),addmod $(objc)\n)$(foreach lib,$(filter %.a,$^),addlib $(lib)\n)save\nend\n" | $(AR) -M - for func in $$(nm $@ | awk '/ (w|W) / { print $$NF }'); do \ - if nm --no-weak --defined-only $@ | grep -Eq " $$func$$"; then \ + for func in $$($(NM) $@ | awk '/ (w|W) / { print $$NF }'); do \ + if $(NM) --no-weak --defined-only $@ | grep -Eq " $$func$$"; then \ printf "\nERROR: Function '$$func' appears as both weak and strong symbol in libpayload.\n"; \ printf " Weak symbol overrides don't work reliably from within the same library.\n\n"; \ rm $@; \ -- To view, visit https://review.coreboot.org/c/coreboot/+/87906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0a0a04b351c9131b1238e8cc7e63e396820494d9 Gerrit-Change-Number: 87906 Gerrit-PatchSet: 1 Gerrit-Owner: NyeonWoo Kim

1 0

[XS] Change in coreboot[main]: util/crossgcc/buildgcc: Fix GMP build on GCC 15
by Elyes Haouas (Code Review) May 31, 2025

May 31, 2025

Attention is currently required from: Felix Singer, Martin L Roth, Maximilian Brune. Elyes Haouas has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/87650?usp=email ) Change subject: util/crossgcc/buildgcc: Fix GMP build on GCC 15 ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > would you give a try to this patch: […] https://review.coreboot.org/c/coreboot/+/86100/8/util/crossgcc/patches/gmp-… -- To view, visit https://review.coreboot.org/c/coreboot/+/87650?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7813ff18e8e486bece503652af69de1db93958b2 Gerrit-Change-Number: 87650 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Sat, 31 May 2025 08:37:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[M] Change in coreboot[main]: crossgcc: Upgrade GCC from 14.2.0 to 15.1.0
by Elyes Haouas (Code Review) May 31, 2025

May 31, 2025

Attention is currently required from: Elyes Haouas. Hello Felix Singer, Julius Werner, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86100?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: crossgcc: Upgrade GCC from 14.2.0 to 15.1.0 ...................................................................... crossgcc: Upgrade GCC from 14.2.0 to 15.1.0 Change-Id: I5e6c3745eebeb6ded494c153010283b761498184 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc R util/crossgcc/patches/gcc-15.1.0_asan_shadow_offset_callback.patch R util/crossgcc/patches/gcc-15.1.0_gnat.patch R util/crossgcc/patches/gcc-15.1.0_libcpp.patch R util/crossgcc/patches/gcc-15.1.0_libgcc.patch R util/crossgcc/patches/gcc-15.1.0_musl_poisoned_calloc.patch R util/crossgcc/patches/gcc-15.1.0_rv32iafc.patch M util/crossgcc/patches/gmp-6.3.0_generic-build.patch D util/crossgcc/sum/gcc-14.2.0.tar.xz.cksum A util/crossgcc/sum/gcc-15.1.0.tar.xz.cksum 10 files changed, 147 insertions(+), 40 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/86100/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/86100?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e6c3745eebeb6ded494c153010283b761498184 Gerrit-Change-Number: 86100 Gerrit-PatchSet: 8 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: util/crossgcc/buildgcc: Fix GMP build on GCC 15
by Elyes Haouas (Code Review) May 31, 2025

May 31, 2025

Attention is currently required from: Felix Singer, Martin L Roth, Maximilian Brune. Elyes Haouas has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/87650?usp=email ) Change subject: util/crossgcc/buildgcc: Fix GMP build on GCC 15 ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: would you give a try to this patch: --- configure.orj 2025-05-31 10:14:04.348051808 +0200 +++ configure 2025-05-31 10:17:47.400079682 +0200 @@ -6567,13 +6567,40 @@ 1666 to segfault with e.g., -O2 -mpowerpc64. */ #if defined (__GNUC__) && ! defined (__cplusplus) -typedef unsigned long long t1;typedef t1*t2; -void g(){} -void h(){} -static __inline__ t1 e(t2 rp,t2 up,int n,t1 v0) -{t1 c,x,r;int i;if(v0){c=1;for(i=1;i<n;i++){x=up[i];r=x+1;rp[i]=r;}}return c;} -void f(){static const struct{t1 n;t1 src[9];t1 want[9];}d[]={{1,{0},{1}},};t1 got[9];int i; -for(i=0;i<1;i++){if(e(got,got,9,d[i].n)==0)h();g(i,d[i].src,d[i].n,got,d[i].want,9);if(d[i].n)h();}} +typedef unsigned long long t1; +typedef t1 *t2; +/* signature explicite pour g afin de ne pas déclencher d'erreur sous C23 : */ +void g(int idx, t1 *src, int len, t1 *got, t1 *want, int size) { } +void h(void) { } +static __inline__ t1 e(t2 rp, t2 up, int n, t1 v0) +{ + t1 c, x, r; + int i; + if (v0) { + c = 1; + for (i = 1; i < n; i++) { + x = up[i]; + r = x + 1; + rp[i] = r; + } + } + return c; +} +void f(void) +{ + static const struct { t1 n; t1 src[9]; t1 want[9]; } d[] = { + { 1, { 0 }, { 1 } }, + }; + t1 got[9]; + int i; + for (i = 0; i < 1; i++) { + if (e(got, got, 9, d[i].n) == 0) + h(); + g(i, d[i].src, d[i].n, got, d[i].want, 9); + if (d[i].n) + h(); + } +} #else int dummy; #endif @@ -8186,13 +8213,40 @@ 1666 to segfault with e.g., -O2 -mpowerpc64. */ #if defined (__GNUC__) && ! defined (__cplusplus) -typedef unsigned long long t1;typedef t1*t2; -void g(){} -void h(){} -static __inline__ t1 e(t2 rp,t2 up,int n,t1 v0) -{t1 c,x,r;int i;if(v0){c=1;for(i=1;i<n;i++){x=up[i];r=x+1;rp[i]=r;}}return c;} -void f(){static const struct{t1 n;t1 src[9];t1 want[9];}d[]={{1,{0},{1}},};t1 got[9];int i; -for(i=0;i<1;i++){if(e(got,got,9,d[i].n)==0)h();g(i,d[i].src,d[i].n,got,d[i].want,9);if(d[i].n)h();}} +typedef unsigned long long t1; +typedef t1 *t2; +/* signature explicite pour g afin de ne pas déclencher d'erreur sous C23 : */ +void g(int idx, t1 *src, int len, t1 *got, t1 *want, int size) { } +void h(void) { } +static __inline__ t1 e(t2 rp, t2 up, int n, t1 v0) +{ + t1 c, x, r; + int i; + if (v0) { + c = 1; + for (i = 1; i < n; i++) { + x = up[i]; + r = x + 1; + rp[i] = r; + } + } + return c; +} +void f(void) +{ + static const struct { t1 n; t1 src[9]; t1 want[9]; } d[] = { + { 1, { 0 }, { 1 } }, + }; + t1 got[9]; + int i; + for (i = 0; i < 1; i++) { + if (e(got, got, 9, d[i].n) == 0) + h(); + g(i, d[i].src, d[i].n, got, d[i].want, 9); + if (d[i].n) + h(); + } +} #else int dummy; #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/87650?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7813ff18e8e486bece503652af69de1db93958b2 Gerrit-Change-Number: 87650 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Sat, 31 May 2025 08:22:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: security/vboot: Back up CMOS data later boot phase
by Subrata Banik (Code Review) May 31, 2025

May 31, 2025

Attention is currently required from: Avi Uday, Intel coreboot Reviewers, Jayvik Desai, Julius Werner, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N, Wonkyu Kim, Yu-Ping Wu. Subrata Banik has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/87738?usp=email ) Change subject: security/vboot: Back up CMOS data later boot phase ...................................................................... Patch Set 22: Code-Review+2 (1 comment) Patchset: PS22: up for a suggestion of `DELAY_SPI_ACCESS` added into src/Kconfig is the right place for Intel specific Kconfig or can be avoided from common area. Looking for a suggestion -- To view, visit https://review.coreboot.org/c/coreboot/+/87738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8836c14601beb56c614605b9840c8506d6d8536c Gerrit-Change-Number: 87738 Gerrit-PatchSet: 22 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Sat, 31 May 2025 01:46:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/byra/var/pujjo: Add VBT file for non-ChromeOS build
by Wonkyu Kim (Code Review) May 30, 2025

May 30, 2025

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Yidi Lin. Wonkyu Kim has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/87865?usp=email ) Change subject: mb/google/byra/var/pujjo: Add VBT file for non-ChromeOS build ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Please avoid adding intel vbt data into the public domain as intel mentioned in our internal sync that they considered vbt as their confidential blobs and shouldn't be part of public domain. We shouldn't get involved into releasing those into coreboot blobs from our repository. That's correct. the corncen is due to license difference between vbt(Intel Priority) and coreboot(GPL). -- To view, visit https://review.coreboot.org/c/coreboot/+/87865?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I28f8ef447b00183e4d725e29a0f9e1a1d8845c8b Gerrit-Change-Number: 87865 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 30 May 2025 22:18:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/intel/panterlake: avoid SPI access delay
by Wonkyu Kim (Code Review) May 30, 2025

May 30, 2025

Attention is currently required from: Avi Uday, Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N. Wonkyu Kim has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/87739?usp=email ) Change subject: soc/intel/panterlake: avoid SPI access delay ...................................................................... Patch Set 15: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/87739/comment/1c31cd57_21e9c741?us… : PS14, Line 12: TEST > TEST= Done -- To view, visit https://review.coreboot.org/c/coreboot/+/87739?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6b1b091dc60e6b20d39b90feebc8309306d6493e Gerrit-Change-Number: 87739 Gerrit-PatchSet: 15 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 30 May 2025 19:53:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/intel/panterlake: avoid SPI access delay
by Wonkyu Kim (Code Review) May 30, 2025

May 30, 2025

Attention is currently required from: Avi Uday, Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Wonkyu Kim. Hello Avi Uday, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/87739?usp=email to look at the new patch set (#15). Change subject: soc/intel/panterlake: avoid SPI access delay ...................................................................... soc/intel/panterlake: avoid SPI access delay Enable DELAY_SPI_ACCESS to back up CMOS data and ELOG data in the later boot phase to avoid flash access delay by another boot controller. TEST= 1. Enable DEBUG_BOOT_STATE 2. Check time BS: callback (0x7386f908) @ src/security/vboot/vbnv_cmos.c:120 (0 ms) BS: callback (0x7386d3e8) @ src/soc/intel/pantherlake/elog.c:213 (0 ms) Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com> Change-Id: I6b1b091dc60e6b20d39b90feebc8309306d6493e --- M src/soc/intel/pantherlake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/87739/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/87739?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6b1b091dc60e6b20d39b90feebc8309306d6493e Gerrit-Change-Number: 87739 Gerrit-PatchSet: 15 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[S] Change in coreboot[main]: security/vboot: Back up CMOS data later boot phase
by Wonkyu Kim (Code Review) May 30, 2025

May 30, 2025

Attention is currently required from: Avi Uday, Intel coreboot Reviewers, Jayvik Desai, Julius Werner, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N, Subrata Banik, Yu-Ping Wu. Wonkyu Kim has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/87738?usp=email ) Change subject: security/vboot: Back up CMOS data later boot phase ...................................................................... Patch Set 22: (2 comments) File src/Kconfig: https://review.coreboot.org/c/coreboot/+/87738/comment/59e59d18_c206e773?us… : PS21, Line 1575: SOCs > nit […] Done https://review.coreboot.org/c/coreboot/+/87738/comment/df3fb42c_515bc644?us… : PS21, Line 1575: lake > nit […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/87738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8836c14601beb56c614605b9840c8506d6d8536c Gerrit-Change-Number: 87738 Gerrit-PatchSet: 22 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Avi Uday <aviuday(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 30 May 2025 19:52:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0