coreboot-gerrit November 2024

coreboot-gerrit@coreboot.org

1 participants
1945 discussions

[M] Change in coreboot[main]: intelp2m/patform/lewisburg: Add unit tests
by Maximilian Brune (Code Review) 20 Nov '24

20 Nov '24

Attention is currently required from: Maxim. Maximilian Brune has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/67133?usp=email ) Change subject: intelp2m/patform/lewisburg: Add unit tests ...................................................................... Patch Set 19: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/67133?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec18462be8428c3f37d546332211a730ee589a2d Gerrit-Change-Number: 67133 Gerrit-PatchSet: 19 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Comment-Date: Wed, 20 Nov 2024 18:58:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: intelp2m/patform/apollolake: Add unit tests
by Alicja Michalska (Code Review) 20 Nov '24

20 Nov '24

Attention is currently required from: Maxim. Alicja Michalska has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/67134?usp=email ) Change subject: intelp2m/patform/apollolake: Add unit tests ...................................................................... Patch Set 20: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/67134?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1c47edb31d24930068486c74147c5fbc9b18b4b6 Gerrit-Change-Number: 67134 Gerrit-PatchSet: 20 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Comment-Date: Wed, 20 Nov 2024 18:58:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: intelp2m/patform/sunrise: Add unit tests
by Maximilian Brune (Code Review) 20 Nov '24

20 Nov '24

Attention is currently required from: Martin L Roth, Maxim, ron minnich. Maximilian Brune has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/67132?usp=email ) Change subject: intelp2m/patform/sunrise: Add unit tests ...................................................................... Patch Set 19: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/67132?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I15c7483f120a330849d4bad036427be205b0911c Gerrit-Change-Number: 67132 Gerrit-PatchSet: 19 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Maxim Polyakov <m.poliakov(a)yahoo.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 20 Nov 2024 18:58:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: intelp2m/patform/lewisburg: Add unit tests
by David Hendricks (Code Review) 20 Nov '24

20 Nov '24

Attention is currently required from: Maxim. David Hendricks has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/67133?usp=email ) Change subject: intelp2m/patform/lewisburg: Add unit tests ...................................................................... Patch Set 19: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67133?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec18462be8428c3f37d546332211a730ee589a2d Gerrit-Change-Number: 67133 Gerrit-PatchSet: 19 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Comment-Date: Wed, 20 Nov 2024 18:58:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: intelp2m/patform/lewisburg: Add unit tests
by Alicja Michalska (Code Review) 20 Nov '24

20 Nov '24

Attention is currently required from: Maxim. Alicja Michalska has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/67133?usp=email ) Change subject: intelp2m/patform/lewisburg: Add unit tests ...................................................................... Patch Set 19: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/67133?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec18462be8428c3f37d546332211a730ee589a2d Gerrit-Change-Number: 67133 Gerrit-PatchSet: 19 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Comment-Date: Wed, 20 Nov 2024 18:57:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: intelp2m/patform/sunrise: Add unit tests
by David Hendricks (Code Review) 20 Nov '24

20 Nov '24

Attention is currently required from: Martin L Roth, Maxim, ron minnich. David Hendricks has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/67132?usp=email ) Change subject: intelp2m/patform/sunrise: Add unit tests ...................................................................... Patch Set 19: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67132?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I15c7483f120a330849d4bad036427be205b0911c Gerrit-Change-Number: 67132 Gerrit-PatchSet: 19 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Maxim Polyakov <m.poliakov(a)yahoo.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 20 Nov 2024 18:57:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: intelp2m/patform/sunrise: Add unit tests
by Alicja Michalska (Code Review) 20 Nov '24

20 Nov '24

Attention is currently required from: David Hendricks, Martin L Roth, Maxim, ron minnich. Alicja Michalska has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/67132?usp=email ) Change subject: intelp2m/patform/sunrise: Add unit tests ...................................................................... Patch Set 19: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/67132?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I15c7483f120a330849d4bad036427be205b0911c Gerrit-Change-Number: 67132 Gerrit-PatchSet: 19 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Maxim Polyakov <m.poliakov(a)yahoo.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 20 Nov 2024 18:56:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: drivers/pc80/pc/i8254.c: Initialize timer 1 in mode 2
by Alicja Michalska (Code Review) 20 Nov '24

20 Nov '24

Attention is currently required from: Petr Cvek. Alicja Michalska has posted comments on this change by Petr Cvek. ( https://review.coreboot.org/c/coreboot/+/65809?usp=email ) Change subject: drivers/pc80/pc/i8254.c: Initialize timer 1 in mode 2 ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: Would you like to have this patch merged? Looks good to me, but needs a rebase. -- To view, visit https://review.coreboot.org/c/coreboot/+/65809?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5fa969a5432d626aba298a2e020ec19f8da25d59 Gerrit-Change-Number: 65809 Gerrit-PatchSet: 4 Gerrit-Owner: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Comment-Date: Wed, 20 Nov 2024 18:49:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: util/lint/lint-000-license-headers: Add license
by Alicja Michalska (Code Review) 20 Nov '24

20 Nov '24

Attention is currently required from: Julius Werner, Martin L Roth, Maximilian Brune. Alicja Michalska has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84584?usp=email ) Change subject: util/lint/lint-000-license-headers: Add license ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/84584?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I07c508aa6134b063801de36199af9a312a7d6bed Gerrit-Change-Number: 84584 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 20 Nov 2024 18:23:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: util/riscv: Add starfive Image building tool
by Alicja Michalska (Code Review) 20 Nov '24

20 Nov '24

Attention is currently required from: Julius Werner, Martin L Roth, Maximilian Brune, Philipp Hug, ron minnich. Alicja Michalska has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83849?usp=email ) Change subject: util/riscv: Add starfive Image building tool ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: +1, but: 1. Please clarify why you klept coding style for spi_tool.c in-line with upstream 2. Please remove the exec permissions from lint files -- To view, visit https://review.coreboot.org/c/coreboot/+/83849?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iab16c1e1f15f24e85c0ef1a3e838d024e1e49286 Gerrit-Change-Number: 83849 Gerrit-PatchSet: 4 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 20 Nov 2024 18:21:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2024