coreboot-gerrit November 2024

coreboot-gerrit@coreboot.org

1 participants
1942 discussions

[XS] Change in coreboot[main]: tree: Remove unused <bootstate.h>
by Eric Lai (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Dinesh Gehlot, Elyes Haouas, Eran Mitrani, Felix Held, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Martin L Roth, Nick Vaccaro, Pranava Y N, Subrata Banik, Tarun, Varshit Pandya, Werner Zeh. Eric Lai has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/85216?usp=email ) Change subject: tree: Remove unused <bootstate.h> ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85216?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic27acf9f8dfbbccb8f48a139032b1463e7185030 Gerrit-Change-Number: 85216 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 01:17:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/telith: Add 6W and 15W power limit parameters
by Eric Lai (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Rui Zhou. Eric Lai has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/85209?usp=email ) Change subject: mb/google/nissa/var/telith: Add 6W and 15W power limit parameters ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Gerrit shows no diff. I can see the diff. -1 +6 -- To view, visit https://review.coreboot.org/c/coreboot/+/85209?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I069869fa01dc157cf2544e72468f43ce1bb64035 Gerrit-Change-Number: 85209 Gerrit-PatchSet: 1 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lei Cao <caolei6(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 21 Nov 2024 01:16:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/telith: Add 6W and 15W power limit parameters
by Eric Lai (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rui Zhou. Eric Lai has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/85209?usp=email ) Change subject: mb/google/nissa/var/telith: Add 6W and 15W power limit parameters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85209?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I069869fa01dc157cf2544e72468f43ce1bb64035 Gerrit-Change-Number: 85209 Gerrit-PatchSet: 1 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lei Cao <caolei6(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 21 Nov 2024 01:16:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in coreboot[main]: mb/lenovo: Add Thinkcentre M900 (Skylake/LGA 1151)
by Felix Singer (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Alexander Couzens, Nicholas Chin, Paul Menzel. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/74187?usp=email ) Change subject: mb/lenovo: Add Thinkcentre M900 (Skylake/LGA 1151) ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Any progress here? -- To view, visit https://review.coreboot.org/c/coreboot/+/74187?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4e70c9f42c19f130a00170b32ae74b61f0483a22 Gerrit-Change-Number: 74187 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 21 Nov 2024 00:58:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Refactor EC_SOC_INT_ODL GPP for fatcat_ish variant
by Jayvik Desai (Code Review) 21 Nov '24

21 Nov '24

Jayvik Desai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85223?usp=email ) Change subject: mb/google/fatcat: Refactor EC_SOC_INT_ODL GPP for fatcat_ish variant ...................................................................... mb/google/fatcat: Refactor EC_SOC_INT_ODL GPP for fatcat_ish variant This patch refactors the configuration of GPP_E07 (EC_SOC_INT_ODL) to accommodate the fatcat_ish variant The GPP_E07 is not connected on google/fatcat variants using the Microchip EC AIC. BUG=b:370984186 TEST=Able to build fatcat/fatcat_ish w/o any error. Change-Id: I88bd76b2110b4c0742569f1ccb2030ea516b3782 Signed-off-by: Jayvik Desai <jayvik(a)google.com> --- M src/mainboard/google/fatcat/variants/fatcat/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/85223/1 diff --git a/src/mainboard/google/fatcat/variants/fatcat/gpio.c b/src/mainboard/google/fatcat/variants/fatcat/gpio.c index 14d38a9..45cede6 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/gpio.c +++ b/src/mainboard/google/fatcat/variants/fatcat/gpio.c @@ -210,7 +210,7 @@ PAD_CFG_GPO(GPP_E03, 1, PLTRST), /* GPP_E06: SECURE_CAM_SW */ PAD_CFG_GPI_TRIG_OWN(GPP_E06, NONE, PLTRST, LEVEL, ACPI), -#if CONFIG(BOARD_GOOGLE_FATCAT) +#if CONFIG(BOARD_GOOGLE_FATCAT) || CONFIG(BOARD_GOOGLE_FATCATISH) /* GPP_E07: Not used */ PAD_NC(GPP_E07, NONE), #else -- To view, visit https://review.coreboot.org/c/coreboot/+/85223?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I88bd76b2110b4c0742569f1ccb2030ea516b3782 Gerrit-Change-Number: 85223 Gerrit-PatchSet: 1 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Add EC_SYNC_IRQ and GPIO_PCH_WP for fatcat_ish variant
by Jayvik Desai (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Pranava Y N, Subrata Banik. Hello Pranava Y N, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85222?usp=email to look at the new patch set (#2). Change subject: mb/google/fatcat: Add EC_SYNC_IRQ and GPIO_PCH_WP for fatcat_ish variant ...................................................................... mb/google/fatcat: Add EC_SYNC_IRQ and GPIO_PCH_WP for fatcat_ish variant This commit adds the EC_SYNC_IRQ and GPIO_PCH_WP macros for the fatcat_ish variant. BUG=b:370984186 TEST=able to build fatcat/fatcat_ish w/o any error. Change-Id: I977e72a6db99b40a79d37a1b8fe5bee5d98934c7 Signed-off-by: Jayvik Desai <jayvik(a)google.com> --- M src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/ec.h M src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/gpio.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/85222/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85222?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I977e72a6db99b40a79d37a1b8fe5bee5d98934c7 Gerrit-Change-Number: 85222 Gerrit-PatchSet: 2 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Add EC_SYNC_IRQ and GPIO_PCH_WP for fatcat_ish variant
by Jayvik Desai (Code Review) 21 Nov '24

21 Nov '24

Jayvik Desai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85222?usp=email ) Change subject: mb/google/fatcat: Add EC_SYNC_IRQ and GPIO_PCH_WP for fatcat_ish variant ...................................................................... mb/google/fatcat: Add EC_SYNC_IRQ and GPIO_PCH_WP for fatcat_ish variant This commit adds the EC_SYNC_IRQ and GPIO_PCH_WP macros for the fatcat_ish variant. BUG=b:370984186 TEST=able to build fatcat/fatcat_ish w/o any error. Change-Id: I977e72a6db99b40a79d37a1b8fe5bee5d98934c7 Signed-off-by: Jayvik Desai <jayvik(a)google.com> --- M src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/ec.h M src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/gpio.h 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/85222/1 diff --git a/src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/ec.h b/src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/ec.h index c354e8b..ae1eaa8 100644 --- a/src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/ec.h +++ b/src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/ec.h @@ -75,11 +75,12 @@ /* Enable EC backed PD MCU device in ACPI */ #define EC_ENABLE_PD_MCU_DEVICE -#if !CONFIG(BOARD_GOOGLE_FATCAT) +#if !CONFIG(BOARD_GOOGLE_FATCAT) || !CONFIG(BOARD_GOOGLE_FATCATISH) #define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */ #define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ #endif + #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ diff --git a/src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/gpio.h b/src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/gpio.h index 10c30e3..47b0e3d 100644 --- a/src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/gpio.h +++ b/src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/gpio.h @@ -15,7 +15,7 @@ #if CONFIG(BOARD_GOOGLE_FATCATNUVO) || CONFIG(BOARD_GOOGLE_FATCATITE) #define EC_SYNC_IRQ GPP_E07_IRQ #define GPIO_PCH_WP GPP_D02 -#elif CONFIG(BOARD_GOOGLE_FATCAT) +#elif CONFIG(BOARD_GOOGLE_FATCAT) || CONFIG(BOARD_GOOGLE_FATCATISH) #define EC_SYNC_IRQ 0 /* Not Connected */ #define GPIO_PCH_WP GPP_D02 #elif CONFIG(BOARD_GOOGLE_FRANCKA) -- To view, visit https://review.coreboot.org/c/coreboot/+/85222?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I977e72a6db99b40a79d37a1b8fe5bee5d98934c7 Gerrit-Change-Number: 85222 Gerrit-PatchSet: 1 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Adjust EC host command range for fatcat_ish variant
by Jayvik Desai (Code Review) 21 Nov '24

21 Nov '24

Jayvik Desai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85221?usp=email ) Change subject: mb/google/fatcat: Adjust EC host command range for fatcat_ish variant ...................................................................... mb/google/fatcat: Adjust EC host command range for fatcat_ish variant This commit adjusts the EC host command range for the fatcat_ish variant to 0x800-0x807 & 0x200-0x20f. BUG=b:370984186 TEST=Able to build fatcat/fatcat_ish w/o any error. Change-Id: I0d726d60d2a15d2dfaff35f570de479fdc6d15aa Signed-off-by: Jayvik Desai <jayvik(a)google.com> --- M src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/85221/1 diff --git a/src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb b/src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb index a81f35e..c4e2276 100644 --- a/src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb +++ b/src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb @@ -4,11 +4,11 @@ register "pmc_gpe0_dw1" = "GPP_D" register "pmc_gpe0_dw2" = "GPP_E" - # For Fatcat (with microchip EC): + # For Fatcat variants with microchip EC: # EC host command ranges are in 0x800-0x807 & 0x200-0x20f - # For other Fatcat variants (with ITE/Nuvoton EC): + # For Fatcat variants with ITE/Nuvoton EC: # EC host command ranges are in 0x800-0x8ff & 0x200-0x20f - register "gen1_dec" = "CONFIG(BOARD_GOOGLE_FATCAT) ? 0x00040801 : 0x00fc0801" + register "gen1_dec" = "CONFIG(BOARD_GOOGLE_FATCAT) || CONFIG(BOARD_GOOGLE_FATCATISH) ? 0x00040801 : 0x00fc0801" register "gen2_dec" = "0x000c0201" # EC memory map range is 0x900-0x9ff register "gen3_dec" = "0x00fc0901" -- To view, visit https://review.coreboot.org/c/coreboot/+/85221?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0d726d60d2a15d2dfaff35f570de479fdc6d15aa Gerrit-Change-Number: 85221 Gerrit-PatchSet: 1 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Add fatcat_ish variant
by Jayvik Desai (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Pranava Y N, Subrata Banik. Hello Pranava Y N, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85220?usp=email to look at the new patch set (#2). Change subject: mb/google/fatcat: Add fatcat_ish variant ...................................................................... mb/google/fatcat: Add fatcat_ish variant This patch adds the "fatcat_ish" board to the fatcat Kconfig. BUG=b:370984186 TEST=Able to build fatcat/fatcat_ish and verify the correct configs selected in coreboot.config Change-Id: I8a49ce54e946dfdfad253ff946da1b37ed50dd0a Signed-off-by: Jayvik Desai <jayvik(a)google.com> --- M src/mainboard/google/fatcat/Kconfig M src/mainboard/google/fatcat/Kconfig.name 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/85220/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85220?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8a49ce54e946dfdfad253ff946da1b37ed50dd0a Gerrit-Change-Number: 85220 Gerrit-PatchSet: 2 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Add fatcat_ish variant
by Jayvik Desai (Code Review) 20 Nov '24

20 Nov '24

Jayvik Desai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85220?usp=email ) Change subject: mb/google/fatcat: Add fatcat_ish variant ...................................................................... mb/google/fatcat: Add fatcat_ish variant This patch adds the "fatcat_ish" board to the fatcat Kconfig. BUG=b:370984186 TEST=Able to build fatcat/fatcat_ish and verift the correct configs selected in coreboot.config Change-Id: I8a49ce54e946dfdfad253ff946da1b37ed50dd0a Signed-off-by: Jayvik Desai <jayvik(a)google.com> --- M src/mainboard/google/fatcat/Kconfig M src/mainboard/google/fatcat/Kconfig.name 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/85220/1 diff --git a/src/mainboard/google/fatcat/Kconfig b/src/mainboard/google/fatcat/Kconfig index 1851cde..04afc8b 100644 --- a/src/mainboard/google/fatcat/Kconfig +++ b/src/mainboard/google/fatcat/Kconfig @@ -62,6 +62,11 @@ select EC_GOOGLE_CHROMEEC_MEC select MAINBOARD_USES_IFD_EC_REGION +config BOARD_GOOGLE_FATCATISH + select BOARD_GOOGLE_MODEL_FATCAT + select EC_GOOGLE_CHROMEEC_MEC + select MAINBOARD_USES_IFD_EC_REGION + config BOARD_GOOGLE_FATCATNUVO select BOARD_GOOGLE_MODEL_FATCAT @@ -126,6 +131,7 @@ config MAINBOARD_PART_NUMBER default "Fatcat" if BOARD_GOOGLE_FATCAT + default "Fatcat_ish" if BOARD_GOOGLE_FATCATISH default "Fatcatite" if BOARD_GOOGLE_FATCATITE default "Fatcatnuvo" if BOARD_GOOGLE_FATCATNUVO default "Francka" if BOARD_GOOGLE_FRANCKA diff --git a/src/mainboard/google/fatcat/Kconfig.name b/src/mainboard/google/fatcat/Kconfig.name index a8bf826..7c6cb89 100644 --- a/src/mainboard/google/fatcat/Kconfig.name +++ b/src/mainboard/google/fatcat/Kconfig.name @@ -5,6 +5,9 @@ config BOARD_GOOGLE_FATCAT bool "-> Fatcat" +config BOARD_GOOGLE_FATCATISH + bool "-> Fatcat_ish" + config BOARD_GOOGLE_FATCATITE bool "-> Fatcatite" -- To view, visit https://review.coreboot.org/c/coreboot/+/85220?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8a49ce54e946dfdfad253ff946da1b37ed50dd0a Gerrit-Change-Number: 85220 Gerrit-PatchSet: 1 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2024