Attention is currently required from: Jayvik Desai, Pranava Y N, Subrata Banik.
Kapil Porwal has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85222?usp=email )
Change subject: mb/google/fatcat: Add EC_SYNC_IRQ and GPIO_PCH_WP for fatcat_ish variant
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/85222/comment/17934eee_e0509b5c?us… :
PS2, Line 78: #if !CONFIG(BOARD_GOOGLE_FATCAT) || !CONFIG(BOARD_GOOGLE_FATCATISH)
> or simply use CONFIG(BOARD_GOOGLE_FATCATNUVO) || CONFIG(BOARD_GOOGLE_FATCATITE)
+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/85222?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I977e72a6db99b40a79d37a1b8fe5bee5d98934c7
Gerrit-Change-Number: 85222
Gerrit-PatchSet: 2
Gerrit-Owner: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 08:30:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pranava Y N <pranavayn(a)google.com>
Attention is currently required from: Julius Werner, Martin L Roth.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84584?usp=email )
Change subject: util/lint/lint-000-license-headers: Add license
......................................................................
Patch Set 2:
(1 comment)
File util/lint/lint-000-license-headers:
https://review.coreboot.org/c/coreboot/+/84584/comment/bfc56700_de86adc6?us… :
PS1, Line 92: headerlist="$(grep -iL "${LICENSE_ID_STRING}: $1" $headerlist 2>/dev/null)"
> I was thinking about it, but it seemed easier (less complicated to test) to just add it for now and […]
Acknowledged
--
To view, visit https://review.coreboot.org/c/coreboot/+/84584?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07c508aa6134b063801de36199af9a312a7d6bed
Gerrit-Change-Number: 84584
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 21 Nov 2024 06:29:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Attention is currently required from: Jayvik Desai, Subrata Banik.
Pranava Y N has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85223?usp=email )
Change subject: mb/google/fatcat: Refactor EC_SOC_INT_ODL GPP for fatcat_ish variant
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85223?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I88bd76b2110b4c0742569f1ccb2030ea516b3782
Gerrit-Change-Number: 85223
Gerrit-PatchSet: 1
Gerrit-Owner: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 05:44:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Jayvik Desai, Subrata Banik.
Pranava Y N has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85222?usp=email )
Change subject: mb/google/fatcat: Add EC_SYNC_IRQ and GPIO_PCH_WP for fatcat_ish variant
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/85222/comment/1bb1ea08_24ffe6ae?us… :
PS2, Line 78: #if !CONFIG(BOARD_GOOGLE_FATCAT) || !CONFIG(BOARD_GOOGLE_FATCATISH)
> Shouldn't this be !(CONFIG(BOARD_GOOGLE_FATCAT) || CONFIG(BOARD_GOOGLE_FATCATISH))
or simply use CONFIG(BOARD_GOOGLE_FATCATNUVO) || CONFIG(BOARD_GOOGLE_FATCATITE)
--
To view, visit https://review.coreboot.org/c/coreboot/+/85222?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I977e72a6db99b40a79d37a1b8fe5bee5d98934c7
Gerrit-Change-Number: 85222
Gerrit-PatchSet: 2
Gerrit-Owner: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 05:44:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pranava Y N <pranavayn(a)google.com>