coreboot-gerrit November 2024

coreboot-gerrit@coreboot.org

1 participants
1941 discussions

[XS] Change in coreboot[main]: ec/acpi/ec.c: Promote timeout messages to errors
by Nicholas Sudsgaard (Code Review) 21 Nov '24

21 Nov '24

Nicholas Sudsgaard has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85229?usp=email ) Change subject: ec/acpi/ec.c: Promote timeout messages to errors ...................................................................... ec/acpi/ec.c: Promote timeout messages to errors A timeout when attempting to read/write to an EC should be treated as an error, as it could potentially cause unwanted or unexpected behavior from the device. Change-Id: I60be6191dcd8ff576fa525f08720b6ea2d0a7454 Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> --- M src/ec/acpi/ec.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/85229/1 diff --git a/src/ec/acpi/ec.c b/src/ec/acpi/ec.c index dddfb6b..4378b02 100644 --- a/src/ec/acpi/ec.c +++ b/src/ec/acpi/ec.c @@ -45,7 +45,7 @@ int send_ec_command_timeout(u8 command, int timeout_us) { if (!ec_ready_send(timeout_us)) { - printk(BIOS_DEBUG, "Timeout while sending command 0x%02x to EC!\n", + printk(BIOS_ERR, "Timeout while sending command 0x%02x to EC!\n", command); return -1; } @@ -63,7 +63,7 @@ int send_ec_data_timeout(u8 data, int timeout_us) { if (!ec_ready_send(timeout_us)) { - printk(BIOS_DEBUG, "Timeout while sending data 0x%02x to EC!\n", + printk(BIOS_ERR, "Timeout while sending data 0x%02x to EC!\n", data); return -1; } @@ -83,7 +83,7 @@ u8 data; if (!ec_ready_recv(timeout_us)) { - printk(BIOS_DEBUG, "Timeout while receiving data from EC!\n"); + printk(BIOS_ERR, "Timeout while receiving data from EC!\n"); return -1; } -- To view, visit https://review.coreboot.org/c/coreboot/+/85229?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I60be6191dcd8ff576fa525f08720b6ea2d0a7454 Gerrit-Change-Number: 85229 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Adjust EC host command range for fatcat_ish variant
by Paul Menzel (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Jayvik Desai, Subrata Banik. Paul Menzel has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85221?usp=email ) Change subject: mb/google/fatcat: Adjust EC host command range for fatcat_ish variant ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85221/comment/726f9956_0083cd1a?us… : PS1, Line 7: for fatcat_ish variant Make this part of the prefix? https://review.coreboot.org/c/coreboot/+/85221/comment/72a5e308_b62af714?us… : PS1, Line 9: This commit adjusts the EC host command range for the fatcat_ish variant “This commit” is redundant. Maybe just imperative mood: Adjust … https://review.coreboot.org/c/coreboot/+/85221/comment/f4f016b7_1f591713?us… : PS1, Line 9: This commit adjusts the EC host command range for the fatcat_ish variant : to 0x800-0x807 & 0x200-0x20f. According to what source? -- To view, visit https://review.coreboot.org/c/coreboot/+/85221?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0d726d60d2a15d2dfaff35f570de479fdc6d15aa Gerrit-Change-Number: 85221 Gerrit-PatchSet: 1 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Thu, 21 Nov 2024 09:42:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/intel/xeon_sp: Fix SRAT debug prints
by Paul Menzel (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Patrick Rudolph. Paul Menzel has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85189?usp=email ) Change subject: soc/intel/xeon_sp: Fix SRAT debug prints ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85189/comment/84ca6bd9_ee50eb02?us… : PS2, Line 13: Paste a log line before and after? -- To view, visit https://review.coreboot.org/c/coreboot/+/85189?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I379aeb6fcd2e28665c7d592b0639db3c1b4caa9b Gerrit-Change-Number: 85189 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: yuchi.chen(a)intel.com Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Thu, 21 Nov 2024 09:41:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/brya/var/trulo: Update PL1 values as per silicon TDP
by Paul Menzel (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, V Sowmya, Vidya Gopalakrishnan, Vinay Kumar. Paul Menzel has posted comments on this change by Vidya Gopalakrishnan. ( https://review.coreboot.org/c/coreboot/+/85184?usp=email ) Change subject: mb/google/brya/var/trulo: Update PL1 values as per silicon TDP ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85184/comment/1194ba2e_92806a57?us… : PS4, Line 7: Update Decrease https://review.coreboot.org/c/coreboot/+/85184/comment/4cf407d7_6844c3b5?us… : PS4, Line 9: Update the RAPL PL1 limit and MMIO PL1 max values as per silicon TDP. Please mention the values. https://review.coreboot.org/c/coreboot/+/85184/comment/ce6c5d73_047fb7ea?us… : PS4, Line 13: Verified PL1 value is updated in DTT and sysfs interfaces. Please paste the commands and the output. -- To view, visit https://review.coreboot.org/c/coreboot/+/85184?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I798c4f10e10a579f470e00dbdb77a84619ad796a Gerrit-Change-Number: 85184 Gerrit-PatchSet: 4 Gerrit-Owner: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Vinay Kumar <vinay.kumar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Vinay Kumar <vinay.kumar(a)intel.com> Gerrit-Comment-Date: Thu, 21 Nov 2024 09:40:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: arch/x86: Enable support for IOAPIC devices
by Shuo Liu (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Cliff Huang, Jérémy Compostella, Lance Zhao, Patrick Rudolph, Subrata Banik, Tim Wawrzynczak, yuchi.chen(a)intel.com. Shuo Liu has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85226?usp=email ) Change subject: arch/x86: Enable support for IOAPIC devices ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Seems this patch should be ahead of https://review.coreboot.org/c/coreboot/+/85170? -- To view, visit https://review.coreboot.org/c/coreboot/+/85226?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie13d4f5c4f0704f0935974f90e5b7cf24e94aab3 Gerrit-Change-Number: 85226 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: yuchi.chen(a)intel.com Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: yuchi.chen(a)intel.com Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Thu, 21 Nov 2024 09:38:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp/skx: Configure IOAPICs
by Shuo Liu (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Alicja Michalska, Christian Walter, Eric Lai, Felix Held, Johnny Lin, Jonathan Zhang, Patrick Rudolph, Tim Chu, yuchi.chen(a)intel.com. Shuo Liu has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85170?usp=email ) Change subject: soc/intel/xeon_sp/skx: Configure IOAPICs ...................................................................... Patch Set 4: (3 comments) File src/soc/intel/xeon_sp/skx/ioapic.c: https://review.coreboot.org/c/coreboot/+/85170/comment/8d1e95d1_dd78dee9?us… : PS4, Line 47: } So each IIO IOAPIC with 8 GSIs, and the dn.stack <=5, right? https://review.coreboot.org/c/coreboot/+/85170/comment/b663cbfd_e2dcea0d?us… : PS4, Line 49: i Is this defined in somewhere? https://review.coreboot.org/c/coreboot/+/85170/comment/490fb931_459200d7?us… : PS4, Line 61: .enable_resources = pci_dev_enable_resources, Should we use pci_bus_enable_resources? -- To view, visit https://review.coreboot.org/c/coreboot/+/85170?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3bd69e6293b1994a4b3a49361fa7eb45cc0a3a5f Gerrit-Change-Number: 85170 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: yuchi.chen(a)intel.com Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: yuchi.chen(a)intel.com Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Thu, 21 Nov 2024 09:31:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: drivers/crb: Return an accurate status
by Sean Rhodes (Code Review) 21 Nov '24

21 Nov '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85228?usp=email ) Change subject: drivers/crb: Return an accurate status ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85228?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If8236021bf0e1264646971cff9c998fac99ac220 Gerrit-Change-Number: 85228 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 21 Nov 2024 09:29:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: arch/x86: Enable support for IOAPIC devices
by Lean Sheng Tan (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Cliff Huang, Jérémy Compostella, Lance Zhao, Patrick Rudolph, Tim Wawrzynczak. Lean Sheng Tan has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85226?usp=email ) Change subject: arch/x86: Enable support for IOAPIC devices ...................................................................... Patch Set 1: (1 comment) File src/arch/x86/ioapic.c: https://review.coreboot.org/c/coreboot/+/85226/comment/88aae7a0_aa4d906a?us… : PS1, Line 237: } > `adding a line without newline at end of file` Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/85226?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie13d4f5c4f0704f0935974f90e5b7cf24e94aab3 Gerrit-Change-Number: 85226 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Thu, 21 Nov 2024 09:28:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/brya/var/trulo: Update PL1 values as per silicon TDP
by Vidya Gopalakrishnan (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik, V Sowmya, Vinay Kumar. Vidya Gopalakrishnan has posted comments on this change by Vidya Gopalakrishnan. ( https://review.coreboot.org/c/coreboot/+/85184?usp=email ) Change subject: mb/google/brya/var/trulo: Update PL1 values as per silicon TDP ...................................................................... Patch Set 4: (3 comments) Patchset: PS4: All comments incorporated Commit Message: https://review.coreboot.org/c/coreboot/+/85184/comment/7bc2250e_8ba2ce9b?us… : PS3, Line 7: Update PL1 and enable Charger device > Please make it two commits. Done. Keeping current CL for PL1 update. Moved Charger enablement to CL 85227 https://review.coreboot.org/c/coreboot/+/85184/comment/a84919c8_87727fa6?us… : PS3, Line 13: TEST=Build and boot on Trulo board. Verified PL1 value is updated in DTT and sysfs interfaces. Also verified the source for TSR1 is updated to Charger in Passive Policy > Please re-flow for 72 characters per line. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85184?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I798c4f10e10a579f470e00dbdb77a84619ad796a Gerrit-Change-Number: 85184 Gerrit-PatchSet: 4 Gerrit-Owner: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Vinay Kumar <vinay.kumar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Vinay Kumar <vinay.kumar(a)intel.com> Gerrit-Comment-Date: Thu, 21 Nov 2024 09:26:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: nb/via/cx700: Scan PCI bus and probe resources
by Angel Pons (Code Review) 21 Nov '24

21 Nov '24

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83389?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: nb/via/cx700: Scan PCI bus and probe resources ...................................................................... nb/via/cx700: Scan PCI bus and probe resources Change-Id: I1268a8f886ff395ff822b14a5427a5031260c541 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83389 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/northbridge/via/cx700/Makefile.mk M src/northbridge/via/cx700/chipset.cb A src/northbridge/via/cx700/northbridge.c 3 files changed, 11 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/northbridge/via/cx700/Makefile.mk b/src/northbridge/via/cx700/Makefile.mk index 3b9608c..80fc6b9 100644 --- a/src/northbridge/via/cx700/Makefile.mk +++ b/src/northbridge/via/cx700/Makefile.mk @@ -7,7 +7,7 @@ bootblock-y += early_smbus.c bootblock.c romstage-y += early_smbus.c memmap.c romstage.c raminit.c -ramstage-y += memmap.c chip.c +ramstage-y += memmap.c chip.c northbridge.c all-y += clock.c reset.c endif diff --git a/src/northbridge/via/cx700/chipset.cb b/src/northbridge/via/cx700/chipset.cb index 25c2f11..74fbcd7 100644 --- a/src/northbridge/via/cx700/chipset.cb +++ b/src/northbridge/via/cx700/chipset.cb @@ -1,6 +1,7 @@ chip northbridge/via/cx700 device domain 0 on + ops domain_ops device pci 00.0 alias host_ctrl on end device pci 00.1 alias host_err on end diff --git a/src/northbridge/via/cx700/northbridge.c b/src/northbridge/via/cx700/northbridge.c new file mode 100644 index 0000000..d68e765 --- /dev/null +++ b/src/northbridge/via/cx700/northbridge.c @@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <device/device.h> + +struct device_operations domain_ops = { + .read_resources = pci_domain_read_resources, + .set_resources = pci_domain_set_resources, + .scan_bus = pci_host_bridge_scan_bus, +}; -- To view, visit https://review.coreboot.org/c/coreboot/+/83389?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1268a8f886ff395ff822b14a5427a5031260c541 Gerrit-Change-Number: 83389 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2024