coreboot-gerrit October 2024

coreboot-gerrit@coreboot.org

1 participants
2622 discussions

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Remove settings to replicate OEM
by Keith Hui (Code Review) 28 Oct '24

28 Oct '24

Attention is currently required from: Fabian Groffen, Keith Hui, Paul Menzel. Keith Hui has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/coreboot/+/75137?usp=email ) Change subject: mb/asus/p8z77-m: Remove settings to replicate OEM ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75137/comment/06eba550_ef6d701e?us… : PS6, Line 9: Per Fabian: : : With these settings enabled COM 1/UART A/serial port 1 gets blocked : right after the kernel boots. It no longer works or responds, which : actually means the Linux boot process gets stuck forever when configured : to write to ttyS0. : : Not using these settings, I have not found any downside. Serial keeps : working, sensors still work, S3 suspend/resume works correctly. : : --- : : Out of the six settings in this group, three are causing the initial : issue, the rest are confirmed necessary to be replicated, with PECI : as the reason for one of them. Keith revised this patch to reflect : this. > I’d prefer one coherent message. […] In short, the first 3 global settings (0x26, 0x13, 0x14) that Fabian tried to revert are causing his troubles, and I agree with him that those should go. The remaining global settings I replicated from vendor FW are necessary and have to remain. I would love a suggestion on how to improve the messaging, without appearing as if I completely appropriated Fabian's work, as he deserves at least some credit. -- To view, visit https://review.coreboot.org/c/coreboot/+/75137?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae526762e79e9e2d46d06e12c338f375e5555e8c Gerrit-Change-Number: 75137 Gerrit-PatchSet: 6 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Comment-Date: Mon, 28 Oct 2024 19:14:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Remove settings to replicate OEM
by Paul Menzel (Code Review) 28 Oct '24

28 Oct '24

Attention is currently required from: Fabian Groffen, Keith Hui, Keith Hui. Paul Menzel has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/coreboot/+/75137?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/asus/p8z77-m: Remove settings to replicate OEM ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75137/comment/fdf5828d_4aafff1e?us… : PS6, Line 9: Per Fabian: : : With these settings enabled COM 1/UART A/serial port 1 gets blocked : right after the kernel boots. It no longer works or responds, which : actually means the Linux boot process gets stuck forever when configured : to write to ttyS0. : : Not using these settings, I have not found any downside. Serial keeps : working, sensors still work, S3 suspend/resume works correctly. : : --- : : Out of the six settings in this group, three are causing the initial : issue, the rest are confirmed necessary to be replicated, with PECI : as the reason for one of them. Keith revised this patch to reflect : this. I’d prefer one coherent message. But I’d also be content with a clear statement in the commit message, what is now replicated the vendor firmware, and what is not. -- To view, visit https://review.coreboot.org/c/coreboot/+/75137?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae526762e79e9e2d46d06e12c338f375e5555e8c Gerrit-Change-Number: 75137 Gerrit-PatchSet: 6 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Comment-Date: Mon, 28 Oct 2024 19:04:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: Documentation: Add information about the deguard utility
by Paul Menzel (Code Review) 28 Oct '24

28 Oct '24

Attention is currently required from: Máté Kukri. Paul Menzel has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/84825?usp=email ) Change subject: Documentation: Add information about the deguard utility ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84825/comment/77fcc47e_e407a222?us… : PS2, Line 10: The Signed-off-by line is missing. -- To view, visit https://review.coreboot.org/c/coreboot/+/84825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idba0f461d31db31cbc9c35ee3da70c116d5493ce Gerrit-Change-Number: 84825 Gerrit-PatchSet: 2 Gerrit-Owner: Máté Kukri <km(a)mkukri.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Máté Kukri <km(a)mkukri.xyz> Gerrit-Comment-Date: Mon, 28 Oct 2024 18:58:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Update SAF base address
by Subrata Banik (Code Review) 28 Oct '24

28 Oct '24

Attention is currently required from: Anil Kumar K, Kapil Porwal, Pranava Y N. Subrata Banik has posted comments on this change by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/84863?usp=email ) Change subject: soc/intel/pantherlake: Update SAF base address ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/pantherlake/include/soc/iomap.h: https://review.coreboot.org/c/coreboot/+/84863/comment/76092b76_8d60c83b?us… : PS2, Line 19: SAF_BASE_ADDRESS what is the source here ? please let me know for my verification FAS says ```Same BAR as on LNL and it is programmed by BIOS.``` Take a look into 6.2 section of the same doc `P2SB BARs and SAFBAR will be moved to above 4GB` SAF BAR - 0x3F_FE00_0000 to 0x3F_FFFF_FFFF Size - 32MB -- To view, visit https://review.coreboot.org/c/coreboot/+/84863?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I14fa8cf06144f46369cc8cab6087c790280e9859 Gerrit-Change-Number: 84863 Gerrit-PatchSet: 2 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Mon, 28 Oct 2024 17:53:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/system76: Enable S0ix support but prefer S3
by Tim Crawford (Code Review) 28 Oct '24

28 Oct '24

Tim Crawford has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/79632?usp=email ) Change subject: mb/system76: Enable S0ix support but prefer S3 ...................................................................... Abandoned Don't care -- To view, visit https://review.coreboot.org/c/coreboot/+/79632?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idc881d30009e3ef170e5430596652548aa434fda Gerrit-Change-Number: 79632 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: soc/intel: Add config to use S3 over S0ix
by Tim Crawford (Code Review) 28 Oct '24

28 Oct '24

Tim Crawford has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/79631?usp=email ) Change subject: soc/intel: Add config to use S3 over S0ix ...................................................................... Abandoned Don't care -- To view, visit https://review.coreboot.org/c/coreboot/+/79631?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ife98166338c5457fb2c7dad81a30e54f487495f6 Gerrit-Change-Number: 79631 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[M] Change in coreboot[main]: soc/intel/common/block/pmc: Add GPE1 functions
by Cliff Huang (Code Review) 28 Oct '24

28 Oct '24

Attention is currently required from: Anil Kumar K, Bora Guvendik, Felix Held, Hannah Williams, Jamie Ryu, Paul Menzel, Subrata Banik. Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84104?usp=email ) Change subject: soc/intel/common/block/pmc: Add GPE1 functions ...................................................................... Patch Set 28: (2 comments) File src/soc/intel/common/block/include/intelblocks/pmclib.h: https://review.coreboot.org/c/coreboot/+/84104/comment/1d5730c6_7a9cc611?us… : PS28, Line 242: gpe0_mask > it is intended to use gpe0_mask as the argument. Please the the comment on line 239-240. Done File src/soc/intel/common/block/pmc/pmclib.c: https://review.coreboot.org/c/coreboot/+/84104/comment/fd4a3db1_751b958c?us… : PS28, Line 522: #if CONFIG(SOC_INTEL_COMMON_BLOCK_ACPI_USE_GPE1) > no. gpe1_sts and gpe1_en are only defined in the structure also based on the same config flag. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84104?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7ac1fbe6d45cbe0c86c3f72911900d92a186168d Gerrit-Change-Number: 84104 Gerrit-PatchSet: 28 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 28 Oct 2024 17:47:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: coreboot org <coreboot.org(a)gmail.com> Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Add devicetree for MAX98357A codec
by Subrata Banik (Code Review) 28 Oct '24

28 Oct '24

Attention is currently required from: Anil Kumar K, Pranava Y N. Subrata Banik has posted comments on this change by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/84888?usp=email ) Change subject: mb/google/fatcat: Add devicetree for MAX98357A codec ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb: https://review.coreboot.org/c/coreboot/+/84888/comment/eec776c1_7bf251a6?us… : PS2, Line 618: AUDIO_MAX98360_ALC5682I_I2S > thsi is already taken care in fw_config changes that is merged. Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/84888?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I20de87f673e947f0e2332b818ebca01c0fa5e200 Gerrit-Change-Number: 84888 Gerrit-PatchSet: 2 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Mon, 28 Oct 2024 17:46:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anil Kumar K <anil.kumar.k(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Update SAF base address
by Anil Kumar K (Code Review) 28 Oct '24

28 Oct '24

Anil Kumar K has posted comments on this change by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/84863?usp=email ) Change subject: soc/intel/pantherlake: Update SAF base address ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84863?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I14fa8cf06144f46369cc8cab6087c790280e9859 Gerrit-Change-Number: 84863 Gerrit-PatchSet: 2 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 28 Oct 2024 17:01:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Add devicetree for MAX98357A codec
by Anil Kumar K (Code Review) 28 Oct '24

28 Oct '24

Attention is currently required from: Pranava Y N, Subrata Banik. Anil Kumar K has posted comments on this change by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/84888?usp=email ) Change subject: mb/google/fatcat: Add devicetree for MAX98357A codec ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb: https://review.coreboot.org/c/coreboot/+/84888/comment/91f4032e_d22cb527?us… : PS2, Line 618: AUDIO_MAX98360_ALC5682I_I2S > do we need to perform any GPIO programming for programming into i2s mode or already taken care ? thsi is already taken care in fw_config changes that is merged. -- To view, visit https://review.coreboot.org/c/coreboot/+/84888?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I20de87f673e947f0e2332b818ebca01c0fa5e200 Gerrit-Change-Number: 84888 Gerrit-PatchSet: 2 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Mon, 28 Oct 2024 16:59:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2024