coreboot-gerrit October 2024

coreboot-gerrit@coreboot.org

1 participants
2622 discussions

[XS] Change in coreboot[main]: soc/mt/mt8196/gpio_eint.c: Add assert message
by Felix Held (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Arthur Heymans, Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Felix Held has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84618?usp=email ) Change subject: soc/mt/mt8196/gpio_eint.c: Add assert message ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84618?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I934b6d7ee8e8a0c204a4e328331c3ff3cd0f07de Gerrit-Change-Number: 84618 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Wed, 02 Oct 2024 11:16:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: ec/dasharo/ec: add Dasharo features
by Michał Kopeć (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Felix Singer, Krystian Hebel, Maciej Pijanowski, Michał Żygowski, Paul Menzel. Michał Kopeć has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82672?usp=email ) Change subject: ec/dasharo/ec: add Dasharo features ...................................................................... Patch Set 13: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82672/comment/8877b514_c03f99b4?us… : PS12, Line 13: > Can this be tested without a board, for example in QEMU? Sadly there is no way currently -- To view, visit https://review.coreboot.org/c/coreboot/+/82672?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Gerrit-Change-Number: 82672 Gerrit-PatchSet: 13 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Wed, 02 Oct 2024 10:38:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[L] Change in coreboot[main]: ec/dasharo/ec: add Dasharo features
by Michał Kopeć (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Felix Singer, Krystian Hebel, Maciej Pijanowski, Michał Żygowski. Michał Kopeć has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82672?usp=email ) Change subject: ec/dasharo/ec: add Dasharo features ...................................................................... Patch Set 13: (7 comments) File src/ec/dasharo/ec/dasharo_ec.c: https://review.coreboot.org/c/coreboot/+/82672/comment/baf5f451_a21ccd9b?us… : PS10, Line 17: #define DASHARO_EC_BASE 0x0E00 > Is this reserved from resource allocator? Doesn't seem to be. It's only programmed in genX_dec in devicetree https://review.coreboot.org/c/coreboot/+/82672/comment/aed0543b_d3c4e9a2?us… : PS10, Line 88: index should be valid due to length test above > I don't see such test. […] Removed in latest patchset. EC update still needs some work and debugging, let's not block merging this on that feature https://review.coreboot.org/c/coreboot/+/82672/comment/c5d5144c_1fe5616c?us… : PS10, Line 122: // Read data bytes, index should be valid due to length test above > Same as `dasharo_ec_read_version`. This code was removed https://review.coreboot.org/c/coreboot/+/82672/comment/0c4836a3_a7672aac?us… : PS10, Line 292: if ((rv = ec_spi_reset())) > I don't know how this EC works, but I assume that this reset doesn't clear SPI status, right? This code was removed https://review.coreboot.org/c/coreboot/+/82672/comment/0e6dce12_9193195c?us… : PS10, Line 323: return 0; > This and next function return 0 also when `status < 0`, is this the expected behavior? This code was removed https://review.coreboot.org/c/coreboot/+/82672/comment/5bb73ca8_80f13b1f?us… : PS10, Line 553: dasharo_ec_read_board((uint8_t *)cur_board_str); : dasharo_ec_read_version((uint8_t *)cur_version_str); > Return values are not checked, which makes `cur_*_str` potentially uninitialized. This code was removed https://review.coreboot.org/c/coreboot/+/82672/comment/c7862b09_cdeb9a87?us… : PS10, Line 570: if ((ec_read(0x10) & 0x01) != 0x01) { > Magic numbers, please at least add a comment about their meaning. This code was removed -- To view, visit https://review.coreboot.org/c/coreboot/+/82672?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Gerrit-Change-Number: 82672 Gerrit-PatchSet: 13 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Wed, 02 Oct 2024 10:34:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com>

1 0

[L] Change in coreboot[main]: ec/dasharo/ec: add Dasharo features
by Michał Kopeć (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Felix Singer, Maciej Pijanowski, Michał Kopeć, Michał Żygowski. Hello Felix Singer, Krystian Hebel, Maciej Pijanowski, Michał Żygowski, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82672?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: ec/dasharo/ec: add Dasharo features ...................................................................... ec/dasharo/ec: add Dasharo features - Setting battery thresholds - PEP hooks for S0ix - Remove unused keyboard backlight, OLED, FCMD, ACPI power button device Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- M src/ec/dasharo/ec/Kconfig M src/ec/dasharo/ec/Makefile.mk A src/ec/dasharo/ec/acpi.h M src/ec/dasharo/ec/acpi/buttons.asl A src/ec/dasharo/ec/acpi/dasharo.asl M src/ec/dasharo/ec/acpi/ec.asl M src/ec/dasharo/ec/acpi/ec_ram.asl M src/ec/dasharo/ec/acpi/lid.asl D src/ec/dasharo/ec/acpi/s76.asl A src/ec/dasharo/ec/buttons.c A src/ec/dasharo/ec/commands.h M src/ec/dasharo/ec/dasharo_ec.c D src/ec/dasharo/ec/dasharo_ec.h D src/ec/dasharo/ec/smbios.c 14 files changed, 302 insertions(+), 332 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/82672/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/82672?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Gerrit-Change-Number: 82672 Gerrit-PatchSet: 13 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>

1 0

[XS] Change in coreboot[main]: arch/arm64: Add Clang as supported target
by Arthur Heymans (Code Review) 02 Oct '24

02 Oct '24

Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/74501?usp=email ) Change subject: arch/arm64: Add Clang as supported target ...................................................................... Patch Set 32: (1 comment) Patchset: PS32: https://review.coreboot.org/c/coreboot/+/84618 fixes the build error -- To view, visit https://review.coreboot.org/c/coreboot/+/74501?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I940a1ccf5cc4ec7bed5b6c8be92fc47922e1e747 Gerrit-Change-Number: 74501 Gerrit-PatchSet: 32 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jon Murphy <jpmurphy(a)google.com> Gerrit-Comment-Date: Wed, 02 Oct 2024 10:30:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/mt/mt8196/gpio_eint.c: Add assert message
by Arthur Heymans (Code Review) 02 Oct '24

02 Oct '24

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84618?usp=email ) Change subject: soc/mt/mt8196/gpio_eint.c: Add assert message ...................................................................... soc/mt/mt8196/gpio_eint.c: Add assert message This fixes the following warning with clang (18.1.6): src/soc/mediatek/mt8196/gpio_eint.c:259:44: error: '_Static_assert' with no message is a C23 extension [-Werror,-Wc23-extensions] 259 | _Static_assert(ARRAY_SIZE(eint_data) == 293); | ^ | Change-Id: I934b6d7ee8e8a0c204a4e328331c3ff3cd0f07de Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/mediatek/mt8196/gpio_eint.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/84618/1 diff --git a/src/soc/mediatek/mt8196/gpio_eint.c b/src/soc/mediatek/mt8196/gpio_eint.c index edbae73..f24860d 100644 --- a/src/soc/mediatek/mt8196/gpio_eint.c +++ b/src/soc/mediatek/mt8196/gpio_eint.c @@ -256,7 +256,7 @@ [291] = { EINT_C, 20 }, [292] = { EINT_C, 21 }, }; -_Static_assert(ARRAY_SIZE(eint_data) == 293); +_Static_assert(ARRAY_SIZE(eint_data) == 293, "Incorrect eint_data size"); void gpio_calc_eint_pos_bit(gpio_t gpio, u32 *pos, u32 *bit) { -- To view, visit https://review.coreboot.org/c/coreboot/+/84618?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I934b6d7ee8e8a0c204a4e328331c3ff3cd0f07de Gerrit-Change-Number: 84618 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[S] Change in coreboot[main]: soc/intel/cannonlake: Hook up CNVi Bluetooth UPDs to devicetree
by Sean Rhodes (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84596?usp=email to look at the new patch set (#6). Change subject: soc/intel/cannonlake: Hook up CNVi Bluetooth UPDs to devicetree ...................................................................... soc/intel/cannonlake: Hook up CNVi Bluetooth UPDs to devicetree Hook up CNVi Bluetooth UPDs to the devicetree, and set them to true so the current behaviour is not changed. Change-Id: Ic5640c23af3ce30498be814a6d7ce56988653b25 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/soc/intel/cannonlake/chip.h M src/soc/intel/cannonlake/chipset.cb M src/soc/intel/cannonlake/chipset_pch_h.cb M src/soc/intel/cannonlake/fsp_params.c 4 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/84596/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/84596?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5640c23af3ce30498be814a6d7ce56988653b25 Gerrit-Change-Number: 84596 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

[XL] Change in coreboot[main]: mb/starlabs/starfighter: Add Raptor Lake StarFighter Mk I variant
by Sean Rhodes (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Matt DeVillier, Sean Rhodes. Hello Matt DeVillier, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74445?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Code-Review+2 by Matt DeVillier, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: mb/starlabs/starfighter: Add Raptor Lake StarFighter Mk I variant ...................................................................... mb/starlabs/starfighter: Add Raptor Lake StarFighter Mk I variant Tested using `edk2` from `github.com/starlabsltd/edk2/tree/uefipayload_vs`: * Windows 11 * Ubuntu 24.04 No known issues. https://starlabs.systems/pages/starfighter-specification Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I046e70845a5201d6f6ab062aee91fa8be9728737 --- M Documentation/mainboard/index.md A Documentation/mainboard/starlabs/starfighter_rpl.md A src/mainboard/starlabs/starfighter/Kconfig A src/mainboard/starlabs/starfighter/Kconfig.name A src/mainboard/starlabs/starfighter/Makefile.mk A src/mainboard/starlabs/starfighter/acpi/ec.asl A src/mainboard/starlabs/starfighter/acpi/mainboard.asl A src/mainboard/starlabs/starfighter/acpi/sleep.asl A src/mainboard/starlabs/starfighter/acpi/superio.asl A src/mainboard/starlabs/starfighter/board_info.txt A src/mainboard/starlabs/starfighter/bootblock.c A src/mainboard/starlabs/starfighter/cmos.default A src/mainboard/starlabs/starfighter/cmos.layout A src/mainboard/starlabs/starfighter/dsdt.asl A src/mainboard/starlabs/starfighter/hda_verb.c A src/mainboard/starlabs/starfighter/include/variants.h A src/mainboard/starlabs/starfighter/mainboard.c A src/mainboard/starlabs/starfighter/smbios.c A src/mainboard/starlabs/starfighter/spd/16gb.spd.hex A src/mainboard/starlabs/starfighter/spd/32gb.spd.hex A src/mainboard/starlabs/starfighter/spd/64gb.spd.hex A src/mainboard/starlabs/starfighter/spd/Makefile.mk A src/mainboard/starlabs/starfighter/variants/rpl/Makefile.mk A src/mainboard/starlabs/starfighter/variants/rpl/board.fmd A src/mainboard/starlabs/starfighter/variants/rpl/data.vbt A src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb A src/mainboard/starlabs/starfighter/variants/rpl/devtree.c A src/mainboard/starlabs/starfighter/variants/rpl/gpio.c A src/mainboard/starlabs/starfighter/variants/rpl/hda_verb.c A src/mainboard/starlabs/starfighter/variants/rpl/ramstage.c A src/mainboard/starlabs/starfighter/variants/rpl/romstage.c A src/mainboard/starlabs/starfighter/vboot.c 32 files changed, 1,837 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/74445/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/74445?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I046e70845a5201d6f6ab062aee91fa8be9728737 Gerrit-Change-Number: 74445 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[XS] Change in coreboot[main]: arch/arm64: Add Clang as supported target
by Arthur Heymans (Code Review) 02 Oct '24

02 Oct '24

Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74501?usp=email ) Change subject: arch/arm64: Add Clang as supported target ...................................................................... arch/arm64: Add Clang as supported target QEMU aarch64 boots to payload when compiled with clang. Change-Id: I940a1ccf5cc4ec7bed5b6c8be92fc47922e1e747 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74501 Reviewed-by: Julius Werner <jwerner(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/arch/arm64/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Julius Werner: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/arch/arm64/Kconfig b/src/arch/arm64/Kconfig index ea7b5aa..af5050b 100644 --- a/src/arch/arm64/Kconfig +++ b/src/arch/arm64/Kconfig @@ -2,7 +2,6 @@ config ARCH_ARM64 bool - select CLANG_UNSUPPORTED config ARCH_BOOTBLOCK_ARM64 bool -- To view, visit https://review.coreboot.org/c/coreboot/+/74501?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I940a1ccf5cc4ec7bed5b6c8be92fc47922e1e747 Gerrit-Change-Number: 74501 Gerrit-PatchSet: 32 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jon Murphy <jpmurphy(a)google.com>

1 0

[XS] Change in coreboot[main]: arch/arm64: Use -mno-implicit-float with clang
by Arthur Heymans (Code Review) 02 Oct '24

02 Oct '24

Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81658?usp=email ) Change subject: arch/arm64: Use -mno-implicit-float with clang ...................................................................... arch/arm64: Use -mno-implicit-float with clang This fixes building inline assembly that uses SIMD registers. This is for instance the case in the vboot library. Change-Id: I24fa9d9f81430ea3ecd40de4304a10c6e235fece Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81658 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> --- M toolchain.mk M util/xcompile/xcompile 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Julius Werner: Looks good to me, approved build bot (Jenkins): Verified diff --git a/toolchain.mk b/toolchain.mk index f985e88..77fb46e 100644 --- a/toolchain.mk +++ b/toolchain.mk @@ -60,7 +60,7 @@ ARCHDIR-ppc64 := ppc64 CFLAGS_arm += -CFLAGS_arm64 += -mgeneral-regs-only +CFLAGS_arm64 += CFLAGS_riscv += CFLAGS_x86_32 += CFLAGS_x86_64 += -mcmodel=large -mno-red-zone diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 13ed48b..3fb0cb7 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -256,6 +256,11 @@ testld "$GCC" "$FLAGS_GCC" "${GCCPREFIX}ld${LINKER_SUFFIX}" \ "$LDFLAGS --fix-cortex-a53-843419" && \ LDFLAGS_ARM64_A53_ERRATUM_843419+=" --fix-cortex-a53-843419" + # https://bugs.llvm.org/show_bug.cgi?id=30792 + # LLVM/clang runs into problems when encountering SIMD registers in assembly + # with -mgeneral-regs-only. -mno-implicit-float achieves the same though. + CFLAGS_GCC="$CFLAGS_GCC -mgeneral-regs-only" && + CFLAGS_CLANG="$CFLAGS_CLANG -mno-implicit-float" ;; riscv) testcc "$GCC" "$FLAGS_GCC -march=rv64iadc_zicsr_zifencei" && -- To view, visit https://review.coreboot.org/c/coreboot/+/81658?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I24fa9d9f81430ea3ecd40de4304a10c6e235fece Gerrit-Change-Number: 81658 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2024