coreboot-gerrit October 2024

coreboot-gerrit@coreboot.org

1 participants
2622 discussions

[S] Change in coreboot[main]: drivers/tpm: Use fieldlist for dynamic field creation
by Sean Rhodes (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Nicholas Sudsgaard. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84606?usp=email ) Change subject: drivers/tpm: Use fieldlist for dynamic field creation ...................................................................... Patch Set 5: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/84606/comment/f6d86ec9_43699f7f?us… : PS3, Line 7: drivers/tpm: Use fieldlist for dynamic field creation : : Define TPPF field dynamically in the PPOP OpRegion, this : ensures that the offset stored in Local0 is used correctly. : : This fixes: : CreateByteField (PPOP, Local0, TPPF) : Error 6058 - Invalid type ^ ([Region] found, CreateByteField operator requires [Integer|String|Buffer]) : > I'm not really familiar with this part of the codebase, so I might not be understanding something, b […] Sorry - I seem to have failed at pusing the right code... File src/drivers/tpm/ppi.c: https://review.coreboot.org/c/coreboot/+/84606/comment/d4ff3c4f_ebf3944b?us… : PS2, Line 650: " > Remove this. […] Done File src/drivers/tpm/ppi.c: https://review.coreboot.org/c/coreboot/+/84606/comment/999b64c7_95118b3c?us… : PS3, Line 644: TPPF = CreateField("PPOP", Local0) > This seems wrong? […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84606?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If80bb5bf69562f8b904c1b315e95a0b5627efbc4 Gerrit-Change-Number: 84606 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Comment-Date: Wed, 02 Oct 2024 13:49:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>

1 0

[S] Change in coreboot[main]: drivers/tpm: Use fieldlist for dynamic field creation
by Sean Rhodes (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Sean Rhodes. Hello Nicholas Sudsgaard, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84606?usp=email to look at the new patch set (#5). Change subject: drivers/tpm: Use fieldlist for dynamic field creation ...................................................................... drivers/tpm: Use fieldlist for dynamic field creation Define TPPF field dynamically in the PPOP OpRegion, this ensures that the offset stored in Local0 is used correctly. This fixes: CreateByteField (PPOP, Local0, TPPF) Error 6058 - Invalid type ^ ([Region] found, CreateByteField operator requires [Integer|String|Buffer]) Change-Id: If80bb5bf69562f8b904c1b315e95a0b5627efbc4 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/drivers/tpm/ppi.c 1 file changed, 14 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/84606/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/84606?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If80bb5bf69562f8b904c1b315e95a0b5627efbc4 Gerrit-Change-Number: 84606 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

[XS] Change in coreboot[main]: soc/amd/glinda/.../iomap.h: Update for glinda
by Marshall Dawson (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Maximilian Brune, Paul Menzel. Marshall Dawson has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84380?usp=email ) Change subject: soc/amd/glinda/.../iomap.h: Update for glinda ...................................................................... Patch Set 4: -Code-Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84380?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If282ce5687b8a2bdae03ebfc5a37fe5b8b17647a Gerrit-Change-Number: 84380 Gerrit-PatchSet: 4 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Wed, 02 Oct 2024 13:48:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: drivers/tpm: Use fieldlist for dynamic field creation
by Sean Rhodes (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Sean Rhodes. Hello Nicholas Sudsgaard, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84606?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: drivers/tpm: Use fieldlist for dynamic field creation ...................................................................... drivers/tpm: Use fieldlist for dynamic field creation Define TPPF field dynamically in the PPOP OpRegion, this ensures that the offset stored in Local0 is used correctly. This fixes: CreateByteField (PPOP, Local0, TPPF) Error 6058 - Invalid type ^ ([Region] found, CreateByteField operator requires [Integer|String|Buffer]) Change-Id: If80bb5bf69562f8b904c1b315e95a0b5627efbc4 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/drivers/tpm/ppi.c 1 file changed, 9 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/84606/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/84606?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If80bb5bf69562f8b904c1b315e95a0b5627efbc4 Gerrit-Change-Number: 84606 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/tgl: Disable DPTF
by Felix Held (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Sean Rhodes. Felix Held has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84270?usp=email ) Change subject: mb/starlabs/starbook/tgl: Disable DPTF ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I763ab948a79e3a020c1b89c69c714dd0d8f54812 Gerrit-Change-Number: 84270 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 02 Oct 2024 13:41:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/tgl: Alphabetize and group FSP UPDs
by Felix Held (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Sean Rhodes. Felix Held has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84268?usp=email ) Change subject: mb/starlabs/starbook/tgl: Alphabetize and group FSP UPDs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84268?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6bab0a316ea7d0f7dfbf599e5c08517cee559635 Gerrit-Change-Number: 84268 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 02 Oct 2024 13:41:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/cml: Disable DPTF
by Felix Held (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Sean Rhodes. Felix Held has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84266?usp=email ) Change subject: mb/starlabs/starbook/cml: Disable DPTF ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84266?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7fa01936568108dd7707a3c2ea7041a1198533b5 Gerrit-Change-Number: 84266 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 02 Oct 2024 13:40:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: drivers/usb/acpi: Move the CNMT Mutex to USB
by Sean Rhodes (Code Review) 02 Oct '24

02 Oct '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84627?usp=email ) Change subject: drivers/usb/acpi: Move the CNMT Mutex to USB ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib456b1870501182b2d8788e5d53bbf4d7981f91b Gerrit-Change-Number: 84627 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 Oct 2024 13:38:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/intel/cnvi: Add GBTE Method
by Sean Rhodes (Code Review) 02 Oct '24

02 Oct '24

Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83715?usp=email ) Change subject: soc/intel/cnvi: Add GBTE Method ...................................................................... Abandoned Created better version -- To view, visit https://review.coreboot.org/c/coreboot/+/83715?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8f6b97b0961579f36cd053b0252213c3335b1c62 Gerrit-Change-Number: 83715 Gerrit-PatchSet: 13 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: soc/intel/cnvi: Add SBTE Method
by Sean Rhodes (Code Review) 02 Oct '24

02 Oct '24

Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83714?usp=email ) Change subject: soc/intel/cnvi: Add SBTE Method ...................................................................... Abandoned Created better version -- To view, visit https://review.coreboot.org/c/coreboot/+/83714?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I11cdf654223daa7b417d6aa18855b48b50a8faa4 Gerrit-Change-Number: 83714 Gerrit-PatchSet: 12 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2024