coreboot-gerrit October 2024

coreboot-gerrit@coreboot.org

1 participants
2622 discussions

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Remove settings to replicate OEM
by Fabian Groffen (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Keith Hui, Keith Hui, Paul Menzel. Fabian Groffen has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/coreboot/+/75137?usp=email ) Change subject: mb/asus/p8z77-m: Remove settings to replicate OEM ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75137/comment/d8084662_dafb80a2?us… : PS6, Line 9: Per Fabian: : : With these settings enabled COM 1/UART A/serial port 1 gets blocked : right after the kernel boots. It no longer works or responds, which : actually means the Linux boot process gets stuck forever when configured : to write to ttyS0. : : Not using these settings, I have not found any downside. Serial keeps : working, sensors still work, S3 suspend/resume works correctly. : : --- : : Out of the six settings in this group, three are causing the initial : issue, the rest are confirmed necessary to be replicated, with PECI : as the reason for one of them. Keith revised this patch to reflect : this. > Understood. […] For what it's worth, I hereby grant permission to rework/rename/redescribe this commit in any way including removing my authorship or signoff. I think it's clear I did some work that seemed to work for me, but that Keith did a lot more work that is sound and reasonable. I think it would improve coreboot if his variant of the work would get merged. Thanks, Fabian -- To view, visit https://review.coreboot.org/c/coreboot/+/75137?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae526762e79e9e2d46d06e12c338f375e5555e8c Gerrit-Change-Number: 75137 Gerrit-PatchSet: 6 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Tue, 29 Oct 2024 07:20:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Keith Hui <buurin(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/riven: Configure Acoustic noise mitigation
by David Wu (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84908?usp=email to look at the new patch set (#2). Change subject: mb/google/nissa/var/riven: Configure Acoustic noise mitigation ...................................................................... mb/google/nissa/var/riven: Configure Acoustic noise mitigation - Enable Acoustic noise mitigation - Set slow slew rate VCCIA and VCCGT to SLEW_FAST_4 - Set FastPkgCRampDisable VCCIA and VCCGT to 1 BUG=b:376165743 TEST=build FW and check fsp log. Change-Id: Ia71985ef21d634763fc5ae22e4f611f7f5e9652a Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/riven/overridetree.cb 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/84908/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84908?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia71985ef21d634763fc5ae22e4f611f7f5e9652a Gerrit-Change-Number: 84908 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/riven: Configure Acoustic noise mitigation
by David Wu (Code Review) 29 Oct '24

29 Oct '24

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84908?usp=email ) Change subject: mb/google/nissa/var/riven: Configure Acoustic noise mitigation ...................................................................... mb/google/nissa/var/riven: Configure Acoustic noise mitigation - Enable Acoustic noise mitigation - Set slow slew rate VCCIA and VCCGT to SLEW_FAST_4 - Set FastPkgCRampDisable VCCIA and VCCGT to 1 BUG=b:376165743 TEST=build FW and check fsp log. Change-Id: Ia71985ef21d634763fc5ae22e4f611f7f5e9652a --- M src/mainboard/google/brya/variants/riven/overridetree.cb 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/84908/1 diff --git a/src/mainboard/google/brya/variants/riven/overridetree.cb b/src/mainboard/google/brya/variants/riven/overridetree.cb index d565897..00947c4 100644 --- a/src/mainboard/google/brya/variants/riven/overridetree.cb +++ b/src/mainboard/google/brya/variants/riven/overridetree.cb @@ -24,6 +24,13 @@ end chip soc/intel/alderlake + # Acoustic settings + register "acoustic_noise_mitigation" = "1" + register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_4" + register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_4" + register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" + register "fast_pkg_c_ramp_disable[VR_DOMAIN_GT]" = "1" + register "sagv" = "SaGv_Enabled" # EMMC Tx CMD Delay -- To view, visit https://review.coreboot.org/c/coreboot/+/84908?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia71985ef21d634763fc5ae22e4f611f7f5e9652a Gerrit-Change-Number: 84908 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: tests/data/lib/lzma-test/data: Fix cast of type 'nullptr_t' to 'uintp...
by Elyes Haouas (Code Review) 29 Oct '24

29 Oct '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84907?usp=email ) Change subject: tests/data/lib/lzma-test/data: Fix cast of type 'nullptr_t' to 'uintptr_t' error ...................................................................... tests/data/lib/lzma-test/data: Fix cast of type 'nullptr_t' to 'uintptr_t' error Fix remaining cast error of a 'nullptr_t' to 'uintptr_t' when using C23 Change-Id: Ifd6c8537d546aa957929396e7e3e9e82d79b5df0 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M tests/data/lib/lzma-test/data.3.bin 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/84907/1 diff --git a/tests/data/lib/lzma-test/data.3.bin b/tests/data/lib/lzma-test/data.3.bin index 6da1ac9..0a8d3f5 100644 --- a/tests/data/lib/lzma-test/data.3.bin +++ b/tests/data/lib/lzma-test/data.3.bin @@ -234,7 +234,7 @@ const struct imd_entry *lg_entry; /* Fail when the limit for lg was not set. */ - imd.lg.limit = (uintptr_t) NULL; + imd.lg.limit = 0; assert_int_equal(-1, imd_recover(&imd)); /* Set the limit for lg. */ -- To view, visit https://review.coreboot.org/c/coreboot/+/84907?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd6c8537d546aa957929396e7e3e9e82d79b5df0 Gerrit-Change-Number: 84907 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[S] Change in coreboot[main]: mb/google/fatcat: Define EC_SYNC_IRQ and GPIO_PCH_WP for variants
by Pranava Y N (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Subrata Banik. Pranava Y N has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84900?usp=email ) Change subject: mb/google/fatcat: Define EC_SYNC_IRQ and GPIO_PCH_WP for variants ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84900?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bd248496f08869c08cf6daafeed6584d0b166b7 Gerrit-Change-Number: 84900 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Tue, 29 Oct 2024 06:04:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/intel/pantherlake: Populate and pass DRAM info for SMBIOS
by Pranava Y N (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Kapil Porwal, Subrata Banik. Pranava Y N has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84903?usp=email ) Change subject: soc/intel/pantherlake: Populate and pass DRAM info for SMBIOS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84903?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3b942610272de401589ee0463de9cd0985974774 Gerrit-Change-Number: 84903 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 29 Oct 2024 05:52:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/francka: Generate RAM ID for Micron MT62F2G32D4D...
by Pranava Y N (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Amanda Hwang, Dtrain Hsu. Pranava Y N has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/84781?usp=email ) Change subject: mb/google/fatcat/var/francka: Generate RAM ID for Micron MT62F2G32D4DS-020 WT:F ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84781?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2de56c8c7a028edefbd3dc53f8b1e26dee3286f7 Gerrit-Change-Number: 84781 Gerrit-PatchSet: 4 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 29 Oct 2024 05:19:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/fatcat/var/francka: Generate RAM ID for Micron MT62F2G32D4D...
by Subrata Banik (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Amanda Hwang, Dtrain Hsu, Pranava Y N. Subrata Banik has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/84781?usp=email ) Change subject: mb/google/fatcat/var/francka: Generate RAM ID for Micron MT62F2G32D4DS-020 WT:F ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84781?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2de56c8c7a028edefbd3dc53f8b1e26dee3286f7 Gerrit-Change-Number: 84781 Gerrit-PatchSet: 4 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Tue, 29 Oct 2024 04:31:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/awasuki: Adjust touchpad I2C frequency
by hualin wei (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Felix Held, Subrata Banik. hualin wei has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/84898?usp=email ) Change subject: mb/google/dedede/var/awasuki: Adjust touchpad I2C frequency ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/84898/comment/e699745a_eaa70e84?us… : PS1, Line 7: to less than 400 KHz > remove, and elaborate in comment for why Done https://review.coreboot.org/c/coreboot/+/84898/comment/33af781c_a7462760?us… : PS1, Line 16: Frequency of the actual measured machine is pass > test with scope and check the wave? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84898?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ccaa3a669e18319311de14833966410c7adf40d Gerrit-Change-Number: 84898 Gerrit-PatchSet: 3 Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 29 Oct 2024 03:30:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/awasuki: Adjust touchpad I2C frequency
by hualin wei (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Subrata Banik, hualin wei. Hello Eric Lai, Subrata Banik, Weimin Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84898?usp=email to look at the new patch set (#3). Change subject: mb/google/dedede/var/awasuki: Adjust touchpad I2C frequency ...................................................................... mb/google/dedede/var/awasuki: Adjust touchpad I2C frequency Modify the I2C frequency of the touchpad between 380Khz and 400Khz to meet the spec. Before: I2C0 - 420KHz After: I2C0 - 390Khz BUG=b:351968527 TEST=Check wave form and met the spec. Change-Id: I5ccaa3a669e18319311de14833966410c7adf40d Signed-off-by: Wei Hualin <weihualin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/awasuki/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/84898/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/84898?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ccaa3a669e18319311de14833966410c7adf40d Gerrit-Change-Number: 84898 Gerrit-PatchSet: 3 Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: hualin wei <weihualin(a)huaqin.corp-partner.google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2024