coreboot-gerrit October 2024

coreboot-gerrit@coreboot.org

1 participants
2622 discussions

[XS] Change in coreboot[main]: acpi_gic: Add helper for platform gicc
by Naresh Solanki (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Angel Pons, Arthur Heymans, Paul Menzel, Tim Wawrzynczak. Naresh Solanki has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/79973?usp=email ) Change subject: acpi_gic: Add helper for platform gicc ...................................................................... Patch Set 2: (2 comments) File src/acpi/acpi_gic.c: https://review.coreboot.org/c/coreboot/+/79973/comment/a5d1e1cb_c51e8287?us… : PS2, Line 6: platform_gicc > Your right. I should have kept it in that way. […] Done https://review.coreboot.org/c/coreboot/+/79973/comment/d01fcf8f_1ffd55a7?us… : PS2, Line 37: platform_gicc(gicc); > Not sure what you mean. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79973?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd4c52a5482707fae8aa1b8b21fdc6bb5f4b45c2 Gerrit-Change-Number: 79973 Gerrit-PatchSet: 2 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 02 Oct 2024 16:36:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Naresh Solanki <naresh.solanki(a)9elements.com>

1 0

[XS] Change in coreboot[main]: acpi_gic: Add helper for platform gicc
by Naresh Solanki (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Angel Pons, Arthur Heymans, Paul Menzel, Tim Wawrzynczak. Hello Angel Pons, Arthur Heymans, Cliff Huang, Lance Zhao, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79973?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Angel Pons Change subject: acpi_gic: Add helper for platform gicc ...................................................................... acpi_gic: Add helper for platform gicc Add helper function to allow platform to fill gicc parameters for use in ACPI table. Change-Id: Ibd4c52a5482707fae8aa1b8b21fdc6bb5f4b45c2 Signed-off-by: Naresh Solanki <naresh.solanki(a)9elements.com> --- M src/acpi/acpi_gic.c M src/include/acpi/acpi.h 2 files changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/79973/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79973?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd4c52a5482707fae8aa1b8b21fdc6bb5f4b45c2 Gerrit-Change-Number: 79973 Gerrit-PatchSet: 3 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[XL] Change in coreboot[main]: mb/arm/rdn2: Add support for Arm Neoverse N2
by Naresh Solanki (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Arthur Heymans, David Milosevic, Felix Singer, Julius Werner, Maximilian Brune, Patrick Rudolph, Paul Menzel. Hello Arthur Heymans, David Milosevic, Julius Werner, Lean Sheng Tan, Maximilian Brune, Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79103?usp=email to look at the new patch set (#9). Change subject: mb/arm/rdn2: Add support for Arm Neoverse N2 ...................................................................... mb/arm/rdn2: Add support for Arm Neoverse N2 Add support for Arm Neoverse N2 Reference design. Based on Arm Neoverse N2 reference design Revision: Release D TEST=Build Arm Neoverse N2 & make sure there is no error. Change-Id: I17908d3ce773d4a88924bafb1d0e9e2a043c7fbc Signed-off-by: Naresh Solanki <naresh.solanki(a)9elements.com> --- A src/mainboard/arm/Kconfig A src/mainboard/arm/Kconfig.name A src/mainboard/arm/rdn2/Kconfig A src/mainboard/arm/rdn2/Kconfig.name A src/mainboard/arm/rdn2/Makefile.mk A src/mainboard/arm/rdn2/acpi.c A src/mainboard/arm/rdn2/board_info.txt A src/mainboard/arm/rdn2/bootblock.c A src/mainboard/arm/rdn2/bootblock_custom.S A src/mainboard/arm/rdn2/cbmem.c A src/mainboard/arm/rdn2/chip.h A src/mainboard/arm/rdn2/devicetree.cb A src/mainboard/arm/rdn2/dsdt.asl A src/mainboard/arm/rdn2/flash.fmd A src/mainboard/arm/rdn2/include/mainboard/addressmap.h A src/mainboard/arm/rdn2/mainboard.c A src/mainboard/arm/rdn2/media.c A src/mainboard/arm/rdn2/memlayout.ld A src/mainboard/arm/rdn2/mmio.c A src/mainboard/arm/rdn2/pptt.c 20 files changed, 1,190 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/79103/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/79103?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I17908d3ce773d4a88924bafb1d0e9e2a043c7fbc Gerrit-Change-Number: 79103 Gerrit-PatchSet: 9 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>

1 0

[XS] Change in coreboot[main]: acpi_gic: Add helper for platform gicc
by Naresh Solanki (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Angel Pons, Arthur Heymans, Paul Menzel, Tim Wawrzynczak. Naresh Solanki has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/79973?usp=email ) Change subject: acpi_gic: Add helper for platform gicc ...................................................................... Patch Set 2: (1 comment) File src/acpi/acpi_gic.c: https://review.coreboot.org/c/coreboot/+/79973/comment/cf0196a4_658cdf49?us… : PS2, Line 6: platform_gicc > This function name should have a verb to describe what it does with the GICC. […] Your right. I should have kept it in that way. Let me quickly correct that. -- To view, visit https://review.coreboot.org/c/coreboot/+/79973?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd4c52a5482707fae8aa1b8b21fdc6bb5f4b45c2 Gerrit-Change-Number: 79973 Gerrit-PatchSet: 2 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 02 Oct 2024 16:32:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: acpi_gic: Add helper for platform gicc
by Angel Pons (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Arthur Heymans, Paul Menzel, Tim Wawrzynczak. Angel Pons has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/79973?usp=email ) Change subject: acpi_gic: Add helper for platform gicc ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/acpi/acpi_gic.c: https://review.coreboot.org/c/coreboot/+/79973/comment/a5d6273d_3448dba7?us… : PS2, Line 6: platform_gicc This function name should have a verb to describe what it does with the GICC. How about `platform_fill_gicc()` instead? -- To view, visit https://review.coreboot.org/c/coreboot/+/79973?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd4c52a5482707fae8aa1b8b21fdc6bb5f4b45c2 Gerrit-Change-Number: 79973 Gerrit-PatchSet: 2 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 02 Oct 2024 16:29:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: acpi_gic: Add helper for platform gicc
by Naresh Solanki (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Angel Pons, Arthur Heymans, Paul Menzel, Tim Wawrzynczak. Naresh Solanki has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/79973?usp=email ) Change subject: acpi_gic: Add helper for platform gicc ...................................................................... Patch Set 2: (1 comment) File src/acpi/acpi_gic.c: https://review.coreboot.org/c/coreboot/+/79973/comment/aeef94ef_607cfe2c?us… : PS2, Line 37: platform_gicc(gicc); > Would it make sense to have those passed via the function arguments? Not sure what you mean. This is how I'm using it in mainboard: https://review.coreboot.org/c/coreboot/+/79103/8/src/mainboard/arm/rdn2/acp… -- To view, visit https://review.coreboot.org/c/coreboot/+/79973?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd4c52a5482707fae8aa1b8b21fdc6bb5f4b45c2 Gerrit-Change-Number: 79973 Gerrit-PatchSet: 2 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 02 Oct 2024 16:25:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[S] Change in coreboot[main]: soc/intel/alderlake: Hook up PCIe Power Management to option API
by Angel Pons (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Sean Rhodes, Subrata Banik. Angel Pons has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/81906?usp=email ) Change subject: soc/intel/alderlake: Hook up PCIe Power Management to option API ...................................................................... Patch Set 10: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81906/comment/a0f49d4e_059ff13b?us… : PS10, Line 10: option API. > For us, at least, people wanted it as a "make sure no power saving stuff is making me lose 0. […] Okay, I see. Could you please note down this design decision in the commit message then, for future reference? -- To view, visit https://review.coreboot.org/c/coreboot/+/81906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2b06a7c734a4fd4073e86c668742ee35e1d79956 Gerrit-Change-Number: 81906 Gerrit-PatchSet: 10 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 02 Oct 2024 16:23:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: acpi_gic: Add helper for platform gicc
by Arthur Heymans (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Angel Pons, Arthur Heymans, Naresh Solanki, Paul Menzel, Tim Wawrzynczak. Arthur Heymans has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/79973?usp=email ) Change subject: acpi_gic: Add helper for platform gicc ...................................................................... Patch Set 2: (1 comment) File src/acpi/acpi_gic.c: https://review.coreboot.org/c/coreboot/+/79973/comment/1f065dc1_fcfcef64?us… : PS2, Line 37: platform_gicc(gicc); Would it make sense to have those passed via the function arguments? -- To view, visit https://review.coreboot.org/c/coreboot/+/79973?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd4c52a5482707fae8aa1b8b21fdc6bb5f4b45c2 Gerrit-Change-Number: 79973 Gerrit-PatchSet: 2 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Comment-Date: Wed, 02 Oct 2024 16:21:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/starlabs/starlite_adl: Make the memory speed configurable
by Matt DeVillier (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84635?usp=email ) Change subject: mb/starlabs/starlite_adl: Make the memory speed configurable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84635?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie77d3be122478d5e674f92f8085930ae38ff2de1 Gerrit-Change-Number: 84635 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 02 Oct 2024 16:21:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in coreboot[main]: mb/arm/rdn2: Add support for Arm Neoverse N2
by Naresh Solanki (Code Review) 02 Oct '24

02 Oct '24

Attention is currently required from: Arthur Heymans, David Milosevic, Felix Singer, Julius Werner, Maximilian Brune, Patrick Rudolph, Paul Menzel. Naresh Solanki has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/79103?usp=email ) Change subject: mb/arm/rdn2: Add support for Arm Neoverse N2 ...................................................................... Patch Set 7: (1 comment) File src/mainboard/arm/rdn2/Makefile.inc: PS6: > Rename to Makefile. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/79103?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I17908d3ce773d4a88924bafb1d0e9e2a043c7fbc Gerrit-Change-Number: 79103 Gerrit-PatchSet: 7 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Wed, 02 Oct 2024 16:19:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2024