coreboot-gerrit October 2024

coreboot-gerrit@coreboot.org

1 participants
2622 discussions

[XS] Change in coreboot[main]: mb/google/dedede/var/awasuki: Decrease touchpad I2C freq below 400 kHz
by hualin wei (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Eric Lai, Paul Menzel, Weimin Wu. Hello Eric Lai, Felix Held, Paul Menzel, Subrata Banik, Weimin Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84898?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by Paul Menzel, Code-Review+1 by Weimin Wu, Code-Review+2 by Eric Lai, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: mb/google/dedede/var/awasuki: Decrease touchpad I2C freq below 400 kHz ...................................................................... mb/google/dedede/var/awasuki: Decrease touchpad I2C freq below 400 kHz Modify the I2C frequency of the touchpad between 380 Khz and 400 Khz to meet the spec. Before: I2C0 - 420KHz After: I2C0 - 398Khz BUG=b:351968527 TEST=Check that the wave form meets the spec. Change-Id: I5ccaa3a669e18319311de14833966410c7adf40d Signed-off-by: Wei Hualin <weihualin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/awasuki/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/84898/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/84898?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ccaa3a669e18319311de14833966410c7adf40d Gerrit-Change-Number: 84898 Gerrit-PatchSet: 5 Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/awasuki: Decrease touchpad I2C freq below 400 kHz
by hualin wei (Code Review) 29 Oct '24

29 Oct '24

hualin wei has restored this change. ( https://review.coreboot.org/c/coreboot/+/84898?usp=email ) Change subject: mb/google/dedede/var/awasuki: Decrease touchpad I2C freq below 400 kHz ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/84898?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: restore Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ccaa3a669e18319311de14833966410c7adf40d Gerrit-Change-Number: 84898 Gerrit-PatchSet: 4 Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in coreboot[main]: mb/lenovo: Add IH61M mainboard
by Angel Pons (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Alexander Couzens, Cleyton Silva, Keith Hui. Angel Pons has posted comments on this change by Cleyton Silva. ( https://review.coreboot.org/c/coreboot/+/83670?usp=email ) Change subject: mb/lenovo: Add IH61M mainboard ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83670/comment/049455f8_d55c39b9?us… : PS1, Line 13: 2MB+4MB > I don't know why ifdtool is showing the regions out of order, besides gbe and pd which aren't even u […] Regions in ifdtool's output are ordered by index. ``` Component 2 Density: 4MB Component 1 Density: 2MB ``` Okay, interesting. So it's 2+4. -- To view, visit https://review.coreboot.org/c/coreboot/+/83670?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia7387bd46113e85fd00b17374ec4dee8e23b4e2c Gerrit-Change-Number: 83670 Gerrit-PatchSet: 9 Gerrit-Owner: Cleyton Silva <pokecleyton(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Cleyton Silva <pokecleyton(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 29 Oct 2024 11:49:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Cleyton Silva <pokecleyton(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/lenovo: Add IH61M mainboard
by Cleyton Silva (Code Review) 29 Oct '24

29 Oct '24

1 0

[L] Change in coreboot[main]: mb/lenovo: Add IH61M mainboard
by Cleyton Silva (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Alexander Couzens, Angel Pons, Keith Hui. Cleyton Silva has posted comments on this change by Cleyton Silva. ( https://review.coreboot.org/c/coreboot/+/83670?usp=email ) Change subject: mb/lenovo: Add IH61M mainboard ...................................................................... Patch Set 6: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83670/comment/071d9d27_58ba17d4?us… : PS1, Line 13: 2MB+4MB > This doesn't show the flash chip order, though. Can you please show the output of `. […] I don't know why ifdtool is showing the regions out of order, besides gbe and pd which aren't even used on this board, but the hex addresses where each region starts/ends are correct, organized like this... 00000000:00000fff fd 00001000:001fffff me 00200000:005fffff bios ./util/ifdtool -d bkp-lenovo-h61.rom > https://pastebin.com/raw/Yx7jbv7r https://review.coreboot.org/c/coreboot/+/83670/comment/6c2f023c_9004963f?us… : PS1, Line 43: - Internal flashing : - External flashing (in-circuit) > Nice! Isn't it convenient that UEFI code reuse leads to exploit reuse? 😄 […] Very convenient! =) Okay, I'll make another separate commit later to document the flashing for this board. Thanks, Angel! File src/mainboard/lenovo/ih61m/Kconfig: https://review.coreboot.org/c/coreboot/+/83670/comment/980a10f3_8a4f633e?us… : PS4, Line 23: config MAINBOARD_PART_NUMBER : default "IH61M Ver:1.0" if BOARD_LENOVO_IH61M_V1 : default "IH61M Ver:4.2" if BOARD_LENOVO_IH61M_V4 > Would it make more sense to set `MAINBOARD_VERSION` instead? […] Acknowledged File src/mainboard/lenovo/ih61m/early_init.c: https://review.coreboot.org/c/coreboot/+/83670/comment/77bf4eb6_639144ad?us… : PS4, Line 27: pnp_set_logical_device(SERIAL_DEV); > This shouldn't be needed, `nuvoton_enable_serial` already switches to `SERIAL_DEV` Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/83670?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia7387bd46113e85fd00b17374ec4dee8e23b4e2c Gerrit-Change-Number: 83670 Gerrit-PatchSet: 6 Gerrit-Owner: Cleyton Silva <pokecleyton(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 29 Oct 2024 11:11:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Cleyton Silva <pokecleyton(a)gmail.com>

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Add ACPI names for missing devices
by Pranava Y N (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Kapil Porwal, Subrata Banik. Pranava Y N has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84910?usp=email ) Change subject: soc/intel/pantherlake: Add ACPI names for missing devices ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84910?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I474089607522a4bd13375cc34b8f8645ca3663d9 Gerrit-Change-Number: 84910 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 29 Oct 2024 11:01:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/intel/pantherlake: Populate and pass DRAM info for SMBIOS
by Paul Menzel (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Subrata Banik. Paul Menzel has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84903?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/intel/pantherlake: Populate and pass DRAM info for SMBIOS ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/pantherlake/romstage/romstage.c: https://review.coreboot.org/c/coreboot/+/84903/comment/d020b24b_1a20abb9?us… : PS1, Line 28: static void save_dimm_info(void) This looks very similar to other Intel SOC implementations. Isn’t this only dependent on the FSP version, and could be unified? -- To view, visit https://review.coreboot.org/c/coreboot/+/84903?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3b942610272de401589ee0463de9cd0985974774 Gerrit-Change-Number: 84903 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Tue, 29 Oct 2024 11:00:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Set SMBUS device ACPI min sleep state as D0
by Pranava Y N (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Kapil Porwal, Subrata Banik. Pranava Y N has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84909?usp=email ) Change subject: soc/intel/pantherlake: Set SMBUS device ACPI min sleep state as D0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84909?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If84d2ee8abfef34f6411e01e6c37d4e2008a3666 Gerrit-Change-Number: 84909 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 29 Oct 2024 10:55:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/riven: Configure Acoustic noise mitigation
by Paul Menzel (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: David Wu, Dinesh Gehlot, Jayvik Desai, Nick Vaccaro. Paul Menzel has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/84908?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/nissa/var/riven: Configure Acoustic noise mitigation ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84908/comment/256ad999_75806a94?us… : PS3, Line 8: Maybe add: > Follow the thermal team’s recommendation: -- To view, visit https://review.coreboot.org/c/coreboot/+/84908?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia71985ef21d634763fc5ae22e4f611f7f5e9652a Gerrit-Change-Number: 84908 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 29 Oct 2024 10:55:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/google/nissa/var/teliks: Match VBT with SSFC
by Paul Menzel (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Weimin Wu. Paul Menzel has posted comments on this change by Qinghong Zeng. ( https://review.coreboot.org/c/coreboot/+/84871?usp=email ) Change subject: mb/google/nissa/var/teliks: Match VBT with SSFC ...................................................................... Patch Set 15: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84871/comment/cd73ef52_3ff96b32?us… : PS15, Line 21: CBFS: Found 'vbt-teliks_panel_11_inch.bin' @0x1c6140 size 0x50f in : mcache @0x76adda14 Log lines do not need to be line wrapped. -- To view, visit https://review.coreboot.org/c/coreboot/+/84871?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia8fb45aede5ead4826d983760506c366a70643ee Gerrit-Change-Number: 84871 Gerrit-PatchSet: 15 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Derek Huang <derekhuang(a)google.com> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Edward Dai <edwarddai(a)google.com> Gerrit-CC: Ricky Chang <rickytlchang(a)google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 29 Oct 2024 10:53:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2024