coreboot-gerrit October 2024

coreboot-gerrit@coreboot.org

1 participants
2622 discussions

[M] Change in coreboot[main]: Documentation: Add information about the deguard utility
by Paul Menzel (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Máté Kukri. Paul Menzel has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/84825?usp=email ) Change subject: Documentation: Add information about the deguard utility ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/84825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idba0f461d31db31cbc9c35ee3da70c116d5493ce Gerrit-Change-Number: 84825 Gerrit-PatchSet: 3 Gerrit-Owner: Máté Kukri <km(a)mkukri.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Máté Kukri <km(a)mkukri.xyz> Gerrit-Comment-Date: Tue, 29 Oct 2024 13:13:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/intel/pantherlake: Populate and pass DRAM info for SMBIOS
by Subrata Banik (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Paul Menzel. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84903?usp=email ) Change subject: soc/intel/pantherlake: Populate and pass DRAM info for SMBIOS ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/pantherlake/romstage/romstage.c: https://review.coreboot.org/c/coreboot/+/84903/comment/3f0b3a00_b40c57ca?us… : PS1, Line 28: static void save_dimm_info(void) > This looks very similar to other Intel SOC implementations. Isn’t this only dependent on the FSP version, and could be unified? yes, I will consider moving this into some common location inside FSP. marking it resolved till then. -- To view, visit https://review.coreboot.org/c/coreboot/+/84903?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3b942610272de401589ee0463de9cd0985974774 Gerrit-Change-Number: 84903 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 29 Oct 2024 13:04:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Add ACPI names for missing devices
by Subrata Banik (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Kapil Porwal, Paul Menzel. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84910?usp=email ) Change subject: soc/intel/pantherlake: Add ACPI names for missing devices ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84910/comment/780ae724_26585a92?us… : PS1, Line 26: Signed-off-by: Subrata Banik <subratabanik(a)google.com> > Move one line below? Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/84910?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I474089607522a4bd13375cc34b8f8645ca3663d9 Gerrit-Change-Number: 84910 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 29 Oct 2024 13:03:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Add ACPI names for missing devices
by Subrata Banik (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Kapil Porwal, Subrata Banik. Hello Kapil Porwal, Paul Menzel, Pranava Y N, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84910?usp=email to look at the new patch set (#3). Change subject: soc/intel/pantherlake: Add ACPI names for missing devices ...................................................................... soc/intel/pantherlake: Add ACPI names for missing devices This patch adds ACPI names for the following devices: - THC0 (PCI: 00:10.0) - THC1 (PCI: 00:10.1) - SRAM (PCI: 00:14.2) - FSPI (PCI: 00:1f.5) TEST=Able to build and boot google/fatcat without any error. w/o this patch: [ERROR] Missing ACPI Name for PCI: 00:10.0 [ERROR] Missing ACPI Name for PCI: 00:10.1 [ERROR] Missing ACPI Name for PCI: 00:14.2 [ERROR] Missing ACPI Name for PCI: 00:1f.5 Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I474089607522a4bd13375cc34b8f8645ca3663d9 --- M src/soc/intel/pantherlake/chip.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/84910/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/84910?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I474089607522a4bd13375cc34b8f8645ca3663d9 Gerrit-Change-Number: 84910 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Set SMBUS device ACPI min sleep state as D0
by Subrata Banik (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Kapil Porwal, Paul Menzel. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84909?usp=email ) Change subject: soc/intel/pantherlake: Set SMBUS device ACPI min sleep state as D0 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84909/comment/9b95d6de_4ea395a4?us… : PS1, Line 16: ``` : [WARN ] Unknown min d_state for PCI: 00:1f.4 : ``` > As \`\`\` is not official Markdown, I’d use, especially for single lines, four spaces to mark code l […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/84909?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If84d2ee8abfef34f6411e01e6c37d4e2008a3666 Gerrit-Change-Number: 84909 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 29 Oct 2024 13:03:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Set SMBUS device ACPI min sleep state as D0
by Subrata Banik (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Kapil Porwal, Subrata Banik. Hello Kapil Porwal, Paul Menzel, Pranava Y N, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84909?usp=email to look at the new patch set (#2). Change subject: soc/intel/pantherlake: Set SMBUS device ACPI min sleep state as D0 ...................................................................... soc/intel/pantherlake: Set SMBUS device ACPI min sleep state as D0 This change sets the SMBUS device to min sleep state D0 in the ACPI sleep state table. TEST=Able to build and boot google/fatcat. w/o this patch: [WARN ] Unknown min d_state for PCI: 00:1f.4 w/ this patch: No Error or Warning. Change-Id: If84d2ee8abfef34f6411e01e6c37d4e2008a3666 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/soc/intel/pantherlake/acpi.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/84909/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84909?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If84d2ee8abfef34f6411e01e6c37d4e2008a3666 Gerrit-Change-Number: 84909 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Add ACPI names for missing devices
by Subrata Banik (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Kapil Porwal, Subrata Banik. Hello Kapil Porwal, Paul Menzel, Pranava Y N, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84910?usp=email to look at the new patch set (#2). Change subject: soc/intel/pantherlake: Add ACPI names for missing devices ...................................................................... soc/intel/pantherlake: Add ACPI names for missing devices This patch adds ACPI names for the following devices: - THC0 (PCI: 00:10.0) - THC1 (PCI: 00:10.1) - SRAM (PCI: 00:14.2) - FSPI (PCI: 00:1f.5) TEST=Able to build and boot google/fatcat without any error. w/o this patch: ``` [ERROR] Missing ACPI Name for PCI: 00:10.0 [ERROR] Missing ACPI Name for PCI: 00:10.1 [ERROR] Missing ACPI Name for PCI: 00:14.2 [ERROR] Missing ACPI Name for PCI: 00:1f.5 ``` Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I474089607522a4bd13375cc34b8f8645ca3663d9 --- M src/soc/intel/pantherlake/chip.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/84910/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84910?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I474089607522a4bd13375cc34b8f8645ca3663d9 Gerrit-Change-Number: 84910 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>

1 0

[M] Change in coreboot[main]: Documentation: Add information about the deguard utility
by Máté Kukri (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Paul Menzel. Máté Kukri has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/84825?usp=email ) Change subject: Documentation: Add information about the deguard utility ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84825/comment/f167dd98_a6e81a97?us… : PS2, Line 10: > The Signed-off-by line is missing. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idba0f461d31db31cbc9c35ee3da70c116d5493ce Gerrit-Change-Number: 84825 Gerrit-PatchSet: 3 Gerrit-Owner: Máté Kukri <km(a)mkukri.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 29 Oct 2024 12:44:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[M] Change in coreboot[main]: Documentation: Add information about the deguard utility
by Máté Kukri (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Máté Kukri. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84825?usp=email to look at the new patch set (#3). Change subject: Documentation: Add information about the deguard utility ...................................................................... Documentation: Add information about the deguard utility Change-Id: Idba0f461d31db31cbc9c35ee3da70c116d5493ce Signed-off-by: Mate Kukri <km(a)mkukri.xyz> --- A Documentation/soc/intel/deguard.md M Documentation/soc/intel/index.md 2 files changed, 77 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/84825/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/84825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idba0f461d31db31cbc9c35ee3da70c116d5493ce Gerrit-Change-Number: 84825 Gerrit-PatchSet: 3 Gerrit-Owner: Máté Kukri <km(a)mkukri.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Máté Kukri <km(a)mkukri.xyz>

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/awasuki: Decrease touchpad I2C freq below 400 kHz
by Weimin Wu (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Eric Lai, Paul Menzel, hualin wei. Weimin Wu has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/84898?usp=email ) Change subject: mb/google/dedede/var/awasuki: Decrease touchpad I2C freq below 400 kHz ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/84898?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ccaa3a669e18319311de14833966410c7adf40d Gerrit-Change-Number: 84898 Gerrit-PatchSet: 5 Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 29 Oct 2024 12:07:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2024