coreboot-gerrit October 2024

coreboot-gerrit@coreboot.org

1 participants
2622 discussions

[M] Change in coreboot[main]: acpi: Use boolean instead of int
by Elyes Haouas (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Cliff Huang, Dinesh Gehlot, Eran Mitrani, Felix Held, Fred Reitberger, Jakub Czapiga, Jason Glenesk, Jayvik Desai, Kapil Porwal, Lance Zhao, Lean Sheng Tan, Matt DeVillier, Nick Vaccaro, Pranava Y N, Sean Rhodes, Subrata Banik, Tarun, Tim Wawrzynczak, Werner Zeh. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84914?usp=email ) Change subject: acpi: Use boolean instead of int ...................................................................... Patch Set 2: (1 comment) File src/acpi/gnvs.c: https://review.coreboot.org/c/coreboot/+/84914/comment/2461399f_c2f1d3ef?us… : PS2, Line 87: gnvs->pm1i = -1; : gnvs->gpei = -1; Out of scope, is this better? `*gnvs_ = &(struct global_nvs) { .pm1i = -1, .gpei = -1 };` -- To view, visit https://review.coreboot.org/c/coreboot/+/84914?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I361d4b8827fac25d1849ad68fddc9fdeb4113c0a Gerrit-Change-Number: 84914 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 29 Oct 2024 16:02:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: commonlib/fsp_relocate: Use boolean instead of int
by Elyes Haouas (Code Review) 29 Oct '24

29 Oct '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84912?usp=email to look at the new patch set (#2). Change subject: commonlib/fsp_relocate: Use boolean instead of int ...................................................................... commonlib/fsp_relocate: Use boolean instead of int Modern C provides boolean, use it instead of old style 0, -1. Change-Id: I3a9cda6148566bca326cb0258611664fb2ca0ee7 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/commonlib/fsp_relocate.c 1 file changed, 15 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/84912/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84912?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3a9cda6148566bca326cb0258611664fb2ca0ee7 Gerrit-Change-Number: 84912 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: commonlib/device_tree: Use boolean instead of int
by Elyes Haouas (Code Review) 29 Oct '24

29 Oct '24

Elyes Haouas has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/84911?usp=email ) Change subject: commonlib/device_tree: Use boolean instead of int ...................................................................... commonlib/device_tree: Use boolean instead of int Modern C provides boolean, use it instead of old style 0, -1. Change-Id: Icf938c24d067c9d15faf45b6072e150f0aedfe08 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/commonlib/device_tree.c M src/commonlib/include/commonlib/device_tree.h 2 files changed, 43 insertions(+), 43 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/84911/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84911?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icf938c24d067c9d15faf45b6072e150f0aedfe08 Gerrit-Change-Number: 84911 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[M] Change in coreboot[main]: acpi: Use boolean instead of int
by Elyes Haouas (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Cliff Huang, Dinesh Gehlot, Eran Mitrani, Felix Held, Fred Reitberger, Jakub Czapiga, Jason Glenesk, Jayvik Desai, Kapil Porwal, Lance Zhao, Lean Sheng Tan, Matt DeVillier, Nick Vaccaro, Pranava Y N, Sean Rhodes, Subrata Banik, Tarun, Tim Wawrzynczak, Werner Zeh. Hello Cliff Huang, Dinesh Gehlot, Eran Mitrani, Felix Held, Fred Reitberger, Jakub Czapiga, Jason Glenesk, Jayvik Desai, Kapil Porwal, Lance Zhao, Lean Sheng Tan, Matt DeVillier, Nick Vaccaro, Pranava Y N, Sean Rhodes, Subrata Banik, Tarun, Tim Wawrzynczak, Werner Zeh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84914?usp=email to look at the new patch set (#2). Change subject: acpi: Use boolean instead of int ...................................................................... acpi: Use boolean instead of int Modern C provides boolean, use it instead of old style 0, -1. Change-Id: I361d4b8827fac25d1849ad68fddc9fdeb4113c0a Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/acpi/acpi_pm.c M src/acpi/acpigen.c M src/acpi/gnvs.c M src/acpi/pld.c M src/include/acpi/acpi_gnvs.h M src/include/acpi/acpi_pld.h M src/include/acpi/acpi_pm.h M src/soc/amd/common/block/acpi/acpi.c M src/soc/amd/common/block/acpi/pm_state.c M src/soc/amd/common/block/gpio/gpio.c M src/soc/intel/alderlake/pmutil.c M src/soc/intel/apollolake/elog.c M src/soc/intel/apollolake/pmutil.c M src/soc/intel/baytrail/elog.c M src/soc/intel/baytrail/ramstage.c M src/soc/intel/braswell/elog.c M src/soc/intel/broadwell/pch/elog.c M src/soc/intel/broadwell/pch/ramstage.c M src/soc/intel/cannonlake/pmutil.c M src/soc/intel/common/block/acpi/acpi_wake_source.c M src/soc/intel/elkhartlake/pmutil.c M src/soc/intel/jasperlake/pmutil.c M src/soc/intel/meteorlake/pmutil.c M src/soc/intel/pantherlake/pmutil.c M src/soc/intel/skylake/elog.c M src/soc/intel/tigerlake/pmutil.c 26 files changed, 44 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/84914/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84914?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I361d4b8827fac25d1849ad68fddc9fdeb4113c0a Gerrit-Change-Number: 84914 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[M] Change in coreboot[main]: acpi: : Use boolean instead of int
by Elyes Haouas (Code Review) 29 Oct '24

29 Oct '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84914?usp=email ) Change subject: acpi: : Use boolean instead of int ...................................................................... acpi: : Use boolean instead of int Moderne C provides boolean, use it instead of old style 0, -1. Change-Id: I361d4b8827fac25d1849ad68fddc9fdeb4113c0a Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/acpi/acpi_pm.c M src/acpi/acpigen.c M src/acpi/gnvs.c M src/acpi/pld.c M src/include/acpi/acpi_gnvs.h M src/include/acpi/acpi_pld.h M src/include/acpi/acpi_pm.h M src/soc/amd/common/block/acpi/acpi.c M src/soc/amd/common/block/acpi/pm_state.c M src/soc/amd/common/block/gpio/gpio.c M src/soc/intel/alderlake/pmutil.c M src/soc/intel/apollolake/elog.c M src/soc/intel/apollolake/pmutil.c M src/soc/intel/baytrail/elog.c M src/soc/intel/baytrail/ramstage.c M src/soc/intel/braswell/elog.c M src/soc/intel/broadwell/pch/elog.c M src/soc/intel/broadwell/pch/ramstage.c M src/soc/intel/cannonlake/pmutil.c M src/soc/intel/common/block/acpi/acpi_wake_source.c M src/soc/intel/elkhartlake/pmutil.c M src/soc/intel/jasperlake/pmutil.c M src/soc/intel/meteorlake/pmutil.c M src/soc/intel/pantherlake/pmutil.c M src/soc/intel/skylake/elog.c M src/soc/intel/tigerlake/pmutil.c 26 files changed, 44 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/84914/1 diff --git a/src/acpi/acpi_pm.c b/src/acpi/acpi_pm.c index 722d8f6..e873277 100644 --- a/src/acpi/acpi_pm.c +++ b/src/acpi/acpi_pm.c @@ -46,7 +46,7 @@ return acpi_pm_state; } -int acpi_fetch_pm_state(const struct chipset_power_state **ps, +bool acpi_fetch_pm_state(const struct chipset_power_state **ps, enum power_state_claimer ps_claimer) { assert(ps_claimer < PS_CLAIMER_MAX); @@ -56,9 +56,9 @@ printk(BIOS_ERR, "No CBMEM_ID_POWER_STATE entry, %s\n", ps_claimer < PS_CLAIMER_MAX ? pm_fetch_failure_msg[ps_claimer] : "unknown claimer."); - return -1; + return false; } - return 0; + return true; } /* Not every <soc/nvs.h> exists and has required fields. */ diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c index 4049df0..8f95a1a 100644 --- a/src/acpi/acpigen.c +++ b/src/acpi/acpigen.c @@ -1792,7 +1792,7 @@ { uint8_t buf[20]; - if (acpi_pld_to_buffer(pld, buf, ARRAY_SIZE(buf)) < 0) + if (!acpi_pld_to_buffer(pld, buf, ARRAY_SIZE(buf))) return; acpigen_write_name("_PLD"); diff --git a/src/acpi/gnvs.c b/src/acpi/gnvs.c index 1e5d746..9c29cd8 100644 --- a/src/acpi/gnvs.c +++ b/src/acpi/gnvs.c @@ -78,15 +78,15 @@ acpigen_pop_len(); } -int acpi_reset_gnvs_for_wake(struct global_nvs **gnvs_) +bool acpi_reset_gnvs_for_wake(struct global_nvs **gnvs_) { if (!gnvs) - return -1; + return false; /* Set unknown wake source */ gnvs->pm1i = -1; gnvs->gpei = -1; *gnvs_ = gnvs; - return 0; + return true; } diff --git a/src/acpi/pld.c b/src/acpi/pld.c index b9c98a1..64d2342 100644 --- a/src/acpi/pld.c +++ b/src/acpi/pld.c @@ -1,15 +1,16 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <stdbool.h> #include <stdint.h> #include <string.h> #include <acpi/acpi.h> #include <acpi/acpi_pld.h> -int acpi_pld_fill_usb(struct acpi_pld *pld, enum acpi_upc_type type, +bool acpi_pld_fill_usb(struct acpi_pld *pld, enum acpi_upc_type type, struct acpi_pld_group *group) { if (!pld) - return -1; + return false; memset(pld, 0, sizeof(struct acpi_pld)); @@ -50,13 +51,13 @@ break; } - return 0; + return true; } -int acpi_pld_to_buffer(const struct acpi_pld *pld, uint8_t *buf, int buf_len) +bool acpi_pld_to_buffer(const struct acpi_pld *pld, uint8_t *buf, int buf_len) { if (!pld || !buf) - return -1; + return false; memset(buf, 0, buf_len); @@ -155,5 +156,5 @@ buf[19] = pld->horizontal_offset >> 8; } - return 0; + return true; } diff --git a/src/include/acpi/acpi_gnvs.h b/src/include/acpi/acpi_gnvs.h index fe6924f..d72c571 100644 --- a/src/include/acpi/acpi_gnvs.h +++ b/src/include/acpi/acpi_gnvs.h @@ -12,10 +12,10 @@ #if CONFIG(ACPI_SOC_NVS) void *acpi_get_gnvs(void); void *acpi_get_device_nvs(void); -int acpi_reset_gnvs_for_wake(struct global_nvs **gnvs); +bool acpi_reset_gnvs_for_wake(struct global_nvs **gnvs); #else static inline void *acpi_get_gnvs(void) { return NULL; } -static inline int acpi_reset_gnvs_for_wake(struct global_nvs **gnvs) { return -1; } +static inline bool acpi_reset_gnvs_for_wake(struct global_nvs **gnvs) { return -1; } #endif /* Return GNVS fields for USB0/1 disablement for S3/S4/S5 sleep states. */ diff --git a/src/include/acpi/acpi_pld.h b/src/include/acpi/acpi_pld.h index 98d7f9e..4657622 100644 --- a/src/include/acpi/acpi_pld.h +++ b/src/include/acpi/acpi_pld.h @@ -130,10 +130,10 @@ }; /* Fill out PLD structure with defaults based on USB port type */ -int acpi_pld_fill_usb(struct acpi_pld *pld, enum acpi_upc_type type, +bool acpi_pld_fill_usb(struct acpi_pld *pld, enum acpi_upc_type type, struct acpi_pld_group *group); /* Turn PLD structure into a 20 byte ACPI buffer */ -int acpi_pld_to_buffer(const struct acpi_pld *pld, uint8_t *buf, int buf_len); +bool acpi_pld_to_buffer(const struct acpi_pld *pld, uint8_t *buf, int buf_len); #endif /* __ACPI_ACPI_PLD_H__ */ diff --git a/src/include/acpi/acpi_pm.h b/src/include/acpi/acpi_pm.h index 584265e..bf338f6 100644 --- a/src/include/acpi/acpi_pm.h +++ b/src/include/acpi/acpi_pm.h @@ -3,6 +3,8 @@ #ifndef ACPI_PM_H #define ACPI_PM_H +#include <stdbool.h> + enum power_state_claimer { PS_CLAIMER_ELOG, PS_CLAIMER_RTC, @@ -12,7 +14,7 @@ struct chipset_power_state; struct chipset_power_state *acpi_get_pm_state(void); -int acpi_fetch_pm_state(const struct chipset_power_state **ps, +bool acpi_fetch_pm_state(const struct chipset_power_state **ps, enum power_state_claimer ps_claimer); #endif diff --git a/src/soc/amd/common/block/acpi/acpi.c b/src/soc/amd/common/block/acpi/acpi.c index 75d4adf..44432af 100644 --- a/src/soc/amd/common/block/acpi/acpi.c +++ b/src/soc/amd/common/block/acpi/acpi.c @@ -79,7 +79,7 @@ const struct chipset_power_state *ps; const struct acpi_pm_gpe_state *state; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG)) return; state = &ps->gpe_state; diff --git a/src/soc/amd/common/block/acpi/pm_state.c b/src/soc/amd/common/block/acpi/pm_state.c index 23a7d45..2ebd279 100644 --- a/src/soc/amd/common/block/acpi/pm_state.c +++ b/src/soc/amd/common/block/acpi/pm_state.c @@ -47,9 +47,9 @@ const struct chipset_power_state *ps; struct global_nvs *gnvs; - if (acpi_reset_gnvs_for_wake(&gnvs) < 0) + if (!acpi_reset_gnvs_for_wake(&gnvs)) return; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_WAKE) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_WAKE)) return; pm_fill_gnvs(gnvs, &ps->gpe_state); diff --git a/src/soc/amd/common/block/gpio/gpio.c b/src/soc/amd/common/block/gpio/gpio.c index ce098d0..ead7aa8 100644 --- a/src/soc/amd/common/block/gpio/gpio.c +++ b/src/soc/amd/common/block/gpio/gpio.c @@ -385,7 +385,7 @@ unsigned int i; unsigned int end; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG)) return; state = &ps->gpio_state; diff --git a/src/soc/intel/alderlake/pmutil.c b/src/soc/intel/alderlake/pmutil.c index 050fd5b..54057380 100644 --- a/src/soc/intel/alderlake/pmutil.c +++ b/src/soc/intel/alderlake/pmutil.c @@ -175,7 +175,7 @@ { const struct chipset_power_state *ps; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC)) return 1; return rtc_failed(ps->gen_pmcon_b); diff --git a/src/soc/intel/apollolake/elog.c b/src/soc/intel/apollolake/elog.c index 03ef816..d7b4cc7 100644 --- a/src/soc/intel/apollolake/elog.c +++ b/src/soc/intel/apollolake/elog.c @@ -88,7 +88,7 @@ { const struct chipset_power_state *ps; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG)) return; /* Power and Reset */ diff --git a/src/soc/intel/apollolake/pmutil.c b/src/soc/intel/apollolake/pmutil.c index 8d9af92..83d2cf2 100644 --- a/src/soc/intel/apollolake/pmutil.c +++ b/src/soc/intel/apollolake/pmutil.c @@ -191,7 +191,7 @@ { const struct chipset_power_state *ps; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC)) return 1; return rtc_failed(ps->gen_pmcon1); diff --git a/src/soc/intel/baytrail/elog.c b/src/soc/intel/baytrail/elog.c index ecdbfca..5868ae4 100644 --- a/src/soc/intel/baytrail/elog.c +++ b/src/soc/intel/baytrail/elog.c @@ -77,7 +77,7 @@ { const struct chipset_power_state *ps; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG)) return; log_power_and_resets(ps); diff --git a/src/soc/intel/baytrail/ramstage.c b/src/soc/intel/baytrail/ramstage.c index 4e8dc68..01044f3 100644 --- a/src/soc/intel/baytrail/ramstage.c +++ b/src/soc/intel/baytrail/ramstage.c @@ -144,9 +144,9 @@ const struct chipset_power_state *ps; struct global_nvs *gnvs; - if (acpi_reset_gnvs_for_wake(&gnvs) < 0) + if (!acpi_reset_gnvs_for_wake(&gnvs)) return; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_WAKE) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_WAKE)) return; pm_fill_gnvs(gnvs, ps); diff --git a/src/soc/intel/braswell/elog.c b/src/soc/intel/braswell/elog.c index ecdbfca..5868ae4 100644 --- a/src/soc/intel/braswell/elog.c +++ b/src/soc/intel/braswell/elog.c @@ -77,7 +77,7 @@ { const struct chipset_power_state *ps; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG)) return; log_power_and_resets(ps); diff --git a/src/soc/intel/broadwell/pch/elog.c b/src/soc/intel/broadwell/pch/elog.c index e3e8c0c..db09c7e 100644 --- a/src/soc/intel/broadwell/pch/elog.c +++ b/src/soc/intel/broadwell/pch/elog.c @@ -107,7 +107,7 @@ { const struct chipset_power_state *ps; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG)) return; /* Power and Reset */ diff --git a/src/soc/intel/broadwell/pch/ramstage.c b/src/soc/intel/broadwell/pch/ramstage.c index 027b3bb..738678d 100644 --- a/src/soc/intel/broadwell/pch/ramstage.c +++ b/src/soc/intel/broadwell/pch/ramstage.c @@ -49,9 +49,9 @@ const struct chipset_power_state *ps; struct global_nvs *gnvs; - if (acpi_reset_gnvs_for_wake(&gnvs) < 0) + if (!acpi_reset_gnvs_for_wake(&gnvs)) return; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_WAKE) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_WAKE)) return; pm_fill_gnvs(gnvs, ps); diff --git a/src/soc/intel/cannonlake/pmutil.c b/src/soc/intel/cannonlake/pmutil.c index ed0aece..ccc6db5 100644 --- a/src/soc/intel/cannonlake/pmutil.c +++ b/src/soc/intel/cannonlake/pmutil.c @@ -168,7 +168,7 @@ { const struct chipset_power_state *ps; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC)) return 1; return rtc_failed(ps->gen_pmcon_b); diff --git a/src/soc/intel/common/block/acpi/acpi_wake_source.c b/src/soc/intel/common/block/acpi/acpi_wake_source.c index d45fd96..6a82f4d 100644 --- a/src/soc/intel/common/block/acpi/acpi_wake_source.c +++ b/src/soc/intel/common/block/acpi/acpi_wake_source.c @@ -52,9 +52,9 @@ const struct chipset_power_state *ps; struct global_nvs *gnvs; - if (acpi_reset_gnvs_for_wake(&gnvs) < 0) + if (!acpi_reset_gnvs_for_wake(&gnvs)) return; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_WAKE) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_WAKE)) return; pm_fill_gnvs(gnvs, ps); diff --git a/src/soc/intel/elkhartlake/pmutil.c b/src/soc/intel/elkhartlake/pmutil.c index 2618798..9c8e2cb 100644 --- a/src/soc/intel/elkhartlake/pmutil.c +++ b/src/soc/intel/elkhartlake/pmutil.c @@ -184,7 +184,7 @@ { const struct chipset_power_state *ps; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC)) return 1; return check_rtc_failed(ps->gen_pmcon_b); diff --git a/src/soc/intel/jasperlake/pmutil.c b/src/soc/intel/jasperlake/pmutil.c index f94232a..c737157 100644 --- a/src/soc/intel/jasperlake/pmutil.c +++ b/src/soc/intel/jasperlake/pmutil.c @@ -184,7 +184,7 @@ { const struct chipset_power_state *ps; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC)) return 1; return check_rtc_failed(ps->gen_pmcon_b); diff --git a/src/soc/intel/meteorlake/pmutil.c b/src/soc/intel/meteorlake/pmutil.c index 09fb46b..9d79516 100644 --- a/src/soc/intel/meteorlake/pmutil.c +++ b/src/soc/intel/meteorlake/pmutil.c @@ -170,7 +170,7 @@ { const struct chipset_power_state *ps; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC)) return 1; return rtc_failed(ps->gen_pmcon_b); diff --git a/src/soc/intel/pantherlake/pmutil.c b/src/soc/intel/pantherlake/pmutil.c index 892972c..e7ff855 100644 --- a/src/soc/intel/pantherlake/pmutil.c +++ b/src/soc/intel/pantherlake/pmutil.c @@ -168,7 +168,7 @@ { const struct chipset_power_state *ps; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC)) return 1; return rtc_failed(ps->gen_pmcon_b); diff --git a/src/soc/intel/skylake/elog.c b/src/soc/intel/skylake/elog.c index 325bacb..9210cfe 100644 --- a/src/soc/intel/skylake/elog.c +++ b/src/soc/intel/skylake/elog.c @@ -232,7 +232,7 @@ { const struct chipset_power_state *ps; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_ELOG)) return; /* Power and Reset */ diff --git a/src/soc/intel/tigerlake/pmutil.c b/src/soc/intel/tigerlake/pmutil.c index ba33e49..c060786 100644 --- a/src/soc/intel/tigerlake/pmutil.c +++ b/src/soc/intel/tigerlake/pmutil.c @@ -189,7 +189,7 @@ { const struct chipset_power_state *ps; - if (acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC) < 0) + if (!acpi_fetch_pm_state(&ps, PS_CLAIMER_RTC)) return 1; return check_rtc_failed(ps->gen_pmcon_b); -- To view, visit https://review.coreboot.org/c/coreboot/+/84914?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I361d4b8827fac25d1849ad68fddc9fdeb4113c0a Gerrit-Change-Number: 84914 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[S] Change in coreboot[main]: commonlib/fsp_relocate: Use boolean instead of int
by Elyes Haouas (Code Review) 29 Oct '24

29 Oct '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84912?usp=email ) Change subject: commonlib/fsp_relocate: Use boolean instead of int ...................................................................... commonlib/fsp_relocate: Use boolean instead of int Moderne C provides boolean, use it instead of old style 0, -1. Change-Id: I3a9cda6148566bca326cb0258611664fb2ca0ee7 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/commonlib/fsp_relocate.c 1 file changed, 15 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/84912/1 diff --git a/src/commonlib/fsp_relocate.c b/src/commonlib/fsp_relocate.c index 0bf50b4..dad5985 100644 --- a/src/commonlib/fsp_relocate.c +++ b/src/commonlib/fsp_relocate.c @@ -5,6 +5,7 @@ #include <commonlib/fsp.h> #include <inttypes.h> #include <commonlib/helpers.h> +#include <stdbool.h> #include <stddef.h> #include <stdint.h> #include <string.h> @@ -158,7 +159,7 @@ return fih; } -static int pe_relocate(uintptr_t new_addr, void *pe, void *fsp, size_t fih_off) +static bool pe_relocate(uintptr_t new_addr, void *pe, void *fsp, size_t fih_off) { EFI_IMAGE_OPTIONAL_HEADER_UNION *peih; EFI_IMAGE_DOS_HEADER *doshdr; @@ -175,14 +176,14 @@ doshdr = pe; if (read_le16(&doshdr->e_magic) != EFI_IMAGE_DOS_SIGNATURE) { printk(BIOS_ERR, "Invalid DOS Header/magic\n"); - return -1; + return false; } peih = relative_offset(pe, doshdr->e_lfanew); if (read_le32(&peih->Pe32.Signature) != EFI_IMAGE_NT_SIGNATURE) { printk(BIOS_ERR, "Invalid PE32 header\n"); - return -1; + return false; } ophdr = &peih->Pe32.OptionalHeader; @@ -194,13 +195,13 @@ ophdr = NULL; } else { printk(BIOS_ERR, "No support for non-PE32/PE32+ images\n"); - return -1; + return false; } fih = fsp_get_info_hdr(fsp, fih_off); if (fih == NULL) { printk(BIOS_ERR, "No Image base found for FSP PE32\n"); - return -1; + return false; } image_base = read_le32(&fih->ImageBase); printk(FSP_DBG_LVL, "FSP InfoHdr Image Base is %" PRIX64"\n", image_base); @@ -266,7 +267,7 @@ default: printk(BIOS_ERR, "Unsupported relocation type %d\n", rtype); - return -1; + return false; } } offset += sizeof(*rdata) * rnum; @@ -279,10 +280,10 @@ else write_le64(&ophdr64->ImageBase, img_base_off); - return 0; + return true; } -static int te_relocate(uintptr_t new_addr, void *te) +static bool te_relocate(uintptr_t new_addr, void *te) { EFI_TE_IMAGE_HEADER *teih; EFI_IMAGE_DATA_DIRECTORY *relocd; @@ -301,7 +302,7 @@ printk(BIOS_ERR, "TE Signature mismatch: %x vs %x\n", read_le16(&teih->Signature), EFI_TE_IMAGE_HEADER_SIGNATURE); - return -1; + return false; } /* @@ -367,7 +368,7 @@ } else if (type != EFI_IMAGE_REL_BASED_ABSOLUTE) { printk(BIOS_ERR, "Unknown reloc type: %x\n", type); - return -1; + return false; } num_relocs--; reloc++; @@ -380,7 +381,7 @@ read_le32(&relocb->SizeOfBlock)); } - return 0; + return true; } static size_t section_data_size(const EFI_COMMON_SECTION_HEADER *csh) @@ -415,7 +416,7 @@ return size; } -static int relocate_patch_table(void *fsp, size_t size, size_t offset, +static bool relocate_patch_table(void *fsp, size_t size, size_t offset, ssize_t adjustment) { struct fsp_patch_table *table; @@ -427,7 +428,7 @@ if ((offset + sizeof(*table) > size) || (read_le16(&table->header_length) + offset) > size) { printk(BIOS_ERR, "FSPP not entirely contained in region.\n"); - return -1; + return false; } num_entries = read_le32(&table->patch_entry_num); @@ -454,7 +455,7 @@ write_le32(reloc, reloc_val + adjustment); } - return 0; + return true; } static ssize_t relocate_remaining_items(void *fsp, size_t size, -- To view, visit https://review.coreboot.org/c/coreboot/+/84912?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3a9cda6148566bca326cb0258611664fb2ca0ee7 Gerrit-Change-Number: 84912 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[M] Change in coreboot[main]: commonlib/device_tree: Use boolean instead of int
by Elyes Haouas (Code Review) 29 Oct '24

29 Oct '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84911?usp=email ) Change subject: commonlib/device_tree: Use boolean instead of int ...................................................................... commonlib/device_tree: Use boolean instead of int Moderne C provides boolean, use it instead of old style 0, -1. Change-Id: Icf938c24d067c9d15faf45b6072e150f0aedfe08 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/commonlib/device_tree.c M src/commonlib/include/commonlib/device_tree.h 2 files changed, 43 insertions(+), 43 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/84911/1 diff --git a/src/commonlib/device_tree.c b/src/commonlib/device_tree.c index cb7a596..49c6dee 100644 --- a/src/commonlib/device_tree.c +++ b/src/commonlib/device_tree.c @@ -1679,9 +1679,9 @@ * @param node Root node of the /__local_fixup__ subtree. * @param base Adjustment that was added to phandles in the overlay. * - * @return 0 on success, -1 on error. + * @return true on success, false on error. */ -static int dt_fixup_locals(struct device_tree_node *node, +static bool dt_fixup_locals(struct device_tree_node *node, struct device_tree_node *fixup, uint32_t base) { struct device_tree_property *prop; @@ -1708,12 +1708,12 @@ /* We should always find a corresponding base prop for a fixup, and fixup props contain a list of 32-bit fixup offsets. */ if (!base_prop || fixup_prop->prop.size % sizeof(uint32_t)) - return -1; + return false; for (i = 0; i < fixup_prop->prop.size; i += sizeof(uint32_t)) if (!dt_adjust_phandle(base_prop, base, be32dec( fixup_prop->prop.data + i))) - return -1; + return false; } /* Now recursively descend both the base tree and the /__local_fixups__ @@ -1728,13 +1728,13 @@ /* All fixup nodes should have a corresponding base node. */ if (!base_child) - return -1; + return false; - if (dt_fixup_locals(base_child, fixup_child, base) < 0) - return -1; + if (!dt_fixup_locals(base_child, fixup_child, base)) + return false; } - return 0; + return true; } /* @@ -1778,9 +1778,9 @@ * @params base_path Path to the base DT node that the fixup points to. * @params overlay_symbols /__symbols__ node of the overlay. * - * @return 0 on success, -1 on error. + * @return true on success, false on error. */ -static int dt_fixup_external(struct device_tree *overlay, +static bool dt_fixup_external(struct device_tree *overlay, struct device_tree_property *fixup, uint32_t phandle, const char *base_path, struct device_tree_node *overlay_symbols) @@ -1794,19 +1794,19 @@ char *node_path = entry; entry = strchr(node_path, ':'); if (!entry) - return -1; + return false; *entry++ = '\0'; char *prop_name = entry; entry = strchr(prop_name, ':'); if (!entry) - return -1; + return false; *entry++ = '\0'; struct device_tree_node *ovl_node = dt_find_node_by_path( overlay, node_path, NULL, NULL, 0); if (!ovl_node || !isdigit(*entry)) - return -1; + return false; struct device_tree_property *ovl_prop = NULL; list_for_each(prop, ovl_node->properties, list_node) @@ -1818,7 +1818,7 @@ /* Move entry to first char after number, must be a '\0'. */ uint32_t offset = skip_atoi(&entry); if (!ovl_prop || offset + 4 > ovl_prop->prop.size || entry[0]) - return -1; + return false; entry++; /* jump over '\0' to potential next fixup */ be32enc(ovl_prop->prop.data + offset, phandle); @@ -1830,7 +1830,7 @@ dt_fix_symbols(overlay_symbols, ovl_node, base_path); } - return 0; + return true; } /* @@ -1843,9 +1843,9 @@ * @params fixups /__fixup__ node in the overlay. * @params overlay_symbols /__symbols__ node of the overlay. * - * @return 0 on success, -1 on error. + * @return true on success, false on error. */ -static int dt_fixup_all_externals(struct device_tree *tree, +static bool dt_fixup_all_externals(struct device_tree *tree, struct device_tree_node *symbols, struct device_tree *overlay, struct device_tree_node *fixups, @@ -1855,7 +1855,7 @@ /* If we have any external fixups, base tree must have /__symbols__. */ if (!symbols) - return -1; + return false; /* * Unlike /__local_fixups__, /__fixups__ is not a whole subtree that @@ -1867,21 +1867,21 @@ a property to phandle-reference. Look up in /__symbols__. */ const char *path = dt_find_string_prop(symbols, fix->prop.name); if (!path) - return -1; + return false; /* Find node the label pointed to figure out its phandle. */ struct device_tree_node *node = dt_find_node_by_path(tree, path, NULL, NULL, 0); if (!node) - return -1; + return false; /* Write into the overlay property(s) pointing to that node. */ - if (dt_fixup_external(overlay, fix, node->phandle, - path, overlay_symbols) < 0) - return -1; + if (!dt_fixup_external(overlay, fix, node->phandle, + path, overlay_symbols)) + return false; } - return 0; + return true; } /* @@ -1956,9 +1956,9 @@ * @param fragment /fragment@X node. * @params overlay_symbols /__symbols__ node of the overlay. * - * @return 0 on success, -1 on error. + * @return true on success, false on error. */ -static int dt_import_fragment(struct device_tree *tree, +static bool dt_import_fragment(struct device_tree *tree, struct device_tree_node *fragment, struct device_tree_node *overlay_symbols) { @@ -1969,7 +1969,7 @@ /* If it doesn't have an __overlay__ child, it's not a fragment. */ if (!overlay) - return 0; + return true; /* Target node of the fragment can be given by path or by phandle. */ struct device_tree_property *prop; @@ -1987,7 +1987,7 @@ struct device_tree_node *target = NULL; if (phandle) { if (phandle->prop.size != sizeof(uint32_t)) - return -1; + return false; target = dt_find_node_by_phandle(tree->root, be32dec(phandle->prop.data)); /* Symbols already updated as part of dt_fixup_external(). */ @@ -1997,10 +1997,10 @@ dt_fix_symbols(overlay_symbols, fragment, path->prop.data); } if (!target) - return -1; + return false; dt_copy_subtree(target, overlay, 1); - return 0; + return true; } /* @@ -2011,9 +2011,9 @@ * @param tree Unflattened base device tree to add the overlay into. * @param overlay Unflattened overlay device tree to apply to the base. * - * @return 0 on success, -1 on error. + * @return true on success, false on error. */ -int dt_apply_overlay(struct device_tree *tree, struct device_tree *overlay) +bool dt_apply_overlay(struct device_tree *tree, struct device_tree *overlay) { /* * First, we need to make sure phandles inside the overlay don't clash @@ -2025,7 +2025,7 @@ uint32_t new_max = dt_adjust_all_phandles(overlay->root, phandle_base); if (!new_max) { printk(BIOS_ERR, "invalid phandles in overlay\n"); - return -1; + return false; } tree->max_phandle = new_max; @@ -2033,10 +2033,10 @@ nodes referring to them. Those are listed in /__local_fixups__. */ struct device_tree_node *local_fixups = dt_find_node_by_path(overlay, "/__local_fixups__", NULL, NULL, 0); - if (local_fixups && dt_fixup_locals(overlay->root, local_fixups, - phandle_base) < 0) { + if (local_fixups && !dt_fixup_locals(overlay->root, local_fixups, + phandle_base)) { printk(BIOS_ERR, "invalid local fixups in overlay\n"); - return -1; + return false; } /* @@ -2057,20 +2057,20 @@ "/__fixups__", NULL, NULL, 0); struct device_tree_node *overlay_symbols = dt_find_node_by_path(overlay, "/__symbols__", NULL, NULL, 0); - if (fixups && dt_fixup_all_externals(tree, symbols, overlay, - fixups, overlay_symbols) < 0) { + if (fixups && !dt_fixup_all_externals(tree, symbols, overlay, + fixups, overlay_symbols)) { printk(BIOS_ERR, "cannot match external fixups from overlay\n"); - return -1; + return false; } /* After all this fixing up, we can finally merge overlay into the tree (one fragment at a time, because for some reason it's split up). */ struct device_tree_node *fragment; list_for_each(fragment, overlay->root->children, list_node) - if (dt_import_fragment(tree, fragment, overlay_symbols) < 0) { + if (!dt_import_fragment(tree, fragment, overlay_symbols)) { printk(BIOS_ERR, "bad DT fragment '%s'\n", fragment->name); - return -1; + return false; } /* @@ -2088,5 +2088,5 @@ &tree->root->children); } - return 0; + return true; } diff --git a/src/commonlib/include/commonlib/device_tree.h b/src/commonlib/include/commonlib/device_tree.h index c15d7ae..a2a5009 100644 --- a/src/commonlib/include/commonlib/device_tree.h +++ b/src/commonlib/include/commonlib/device_tree.h @@ -198,7 +198,7 @@ /* Apply an overlay to a base device tree. Ownership of the overlay data passes to the newly combined base tree -- do not free() or access it afterwards! */ -int dt_apply_overlay(struct device_tree *tree, struct device_tree *overlay); +bool dt_apply_overlay(struct device_tree *tree, struct device_tree *overlay); /* * Fixups to apply to a kernel's device tree before booting it. -- To view, visit https://review.coreboot.org/c/coreboot/+/84911?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icf938c24d067c9d15faf45b6072e150f0aedfe08 Gerrit-Change-Number: 84911 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/riven: Configure Acoustic noise mitigation
by David Wu (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Nick Vaccaro, Paul Menzel. David Wu has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/84908?usp=email ) Change subject: mb/google/nissa/var/riven: Configure Acoustic noise mitigation ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84908/comment/d69029e3_0290646f?us… : PS3, Line 8: > Maybe add: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84908?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia71985ef21d634763fc5ae22e4f611f7f5e9652a Gerrit-Change-Number: 84908 Gerrit-PatchSet: 4 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 29 Oct 2024 13:34:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/riven: Configure Acoustic noise mitigation
by David Wu (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: David Wu, Dinesh Gehlot, Jayvik Desai, Nick Vaccaro. Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84908?usp=email to look at the new patch set (#4). Change subject: mb/google/nissa/var/riven: Configure Acoustic noise mitigation ...................................................................... mb/google/nissa/var/riven: Configure Acoustic noise mitigation Follow the power team’s recommendation: - Enable Acoustic noise mitigation - Set slow slew rate VCCIA and VCCGT to SLEW_FAST_4 - Set FastPkgCRampDisable VCCIA and VCCGT to 1 BUG=b:376165743 TEST=built firmware and verified by power team, the acoustic noise can be improved a lot. Change-Id: Ia71985ef21d634763fc5ae22e4f611f7f5e9652a Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/riven/overridetree.cb 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/84908/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/84908?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia71985ef21d634763fc5ae22e4f611f7f5e9652a Gerrit-Change-Number: 84908 Gerrit-PatchSet: 4 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[XS] Change in coreboot[main]: tests: Build test using C23
by Elyes Haouas (Code Review) 29 Oct '24

29 Oct '24

Attention is currently required from: Felix Singer, Jakub Czapiga, Martin L Roth. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84890?usp=email ) Change subject: tests: Build test using C23 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: what is gcc version used by Jenkins ?? -- To view, visit https://review.coreboot.org/c/coreboot/+/84890?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iefa80b6ba2fdfa91eb23b854f79ea95abf3ec2e1 Gerrit-Change-Number: 84890 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Comment-Date: Tue, 29 Oct 2024 13:32:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2024