Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
David Wu has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/84922?usp=email )
Change subject: mb/google/nissa/var/riven: Increase the VccIn Aux Imon IccMax to 30A
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84922/comment/bfab3772_591167e2?us… :
PS2, Line 7: Update
> Increase
Done
https://review.coreboot.org/c/coreboot/+/84922/comment/3220f83d_41fe002a?us… :
PS2, Line 9: update
> increase
Done
https://review.coreboot.org/c/coreboot/+/84922/comment/d37df2af_0be00bbd?us… :
PS2, Line 13: check
> Please give the command or paste the log line.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/84922?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I71020c2f631cb517a52d4bb65e35277eb731ced7
Gerrit-Change-Number: 84922
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Wed, 30 Oct 2024 05:55:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: David Wu, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84922?usp=email
to look at the new patch set (#3).
Change subject: mb/google/nissa/var/riven: Increase the VccIn Aux Imon IccMax to 30A
......................................................................
mb/google/nissa/var/riven: Increase the VccIn Aux Imon IccMax to 30A
From power team's recommendation, increase the VccIn Aux Imon IccMax
to 30A to meet HW settings.
BUG=b:376306118
TEST=Build firmware and check the value is changing as expected.
Paste the firmware log.
[SPEW ] VccInAuxImonIccImax= 0x78
[SPEW ] (MAILBOX) VccInAuxImonIccImax = 120 (1/4 Amp)
[INFO ] Override VccInAuxImonIccImax = 120
Change-Id: I71020c2f631cb517a52d4bb65e35277eb731ced7
Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/riven/ramstage.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/84922/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/84922?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I71020c2f631cb517a52d4bb65e35277eb731ced7
Gerrit-Change-Number: 84922
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Attention is currently required from: Pranava Y N, Subrata Banik.
Paul Menzel has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84919?usp=email )
Change subject: mb/google/fatcat: Adjust EC host command range for Fatcat
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84919/comment/3ee7fcc7_bc449745?us… :
PS1, Line 7: mb/google/fatcat: Adjust EC host command range for Fatcat
… for microchip EC
https://review.coreboot.org/c/coreboot/+/84919/comment/7b0bee17_59702f4d?us… :
PS1, Line 7: for Fatcat
redundant
--
To view, visit https://review.coreboot.org/c/coreboot/+/84919?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifcee533341fa583d841a4b564f25831c6d04e951
Gerrit-Change-Number: 84919
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Wed, 30 Oct 2024 05:14:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Paul Menzel has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/84922?usp=email )
Change subject: mb/google/nissa/var/riven: Update the VccIn Aux Imon IccMax to 30A
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84922/comment/c4ab6ade_7eeb579b?us… :
PS2, Line 7: Update
Increase
https://review.coreboot.org/c/coreboot/+/84922/comment/349274ef_79bb1cac?us… :
PS2, Line 9: update
increase
https://review.coreboot.org/c/coreboot/+/84922/comment/b8c8bbb6_4d524768?us… :
PS2, Line 13: check
Please give the command or paste the log line.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84922?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I71020c2f631cb517a52d4bb65e35277eb731ced7
Gerrit-Change-Number: 84922
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Wed, 30 Oct 2024 04:55:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84922?usp=email
to look at the new patch set (#2).
Change subject: mb/google/nissa/var/riven: Update the VccIn Aux Imon IccMax to 30A
......................................................................
mb/google/nissa/var/riven: Update the VccIn Aux Imon IccMax to 30A
From power team's recommendation, update the VccIn Aux Imon IccMax
to 30A to meet HW settings.
BUG=b:376306118
TEST=Build firmware and check the value is changing as expected.
Change-Id: I71020c2f631cb517a52d4bb65e35277eb731ced7
Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/riven/ramstage.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/84922/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84922?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I71020c2f631cb517a52d4bb65e35277eb731ced7
Gerrit-Change-Number: 84922
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84922?usp=email )
Change subject: mb/google/nissa/var/riven: Update the VccInAuxImonIccImax to 30A
......................................................................
mb/google/nissa/var/riven: Update the VccInAuxImonIccImax to 30A
From power team's recommendation, update the VccInAuxImonIccImax to 30A
to meet HW settings.
BUG=b:376306118
TEST=Build firmware and check the value is changing as expected.
Change-Id: I71020c2f631cb517a52d4bb65e35277eb731ced7
Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/riven/ramstage.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/84922/1
diff --git a/src/mainboard/google/brya/variants/riven/ramstage.c b/src/mainboard/google/brya/variants/riven/ramstage.c
index 5ed9a37f..90517bd 100644
--- a/src/mainboard/google/brya/variants/riven/ramstage.c
+++ b/src/mainboard/google/brya/variants/riven/ramstage.c
@@ -7,6 +7,6 @@
{
/* Refer to FSP Silicon (soc/intel/alderlake/fsp_params.c)
VccIn Aux Imon IccMax. Values are in 1/4 Amp increments */
- params->VccInAuxImonIccImax = 100; /* 25000(25A) * 4 / 1000 */
+ params->VccInAuxImonIccImax = 120; /* 30000(30A) * 4 / 1000 */
printk(BIOS_INFO, "Override VccInAuxImonIccImax = %d\n", params->VccInAuxImonIccImax);
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/84922?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I71020c2f631cb517a52d4bb65e35277eb731ced7
Gerrit-Change-Number: 84922
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Attention is currently required from: Pranava Y N, Subrata Banik.
Vijay P Hiremath has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84919?usp=email )
Change subject: mb/google/fatcat: Adjust EC host command range for Fatcat
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/84919/comment/f45a739c_ff894244?us… :
PS1, Line 8: 0x807
> ACK
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/84919?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifcee533341fa583d841a4b564f25831c6d04e951
Gerrit-Change-Number: 84919
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Wed, 30 Oct 2024 03:57:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: Pranava Y N, Subrata Banik.
Vijay P Hiremath has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84919?usp=email )
Change subject: mb/google/fatcat: Adjust EC host command range for Fatcat
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/84919/comment/d5c5a5dd_16b526b2?us… :
PS1, Line 8: 0x807
> > Hi Subrata, it is 0x800 to 0x9ff […]
ACK
--
To view, visit https://review.coreboot.org/c/coreboot/+/84919?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifcee533341fa583d841a4b564f25831c6d04e951
Gerrit-Change-Number: 84919
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Wed, 30 Oct 2024 03:57:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: Pranava Y N, Vijay P Hiremath.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84919?usp=email )
Change subject: mb/google/fatcat: Adjust EC host command range for Fatcat
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/84919/comment/3ac3e21e_956ae939?us… :
PS1, Line 8: 0x807
> Hi Subrata, it is 0x800 to 0x9ff
> Let me check with Microchip if this is changed
generally we can only block 256 bytes in one range hence, 0x800 to 0x9ff can't be blocked at once. Gen2 is used to block 900-9ff.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84919?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifcee533341fa583d841a4b564f25831c6d04e951
Gerrit-Change-Number: 84919
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-CC: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Gerrit-Attention: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Wed, 30 Oct 2024 03:51:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>