coreboot-gerrit September 2023

coreboot-gerrit@coreboot.org

1 participants
3824 discussions

[S] Change in coreboot[master]: google/puff: remove workaround that toggled the #ISOLATE pin
by Martin L Roth (Code Review) 01 Sep '23

01 Sep '23

Attention is currently required from: Alexis Savery, Caveh Jalali, Edward O'Callaghan, Nick Vaccaro, Paul Menzel. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77378?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: google/puff: remove workaround that toggled the #ISOLATE pin ...................................................................... Patch Set 7: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/77378/comment/0ed47aaa_368c9f74 : PS7, Line 19: this change to the firmware on a device running 4.19 causes suspend/resume failures, basically reversing the problem. We are upreving the puff kernel to 5.15 so we need this patch, but since : it is incompatible with 4.19 we will have to take that into consideration when pushing new firmware and potentially will need Please wrap -- To view, visit https://review.coreboot.org/c/coreboot/+/77378?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5eead2d70cd9528b3ca3fadd11f98c0330601324 Gerrit-Change-Number: 77378 Gerrit-PatchSet: 7 Gerrit-Owner: Alexis Savery <asavery(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Alexis Savery <asavery(a)chromium.org> Gerrit-Comment-Date: Fri, 01 Sep 2023 21:02:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: include/input-event-codes.h: Update to upstream
by Martin L Roth (Code Review) 01 Sep '23

01 Sep '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69675?usp=email ) Change subject: include/input-event-codes.h: Update to upstream ...................................................................... include/input-event-codes.h: Update to upstream This update 'input-event-codes.h' file to master branch. Change-Id: I09839886824868cfaff6127fe44ff02d7e21ba42 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69675 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M src/include/input-event-codes.h 1 file changed, 33 insertions(+), 3 deletions(-) Approvals: Martin L Roth: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/include/input-event-codes.h b/src/include/input-event-codes.h index abb1e08..ff72a45 100644 --- a/src/include/input-event-codes.h +++ b/src/include/input-event-codes.h @@ -3,7 +3,7 @@ * from input maintainer's tree: * git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git * from master branch - * at SHA: fbf66796a0aedbaea248c7ade1459ccd0dd4cb44 + * at SHA: 1260cd04a601e0e02e09fa332111b8639611970d */ /* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */ @@ -286,7 +286,8 @@ #define KEY_PAUSECD 201 #define KEY_PROG3 202 #define KEY_PROG4 203 -#define KEY_DASHBOARD 204 /* AL Dashboard */ +#define KEY_ALL_APPLICATIONS 204 /* AC Desktop Show All Applications */ +#define KEY_DASHBOARD KEY_ALL_APPLICATIONS #define KEY_SUSPEND 205 #define KEY_CLOSE 206 /* AC Close */ #define KEY_PLAY 207 @@ -523,6 +524,9 @@ #define KEY_10CHANNELSUP 0x1b8 /* 10 channels up (10+) */ #define KEY_10CHANNELSDOWN 0x1b9 /* 10 channels down (10-) */ #define KEY_IMAGES 0x1ba /* AL Image Browser */ +#define KEY_NOTIFICATION_CENTER 0x1bc /* Show/hide the notification center */ +#define KEY_PICKUP_PHONE 0x1bd /* Answer incoming call */ +#define KEY_HANGUP_PHONE 0x1be /* Decline incoming call */ #define KEY_DEL_EOL 0x1c0 #define KEY_DEL_EOS 0x1c1 @@ -550,6 +554,7 @@ #define KEY_FN_F 0x1e2 #define KEY_FN_S 0x1e3 #define KEY_FN_B 0x1e4 +#define KEY_FN_RIGHT_SHIFT 0x1e5 #define KEY_BRL_DOT1 0x1f1 #define KEY_BRL_DOT2 0x1f2 @@ -615,6 +620,8 @@ #define KEY_VOICECOMMAND 0x246 /* Listening Voice Command */ #define KEY_ASSISTANT 0x247 /* AL Context-aware desktop assistant */ #define KEY_KBD_LAYOUT_NEXT 0x248 /* AC Next Keyboard Layout Select */ +#define KEY_EMOJI_PICKER 0x249 /* Show/hide emoji picker (HUTRR101) */ +#define KEY_DICTATE 0x24a /* Start or Stop Voice Dictation Session (HUTRR99) */ #define KEY_BRIGHTNESS_MIN 0x250 /* Set Brightness to Minimum */ #define KEY_BRIGHTNESS_MAX 0x251 /* Set Brightness to Maximum */ @@ -663,6 +670,27 @@ /* Select an area of screen to be copied */ #define KEY_SELECTIVE_SCREENSHOT 0x27a +/* Move the focus to the next or previous user controllable element within a UI container */ +#define KEY_NEXT_ELEMENT 0x27b +#define KEY_PREVIOUS_ELEMENT 0x27c + +/* Toggle Autopilot engagement */ +#define KEY_AUTOPILOT_ENGAGE_TOGGLE 0x27d + +/* Shortcut Keys */ +#define KEY_MARK_WAYPOINT 0x27e +#define KEY_SOS 0x27f +#define KEY_NAV_CHART 0x280 +#define KEY_FISHING_CHART 0x281 +#define KEY_SINGLE_RANGE_RADAR 0x282 +#define KEY_DUAL_RANGE_RADAR 0x283 +#define KEY_RADAR_OVERLAY 0x284 +#define KEY_TRADITIONAL_SONAR 0x285 +#define KEY_CLEARVU_SONAR 0x286 +#define KEY_SIDEVU_SONAR 0x287 +#define KEY_NAV_INFO 0x288 +#define KEY_BRIGHTNESS_MENU 0x289 + /* * Some keyboards have keys which do not have a defined meaning, these keys * are intended to be programmed / bound to macros by the user. For most @@ -842,6 +870,7 @@ #define ABS_TOOL_WIDTH 0x1c #define ABS_VOLUME 0x20 +#define ABS_PROFILE 0x21 #define ABS_MISC 0x28 @@ -895,7 +924,8 @@ #define SW_LINEIN_INSERT 0x0d /* set = inserted */ #define SW_MUTE_DEVICE 0x0e /* set = device disabled */ #define SW_PEN_INSERTED 0x0f /* set = pen inserted */ -#define SW_MAX 0x0f +#define SW_MACHINE_COVER 0x10 /* set = cover closed */ +#define SW_MAX 0x10 #define SW_CNT (SW_MAX+1) /* -- To view, visit https://review.coreboot.org/c/coreboot/+/69675?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09839886824868cfaff6127fe44ff02d7e21ba42 Gerrit-Change-Number: 69675 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: mb/starlabs/starbook/rpl: Disable dynamic Tc-cold handshake
by Martin L Roth (Code Review) 01 Sep '23

01 Sep '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77564?usp=email ) Change subject: mb/starlabs/starbook/rpl: Disable dynamic Tc-cold handshake ...................................................................... mb/starlabs/starbook/rpl: Disable dynamic Tc-cold handshake With the Tc-cold handshake, there's a fast flicker when connecting external displays. With it disabled, it's just one "flick", so use this as it's lesser of two evils. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ie42b935d3e69beff6a1e503a8dee69554123b4f0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/77564 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index 7a9fd3c..02d3c7b 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -9,6 +9,8 @@ register "cnvi_bt_core" = "1" register "cnvi_bt_audio_offload" = "1" + register "disable_dynamic_tccold_handshake" = "1" + # Serial I/O register "serial_io_i2c_mode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci, -- To view, visit https://review.coreboot.org/c/coreboot/+/77564?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie42b935d3e69beff6a1e503a8dee69554123b4f0 Gerrit-Change-Number: 77564 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: soc/intel/meteorlake: Fix black screen after booting to OS
by Nick Vaccaro (Code Review) 01 Sep '23

01 Sep '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77611?usp=email ) Change subject: soc/intel/meteorlake: Fix black screen after booting to OS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/77611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8908e8b6c995390b559212d456db6ddf984448a3 Gerrit-Change-Number: 77611 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Fri, 01 Sep 2023 20:16:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/meteorlake: Fix black screen after booting to OS
by Eran Mitrani (Code Review) 01 Sep '23

01 Sep '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun. Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77611?usp=email ) Change subject: soc/intel/meteorlake: Fix black screen after booting to OS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/77611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8908e8b6c995390b559212d456db6ddf984448a3 Gerrit-Change-Number: 77611 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Fri, 01 Sep 2023 20:00:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/meteorlake: Fix black screen after booting to OS
by Subrata Banik (Code Review) 01 Sep '23

01 Sep '23

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/77611?usp=email ) Change subject: soc/intel/meteorlake: Fix black screen after booting to OS ...................................................................... soc/intel/meteorlake: Fix black screen after booting to OS This patch ensures that the VR configuration for IA, SA, and GFX is properly initialized, assigning zero values to VR causes a black screen (no display) issue. Problem Statement: Override CEP (Current Excursion Protection) value with zero aka set to disable results into black screen issue (no display). Solution: Keep CEP default enabled and don't override w/ zero value. w/o this patch: [SPEW ] CPU_POWER_MGMT_VR_CONFIG : CepEnable[0] : 0x0 [SPEW ] CPU_POWER_MGMT_VR_CONFIG : CepEnable[1] : 0x0 [SPEW ] CPU_POWER_MGMT_VR_CONFIG : CepEnable[2] : 0x0 w/ this patch: [SPEW ] CPU_POWER_MGMT_VR_CONFIG : CepEnable[0] : 0x1 [SPEW ] CPU_POWER_MGMT_VR_CONFIG : CepEnable[1] : 0x1 [SPEW ] CPU_POWER_MGMT_VR_CONFIG : CepEnable[2] : 0x1 Change-Id: I8908e8b6c995390b559212d456db6ddf984448a3 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/soc/intel/meteorlake/romstage/fsp_params.c 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/77611/1 diff --git a/src/soc/intel/meteorlake/romstage/fsp_params.c b/src/soc/intel/meteorlake/romstage/fsp_params.c index bb5b6e7..36aa11e 100644 --- a/src/soc/intel/meteorlake/romstage/fsp_params.c +++ b/src/soc/intel/meteorlake/romstage/fsp_params.c @@ -229,11 +229,12 @@ { /* FastVmode Settings for VR domains */ for (size_t domain = 0; domain < NUM_VR_DOMAINS; domain++) { - m_cfg->CepEnable[domain] = config->cep_enable[domain]; - if (m_cfg->CepEnable[domain]) { - m_cfg->EnableFastVmode[domain] = config->enable_fast_vmode[domain]; - if (m_cfg->EnableFastVmode[domain]) + if (config->cep_enable[domain]) { + m_cfg->CepEnable[domain] = config->cep_enable[domain]; + if (config->enable_fast_vmode[domain]) { + m_cfg->EnableFastVmode[domain] = config->enable_fast_vmode[domain]; m_cfg->IccLimit[domain] = config->fast_vmode_i_trip[domain]; + } } } } -- To view, visit https://review.coreboot.org/c/coreboot/+/77611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8908e8b6c995390b559212d456db6ddf984448a3 Gerrit-Change-Number: 77611 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: util/crossgcc: Update GMP from 6.2.1 to 6.3.0
by 9elements QA (Code Review) 01 Sep '23

01 Sep '23

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76865?usp=email ) Change subject: util/crossgcc: Update GMP from 6.2.1 to 6.3.0 ...................................................................... Patch Set 4: Automatic boot test returned (PASS/FAIL/TOTAL): 14 / 1 / 15 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/182476 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/182474 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/182473 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/182472 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/182471 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/182470 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/182469 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/182468 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/182466 FAIL: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/182465 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/182464 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/182463 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/182462 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/182461 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/182460 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/76865?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67d443cb15d89482b20b01f4068502b16ac8fc8e Gerrit-Change-Number: 76865 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Fri, 01 Sep 2023 18:33:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/common/block: Share Intel Graphics Device init function
by Jérémy Compostella (Code Review) 01 Sep '23

01 Sep '23

Jérémy Compostella has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/77229?usp=email ) Change subject: soc/intel/common/block: Share Intel Graphics Device init function ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/77229?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8197a2baffe45eadceeb0ac349cde8ae2a9b41a0 Gerrit-Change-Number: 77229 Gerrit-PatchSet: 3 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: soc/intel/mtl: Load eDP PHY firmware for early graphics support
by Jérémy Compostella (Code Review) 01 Sep '23

01 Sep '23

Attention is currently required from: Anil Kumar K, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun. Jérémy Compostella has uploaded a new patch set (#3) to the change originally created by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/77543?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/intel/mtl: Load eDP PHY firmware for early graphics support ...................................................................... soc/intel/mtl: Load eDP PHY firmware for early graphics support To enable graphics in pre-memory stage on Meteor Lake, EDP PHY firmware has to be explicitly loaded early enough. This patch adds support for BUP_COMMON_LOAD_EDP_PHY HECI command when text needs to be displayed in pre-memory stage. Change-Id: I2ccc294784b2879e601d92040c8c3b0e1f4bf024 Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> --- M src/soc/intel/meteorlake/Kconfig M src/soc/intel/meteorlake/romstage/ux.c 2 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/77543/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/77543?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ccc294784b2879e601d92040c8c3b0e1f4bf024 Gerrit-Change-Number: 77543 Gerrit-PatchSet: 3 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/cmn/cse: Add support for BUP_COMMON_LOAD_EDP_PHY command
by Jérémy Compostella (Code Review) 01 Sep '23

01 Sep '23

Attention is currently required from: Anil Kumar K, Jérémy Compostella. Jérémy Compostella has uploaded a new patch set (#6) to the change originally created by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/77110?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/intel/cmn/cse: Add support for BUP_COMMON_LOAD_EDP_PHY command ...................................................................... soc/intel/cmn/cse: Add support for BUP_COMMON_LOAD_EDP_PHY command To enable graphics in pre-memory stage, eDP PHY firmware has to be explicitly loaded early enough on certain SOCs. This patch adds support for BUP_COMMON_LOAD_EDP_PHY HECI command to inform CSE to load EDP PHY firmware. Change-Id: Ia18b895b2b4247266140670024cc0d27852efe42 Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com> --- M src/soc/intel/common/block/cse/Kconfig M src/soc/intel/common/block/cse/cse_lite.c M src/soc/intel/common/block/include/intelblocks/cse.h 3 files changed, 54 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/77110/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/77110?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia18b895b2b4247266140670024cc0d27852efe42 Gerrit-Change-Number: 77110 Gerrit-PatchSet: 6 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2023