coreboot-gerrit September 2023

coreboot-gerrit@coreboot.org

1 participants
3824 discussions

[XS] Change in coreboot[master]: soc/intel/xeon_sp: Use MRC_STASH_TO_CBMEM config
by Subrata Banik (Code Review) 02 Sep '23

02 Sep '23

Subrata Banik has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/77557?usp=email ) Change subject: soc/intel/xeon_sp: Use MRC_STASH_TO_CBMEM config ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/77557?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6275fbc0546468f36baee73691a285092e857e0a Gerrit-Change-Number: 77557 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: drivers/intel/fsp2_0: Remove unused save_mrc_data implementation
by Subrata Banik (Code Review) 02 Sep '23

02 Sep '23

Subrata Banik has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/77295?usp=email ) Change subject: drivers/intel/fsp2_0: Remove unused save_mrc_data implementation ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/77295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic03f864a719dd91bc95157316fa03148e493f6d7 Gerrit-Change-Number: 77295 Gerrit-PatchSet: 11 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[master]: commonlib: Drop unused CBMEM IDs due to unified MRC cache store logic
by Subrata Banik (Code Review) 02 Sep '23

02 Sep '23

Subrata Banik has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/77595?usp=email ) Change subject: commonlib: Drop unused CBMEM IDs due to unified MRC cache store logic ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/77595?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f2a5427e481c3fa326adb30d2f37d4091ec985a Gerrit-Change-Number: 77595 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: Documentation: Remove unused build targets
by Martin L Roth (Code Review) 02 Sep '23

02 Sep '23

Attention is currently required from: Felix Singer, Nicholas Chin. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77439?usp=email ) Change subject: Documentation: Remove unused build targets ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: We might want to delete the .tex files as well if we're removing support for building them. Maybe we should see if there's still anything useful in them and turn them into markdown files? Or not. Up to you how we want to handle it. Let me know if you want me to look at changing them to markdown. File Documentation/Makefile: https://review.coreboot.org/c/coreboot/+/77439/comment/40287e9c_4e134370 : PS3, Line 35: Equal to sphinx target I might just say "Builds all documentation" so it doesn't need to be updated if we add anything else. -- To view, visit https://review.coreboot.org/c/coreboot/+/77439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7df8ea886f94d9b25e8eeb0ccbc2a7392b96a575 Gerrit-Change-Number: 77439 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sat, 02 Sep 2023 16:41:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: amdfwtool: Add FW type FUSE_CHAIN in the config file
by Martin L Roth (Code Review) 02 Sep '23

02 Sep '23

Attention is currently required from: Bao Zheng, Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel, Varshit Pandya, Zheng Bao. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77506?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: amdfwtool: Add FW type FUSE_CHAIN in the config file ...................................................................... Patch Set 2: (1 comment) File src/soc/amd/common/Makefile.inc: https://review.coreboot.org/c/coreboot/+/77506/comment/d01c0ada_69b2a615 : PS2, Line 26: FIRMWARE_LOCATION, or SOC_NAME Add AMD_FUSE_CHAIN here? -- To view, visit https://review.coreboot.org/c/coreboot/+/77506?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb546f761ae10b0d19a9879a9a644b788828d523 Gerrit-Change-Number: 77506 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Sat, 02 Sep 2023 16:34:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex/var/karis: Drop unused audio codecs and amplifiers
by Martin L Roth (Code Review) 02 Sep '23

02 Sep '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77602?usp=email ) Change subject: mb/google/rex/var/karis: Drop unused audio codecs and amplifiers ...................................................................... mb/google/rex/var/karis: Drop unused audio codecs and amplifiers BUG=b:294155897, b:295112765 TEST=emerge-rex coreboot Change-Id: Ic7e272a484ea76dfc3a314b3597cbc18c856a9ca Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/77602 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/rex/Kconfig M src/mainboard/google/rex/variants/karis/overridetree.cb 2 files changed, 1 insertion(+), 67 deletions(-) Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index b289408..7d384bd 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -72,10 +72,6 @@ config BOARD_GOOGLE_MODEL_KARIS def_bool n select BOARD_GOOGLE_BASEBOARD_REX - select DRIVERS_GENERIC_MAX98357A - select DRIVERS_INTEL_SOUNDWIRE - select DRIVERS_SOUNDWIRE_CS42L42 - select DRIVERS_SOUNDWIRE_MAX98363 config BOARD_GOOGLE_BASEBOARD_OVIS def_bool n diff --git a/src/mainboard/google/rex/variants/karis/overridetree.cb b/src/mainboard/google/rex/variants/karis/overridetree.cb index 42106da..6ff22d2 100644 --- a/src/mainboard/google/rex/variants/karis/overridetree.cb +++ b/src/mainboard/google/rex/variants/karis/overridetree.cb @@ -1,9 +1,4 @@ fw_config - field AUDIO 0 3 - option AUDIO_UNKNOWN 0 - option MAX98360_ALC5682I_I2S 1 - option MAX98363_CS42L42_SNDW 2 - end field DB_USB 12 14 option USB_UNKNOWN 0 option USB3_PS8815 1 @@ -362,20 +357,6 @@ end device ref i2c0 on chip drivers/i2c/generic - register "hid" = ""RTL5682"" - register "name" = ""RT58"" - register "desc" = ""Headset Codec"" - register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_B06)" - # Set the jd_src to RT5668_JD1 for jack detection - register "property_count" = "1" - register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" - register "property_list[0].name" = ""realtek,jd-src"" - register "property_list[0].integer" = "1" - device i2c 1a on - probe AUDIO MAX98360_ALC5682I_I2S - end - end - chip drivers/i2c/generic register "hid" = ""10EC5650"" register "name" = ""RT58"" register "desc" = ""Realtek RT5650"" @@ -566,49 +547,6 @@ end end end - device ref hda on - chip drivers/generic/max98357a - register "hid" = ""MX98360A"" - register "sdmode_gpio" = - "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D04)" - register "sdmode_delay" = "5" - device generic 0 on - probe AUDIO MAX98360_ALC5682I_I2S - end - end - chip drivers/intel/soundwire - device generic 0 on - probe AUDIO MAX98363_CS42L42_SNDW - chip drivers/soundwire/cs42l42 - # SoundWire Link 0 ID 0 - register "desc" = ""Headset Codec"" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B07)" - register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_B06)" - register "ts_inv" = "true" - register "ts_dbnc_rise" = "RISE_DEB_1000_MS" - register "ts_dbnc_fall" = "FALL_DEB_0_MS" - register "btn_det_init_dbnce" = "100" - register "btn_det_event_dbnce" = "10" - register "bias_lvls[0]" = "15" - register "bias_lvls[1]" = "8" - register "bias_lvls[2]" = "4" - register "bias_lvls[3]" = "1" - register "hs_bias_ramp_rate" = "HSBIAS_RAMP_SLOW" - register "hs_bias_sense_disable" = "true" - device generic 0.0 on end - end - chip drivers/soundwire/max98363 - # SoundWire Link 2 ID 0 - register "desc" = ""Left Speaker Amp"" - device generic 2.0 on end - end - chip drivers/soundwire/max98363 - # SoundWire Link 2 ID 1 - register "desc" = ""Right Speaker Amp"" - device generic 2.1 on end - end - end - end - end + device ref hda on end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/77602?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7e272a484ea76dfc3a314b3597cbc18c856a9ca Gerrit-Change-Number: 77602 Gerrit-PatchSet: 4 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/rex/var/karis: Add audio codec ALC5650
by Martin L Roth (Code Review) 02 Sep '23

02 Sep '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77360?usp=email ) Change subject: mb/google/rex/var/karis: Add audio codec ALC5650 ...................................................................... mb/google/rex/var/karis: Add audio codec ALC5650 Add audio codec ALC5650 related settings. BUG=b:294155897, b:295112765 TEST=emerge-rex coreboot Change-Id: I2b54dd600b47ecdfd1f488a8c623bc0599c8936f Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/77360 Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/rex/variants/karis/overridetree.cb 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Eric Lai: Looks good to me, approved Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/rex/variants/karis/overridetree.cb b/src/mainboard/google/rex/variants/karis/overridetree.cb index 7bde6bc..42106da 100644 --- a/src/mainboard/google/rex/variants/karis/overridetree.cb +++ b/src/mainboard/google/rex/variants/karis/overridetree.cb @@ -375,6 +375,17 @@ probe AUDIO MAX98360_ALC5682I_I2S end end + chip drivers/i2c/generic + register "hid" = ""10EC5650"" + register "name" = ""RT58"" + register "desc" = ""Realtek RT5650"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_B06)" + register "property_count" = "1" + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""realtek,jd-mode"" + register "property_list[0].integer" = "2" + device i2c 1a on end + end end #I2C0 device ref i2c1 on chip drivers/i2c/hid -- To view, visit https://review.coreboot.org/c/coreboot/+/77360?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b54dd600b47ecdfd1f488a8c623bc0599c8936f Gerrit-Change-Number: 77360 Gerrit-PatchSet: 12 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: mb/siemens/mc_apl2: Set Full Reset Bit into Reset Control Register
by Martin L Roth (Code Review) 02 Sep '23

02 Sep '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77603?usp=email ) Change subject: mb/siemens/mc_apl2: Set Full Reset Bit into Reset Control Register ...................................................................... mb/siemens/mc_apl2: Set Full Reset Bit into Reset Control Register With the introduction of a new Linux version a problem has appeared after a software initiated reset via CF9h register. The problem manifests itself in the fact that the Linux kernel does not start after the reboot. The problem is solved by setting bit 3 to 1 in Reset Control Register (I/O port CF9h). This leads to the fact that the PCH will drive SLP_S3 active low in the reset sequence. It leads to the same behavior as in commit 04ea73ee78bc ("siemens/mc_apl3: Set Full Reset Bit into Reset Control Register") explained. Change-Id: Ibc6d538c939e38732f42995d5ec6c8b61f979a6a Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/77603 Reviewed-by: Werner Zeh <werner.zeh(a)siemens.com> Reviewed-by: Jan Samek <jan.samek(a)siemens.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Werner Zeh: Looks good to me, approved build bot (Jenkins): Verified Jan Samek: Looks good to me, approved diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c index 430e67e..af9e25d 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <cf9_reset.h> #include <device/pci_def.h> #include <device/pci_ids.h> #include <device/pci_ops.h> @@ -17,4 +18,9 @@ pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER); } } + + /* Set Full Reset Bit in Reset Control Register (I/O port CF9h). When Bit 3 is set to 1 + and then a warm reset is triggered the PCH will drive SLP_S3 active (low). SLP_S3 is + then used on the mainboard to generate the right reset timing. */ + outb(FULL_RST, RST_CNT); } -- To view, visit https://review.coreboot.org/c/coreboot/+/77603?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc6d538c939e38732f42995d5ec6c8b61f979a6a Gerrit-Change-Number: 77603 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/rex/var/screebo: add hook for WiFi SAR table
by Martin L Roth (Code Review) 02 Sep '23

02 Sep '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77598?usp=email ) Change subject: mb/google/rex/var/screebo: add hook for WiFi SAR table ...................................................................... mb/google/rex/var/screebo: add hook for WiFi SAR table As a preparation for WiFi SAR table addition, adding hook for it. BUG=b:291155207 TEST=emerge-rex coreboot Change-Id: Ia313cfddec278e6bf8498407b242c027a5891deb Signed-off-by: YH Lin <yueherngl(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/77598 Reviewed-by: Subrata Banik <subratabanik(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/rex/Kconfig M src/mainboard/google/rex/variants/screebo/overridetree.cb M src/mainboard/google/rex/variants/screebo/variant.c 3 files changed, 11 insertions(+), 0 deletions(-) Approvals: Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index 78dc780..b289408 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -64,6 +64,7 @@ config BOARD_GOOGLE_MODEL_SCREEBO def_bool n select BOARD_GOOGLE_BASEBOARD_REX + select CHROMEOS_WIFI_SAR if CHROMEOS select DRIVERS_GENERIC_ALC1015 select DRIVERS_GENESYSLOGIC_GL9750 select DRIVERS_GENESYSLOGIC_GL9750_INVERT_WP diff --git a/src/mainboard/google/rex/variants/screebo/overridetree.cb b/src/mainboard/google/rex/variants/screebo/overridetree.cb index 6878ac6..772ba9c5 100644 --- a/src/mainboard/google/rex/variants/screebo/overridetree.cb +++ b/src/mainboard/google/rex/variants/screebo/overridetree.cb @@ -26,6 +26,10 @@ option SD_GL9750 0 option SD_RTS5227S 1 end + field WIFI_SAR_ID 13 + option WIFI_SAR_ID_0 0 + option WIFI_SAR_ID_1 1 + end end chip soc/intel/meteorlake diff --git a/src/mainboard/google/rex/variants/screebo/variant.c b/src/mainboard/google/rex/variants/screebo/variant.c index 4044fd4..4ea6598 100644 --- a/src/mainboard/google/rex/variants/screebo/variant.c +++ b/src/mainboard/google/rex/variants/screebo/variant.c @@ -3,6 +3,12 @@ #include <chip.h> #include <fw_config.h> #include <baseboard/variants.h> +#include <sar.h> + +const char *get_wifi_sar_cbfs_filename(void) +{ + return get_wifi_sar_fw_config_filename(FW_CONFIG_FIELD(WIFI_SAR_ID)); +} void variant_update_soc_chip_config(struct soc_intel_meteorlake_config *config) { -- To view, visit https://review.coreboot.org/c/coreboot/+/77598?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia313cfddec278e6bf8498407b242c027a5891deb Gerrit-Change-Number: 77598 Gerrit-PatchSet: 4 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: mb/google/rex/var/screebo: add FP_MCU fw_config
by Martin L Roth (Code Review) 02 Sep '23

02 Sep '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77597?usp=email ) Change subject: mb/google/rex/var/screebo: add FP_MCU fw_config ...................................................................... mb/google/rex/var/screebo: add FP_MCU fw_config Add FP_MCU definitions for fw_config according to the current build matrix. BUG=b:291155207 TEST=emerge-rex coreboot Change-Id: Id67b20a750d14eb23c62be9a30a5ef21d80e486a Signed-off-by: YH Lin <yueherngl(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/77597 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/rex/variants/screebo/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/rex/variants/screebo/overridetree.cb b/src/mainboard/google/rex/variants/screebo/overridetree.cb index 1774bc7..6878ac6 100644 --- a/src/mainboard/google/rex/variants/screebo/overridetree.cb +++ b/src/mainboard/google/rex/variants/screebo/overridetree.cb @@ -18,6 +18,10 @@ option TOUCHSCREEN_ILITEK 1 option TOUCHSCREEN_ELAN 2 end + field FP_MCU 10 + option FP_MCU_STM 0 + option FP_MCU_NPCX 1 + end field DB_SD 11 12 option SD_GL9750 0 option SD_RTS5227S 1 -- To view, visit https://review.coreboot.org/c/coreboot/+/77597?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id67b20a750d14eb23c62be9a30a5ef21d80e486a Gerrit-Change-Number: 77597 Gerrit-PatchSet: 3 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2023