coreboot-gerrit September 2023

coreboot-gerrit@coreboot.org

1 participants
3824 discussions

[S] Change in coreboot[master]: device/pci_rom: Set VBIOS checksum when filling VFCT table
by Matt DeVillier (Code Review) 03 Sep '23

03 Sep '23

Attention is currently required from: CoolStar. Hello CoolStar, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/77628?usp=email to review the following change. Change subject: device/pci_rom: Set VBIOS checksum when filling VFCT table ...................................................................... device/pci_rom: Set VBIOS checksum when filling VFCT table AMD's Windows display drivers validate the checksum of the VBIOS data in the VFCT table (which gets modified by the FSP GOP driver), so ensure it is set correctly after copying the VBIOS into it. Thanks to coolstar for root causing the issue. TEST=build/boot Win11 on google/skyrim (frostflow), ensure GPU driver loaded and functional. Change-Id: I809f87865fd2a25fb106444574b619746aec068d Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Signed-off-by: CoolStar <coolstarorganization(a)gmail.com> --- M src/device/pci_rom.c M src/include/acpi/acpi.h 2 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/77628/1 diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c index a454c9e..af0f98e 100644 --- a/src/device/pci_rom.c +++ b/src/device/pci_rom.c @@ -218,6 +218,8 @@ return NULL; } +#define ATOMBIOS_CHECKSUM_OFFSET 0x21 + static unsigned long pci_rom_acpi_fill_vfct(const struct device *device, acpi_vfct_t *vfct_struct, unsigned long current) @@ -245,10 +247,15 @@ header->PCIFunction = PCI_FUNC(device->path.pci.devfn); header->PCIDevice = PCI_SLOT(device->path.pci.devfn); header->ImageLength = rom->size * 512; - memcpy((void *)&header->VbiosContent, rom, header->ImageLength); + memcpy((void *)header->VbiosContent, rom, header->ImageLength); vfct_struct->VBIOSImageOffset = (size_t)header - (size_t)vfct_struct; + /* Calculate checksum for VBIOS data. */ + header->VbiosContent[ATOMBIOS_CHECKSUM_OFFSET] = 0; + header->VbiosContent[ATOMBIOS_CHECKSUM_OFFSET] = + acpi_checksum(header->VbiosContent, header->ImageLength); + current += header->ImageLength; return current; } diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 33bd735..f325457 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -478,7 +478,7 @@ u16 SSID; u32 Revision; u32 ImageLength; - u8 VbiosContent; // dummy - copy VBIOS here + u8 VbiosContent[1]; // dummy - copy VBIOS here } __packed acpi_vfct_image_hdr_t; /* VFCT (VBIOS Fetch Table) */ -- To view, visit https://review.coreboot.org/c/coreboot/+/77628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I809f87865fd2a25fb106444574b619746aec068d Gerrit-Change-Number: 77628 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: 3rdparty/amd_blobs: update submodule pointer
by Matt DeVillier (Code Review) 03 Sep '23

03 Sep '23

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/77627?usp=email ) Change subject: 3rdparty/amd_blobs: update submodule pointer ...................................................................... 3rdparty/amd_blobs: update submodule pointer Update submodule pointer to pull in release binaries for Mendocino SoC. TEST=build/boot google/skyrim (frostflow) Change-Id: Ie30415c0b47ef1302a29f8392958bb2cd1d0bda9 Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> --- M 3rdparty/amd_blobs 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/77627/1 diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs index 6a1e145..c6e5fba 160000 --- a/3rdparty/amd_blobs +++ b/3rdparty/amd_blobs @@ -1 +1 @@ -Subproject commit 6a1e1457afddf49e53bfa4f422e7fd42f9db6e49 +Subproject commit c6e5fba929efcefb3e12e9fde339945aea562849 -- To view, visit https://review.coreboot.org/c/coreboot/+/77627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie30415c0b47ef1302a29f8392958bb2cd1d0bda9 Gerrit-Change-Number: 77627 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: soc/intel/meteorlake: Fix black screen after booting to OS
by 9elements QA (Code Review) 03 Sep '23

03 Sep '23

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77611?usp=email ) Change subject: soc/intel/meteorlake: Fix black screen after booting to OS ...................................................................... Patch Set 2: Automatic boot test returned (PASS/FAIL/TOTAL): 14 / 2 / 16 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/182940 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/182938 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/182937 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/182936 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/182935 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/182934 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/182933 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/182932 FAIL: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/182931 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/182930 FAIL: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/182929 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/182928 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/182927 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/182926 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/182925 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/182924 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/77611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8908e8b6c995390b559212d456db6ddf984448a3 Gerrit-Change-Number: 77611 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Sun, 03 Sep 2023 16:06:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya: add ACPI brightness controls for iGPU
by Matt DeVillier (Code Review) 03 Sep '23

03 Sep '23

Attention is currently required from: Angel Pons, Eric Lai, Kangheui Won, Martin L Roth. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70372?usp=email ) Change subject: mb/google/brya: add ACPI brightness controls for iGPU ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb: https://review.coreboot.org/c/coreboot/+/70372/comment/ce10c4f0_de0a0420 : PS2, Line 110: register "gfx" = "GMA_DEFAULT_PANEL(0)" > Since this is a literal, you could do something like this: […] I'll try that, but with the values reversed -- To view, visit https://review.coreboot.org/c/coreboot/+/70372?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I03bb7a7309476839c49d2e862a036d9e89800605 Gerrit-Change-Number: 70372 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kwongnin Tin <kwongnint(a)gmail.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sun, 03 Sep 2023 15:31:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: security/tpm: Add Kconfig to allow payload control of TPM1
by Matt DeVillier (Code Review) 03 Sep '23

03 Sep '23

Attention is currently required from: Christian Walter, Julius Werner, Martin L Roth. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74856?usp=email ) Change subject: security/tpm: Add Kconfig to allow payload control of TPM1 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > This seems like a simple enough addition. Getting EDK2 updated will be far more complex. […] I'm still using it in my fork, so yes :) -- To view, visit https://review.coreboot.org/c/coreboot/+/74856?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb7db109cbcc1a0166d95b6130b624b635bb7ac9 Gerrit-Change-Number: 74856 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sun, 03 Sep 2023 15:29:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/brya: Enable GNA scoring accelerator
by Matt DeVillier (Code Review) 03 Sep '23

03 Sep '23

Attention is currently required from: CoolStar, Martin L Roth, Nick Vaccaro. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77577?usp=email ) Change subject: mb/google/brya: Enable GNA scoring accelerator ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb: https://review.coreboot.org/c/coreboot/+/77577/comment/6daabb5d_3bd00ed0 : PS3, Line 161: on > I'm thinking it might be useful to add a new keyword 'by_config <CONFIG_OPTION' That would allow us […] if you mean something similar to the way PROBE is used with fw_config options, then yes I think that could be very useful -- To view, visit https://review.coreboot.org/c/coreboot/+/77577?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib97278820d93a8fae52a74f36a5f60d9a9b2b363 Gerrit-Change-Number: 77577 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Comment-Date: Sun, 03 Sep 2023 15:28:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/dell: Add Latitude E6430 (Ivy Bridge)
by Nicholas Chin (Code Review) 03 Sep '23

03 Sep '23

Attention is currently required from: Nicholas Chin, Paul Menzel. Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/77444?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by Paul Menzel, Verified+1 by build bot (Jenkins) Change subject: mb/dell: Add Latitude E6430 (Ivy Bridge) ...................................................................... mb/dell: Add Latitude E6430 (Ivy Bridge) Mainboard is QAL80/LA-7781P (UMA). The dGPU model was not tested. This is based on the autoport output with some manual tweaks. The flash is 8MiB + 4MiB, and is fairly easily accessed by removing the keyboard. It can also be internally flashed by sending a command to the EC, which causes the EC to pull the FDO pin low and the firmware to skip setting up any chipset based write protections. [1] The EC is the SMSC MEC5055, which seems to be compatible with the existing MEC5035 code. Working: - Libgfxinit - USB EHCI debug (left side usb port is HCD index 2, middle port on the right side is HCD index 1) - Keyboard - Touchpad/trackpoint - ExpressCard - Audio - Ethernet - SD card reader - mPCIe WiFi - SeaBIOS 1.16.2 - edk2 (MrChromebox' fork, uefipayload_202306) - Internal flashing Not working: - S3 suspend: It seems like the EC also controls the DRAM reset gate so there may be a command that needs to be implemented for this - Physical Wireless switch - Battery reporting - Brightness hotkeys Unknown/untested: - Dock - eSATA - TPM - dGPU on non-UMA model [1] https://github.com/nic3-14159/e6400-flash-unlock Change-Id: I93c6622fc5da1d0d61a5b2c197ac7227d9525908 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- A src/mainboard/dell/e6430/Kconfig A src/mainboard/dell/e6430/Kconfig.name A src/mainboard/dell/e6430/Makefile.inc A src/mainboard/dell/e6430/acpi/ec.asl A src/mainboard/dell/e6430/acpi/platform.asl A src/mainboard/dell/e6430/acpi/superio.asl A src/mainboard/dell/e6430/acpi_tables.c A src/mainboard/dell/e6430/board_info.txt A src/mainboard/dell/e6430/cmos.default A src/mainboard/dell/e6430/cmos.layout A src/mainboard/dell/e6430/data.vbt A src/mainboard/dell/e6430/devicetree.cb A src/mainboard/dell/e6430/dsdt.asl A src/mainboard/dell/e6430/early_init.c A src/mainboard/dell/e6430/gma-mainboard.ads A src/mainboard/dell/e6430/gpio.c A src/mainboard/dell/e6430/hda_verb.c A src/mainboard/dell/e6430/mainboard.c 18 files changed, 589 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/77444/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/77444?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I93c6622fc5da1d0d61a5b2c197ac7227d9525908 Gerrit-Change-Number: 77444 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: commonlib/bsd/tpm_log_defs.h: Use C99 flexible arrays
by Elyes Haouas (Code Review) 03 Sep '23

03 Sep '23

Attention is currently required from: Arthur Heymans, Martin L Roth, Maximilian Brune, Sergii Dmytruk. Hello Maximilian Brune, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76787?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by Maximilian Brune Change subject: commonlib/bsd/tpm_log_defs.h: Use C99 flexible arrays ...................................................................... commonlib/bsd/tpm_log_defs.h: Use C99 flexible arrays Use C99 flexible arrays instead of older style of one-element or zero-length arrays. It allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Change-Id: I5b08b81d5df7a7500faa2c88d04f13dde05b6ea8 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/commonlib/bsd/include/commonlib/bsd/tpm_log_defs.h M util/cbmem/cbmem.c 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/76787/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/76787?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b08b81d5df7a7500faa2c88d04f13dde05b6ea8 Gerrit-Change-Number: 76787 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: commonlib/bsd/tpm_log_defs.h: Use C99 flexible arrays
by Elyes Haouas (Code Review) 03 Sep '23

03 Sep '23

Attention is currently required from: Arthur Heymans, Martin L Roth, Maximilian Brune, Sergii Dmytruk. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76787?usp=email ) Change subject: commonlib/bsd/tpm_log_defs.h: Use C99 flexible arrays ...................................................................... Patch Set 5: (1 comment) File util/cbmem/cbmem.c: https://review.coreboot.org/c/coreboot/+/76787/comment/ec0e423e_ef4e0ee3 : PS5, Line 915: uint8_t *ptr = (uint8_t *)log_entry + sizeof(*log_entry); > nit: […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/76787?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b08b81d5df7a7500faa2c88d04f13dde05b6ea8 Gerrit-Change-Number: 76787 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Sun, 03 Sep 2023 14:39:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: [Please Test] payloads/libpayload/drivers/usb/ehci_private: Use C99 f...
by Elyes Haouas (Code Review) 03 Sep '23

03 Sep '23

Attention is currently required from: Felix Held, Maximilian Brune, Patrick Georgi. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76850?usp=email ) Change subject: [Please Test] payloads/libpayload/drivers/usb/ehci_private: Use C99 flexible arrays ...................................................................... Patch Set 3: (1 comment) File payloads/libpayload/drivers/usb/ehci_private.h: PS1: > we could replace it with a union instead. Maybe like this: […] it is also deprecated. https://gcc.gnu.org/gcc-14/changes.html -- To view, visit https://review.coreboot.org/c/coreboot/+/76850?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec5bb3da8205326a43bba44630a8fcdcac651184 Gerrit-Change-Number: 76850 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 03 Sep 2023 14:31:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2023