Attention is currently required from: Iru Cai, Martin L Roth, Nicholas Chin.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77534?usp=email )
Change subject: ec/dell/mec5035: Add command to enable/disable radios
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/77534?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I173dc197d63cda232dd7ede0cb798ab0a364482b
Gerrit-Change-Number: 77534
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Comment-Date: Sun, 03 Sep 2023 20:19:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/77630?usp=email )
Change subject: soc/amd/common/vboot: Drop reporting of Silicon level
......................................................................
soc/amd/common/vboot: Drop reporting of Silicon level
Per the PSP team, this field in the transfer buffer isn't used anymore
and always set to zero, causing devices to incorrecly report having
pro-production silicon.
Change-Id: Ida4bf4b9328ac83d905e4c3f822e6ceabe9be79d
Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
---
M src/soc/amd/common/vboot/transfer_buffer.c
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/77630/1
diff --git a/src/soc/amd/common/vboot/transfer_buffer.c b/src/soc/amd/common/vboot/transfer_buffer.c
index a9644d3..6ca366a 100644
--- a/src/soc/amd/common/vboot/transfer_buffer.c
+++ b/src/soc/amd/common/vboot/transfer_buffer.c
@@ -57,9 +57,6 @@
printk(BIOS_INFO, "PSP boot mode: %s\n",
info->psp_info & PSP_INFO_PRODUCTION_MODE ?
"Production" : "Development");
- printk(BIOS_INFO, "Silicon level: %s\n",
- info->psp_info & PSP_INFO_PRODUCTION_SILICON ?
- "Production" : "Pre-Production");
}
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/77630?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida4bf4b9328ac83d905e4c3f822e6ceabe9be79d
Gerrit-Change-Number: 77630
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-MessageType: newchange
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/77629?usp=email )
Change subject: soc/amd/*: Set ACPI CID for I2C TPM shared with PSP
......................................................................
soc/amd/*: Set ACPI CID for I2C TPM shared with PSP
Set the ACPI CID when the TPM shares an I2C interface with the PSP,
so that Windows will load the compatible "standard" I2C controller
driver and not have an unknown device listed in Device Manager.
TEST=build/boot Win11 on google/skyrim (frostflow), verify the I2C
controller shared by the TPM and PSP has a driver automatically
installed.
Change-Id: I2081e4abe3137e8fda1ec9d3ecbce1ac9dfbac55
Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
---
M src/soc/amd/cezanne/acpi/mmio.asl
M src/soc/amd/glinda/acpi/mmio.asl
M src/soc/amd/mendocino/acpi/mmio.asl
M src/soc/amd/phoenix/acpi/mmio.asl
4 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/77629/1
diff --git a/src/soc/amd/cezanne/acpi/mmio.asl b/src/soc/amd/cezanne/acpi/mmio.asl
index 722f32d..a24852c 100644
--- a/src/soc/amd/cezanne/acpi/mmio.asl
+++ b/src/soc/amd/cezanne/acpi/mmio.asl
@@ -245,6 +245,7 @@
{
#if CONFIG(SOC_AMD_COMMON_BLOCK_I2C3_TPM_SHARED_WITH_PSP)
Name (_HID, "AMDI0019")
+ Name (_CID, "AMDI0010")
#else
Name (_HID, "AMDI0010")
#endif
diff --git a/src/soc/amd/glinda/acpi/mmio.asl b/src/soc/amd/glinda/acpi/mmio.asl
index eb1f1d9..b99efec 100644
--- a/src/soc/amd/glinda/acpi/mmio.asl
+++ b/src/soc/amd/glinda/acpi/mmio.asl
@@ -358,6 +358,7 @@
{
#if CONFIG(SOC_AMD_COMMON_BLOCK_I2C3_TPM_SHARED_WITH_PSP)
Name (_HID, "AMDI0019")
+ Name (_CID, "AMDI0010")
#else
Name (_HID, "AMDI0010")
#endif
diff --git a/src/soc/amd/mendocino/acpi/mmio.asl b/src/soc/amd/mendocino/acpi/mmio.asl
index 5c364d8..8a5d18b 100644
--- a/src/soc/amd/mendocino/acpi/mmio.asl
+++ b/src/soc/amd/mendocino/acpi/mmio.asl
@@ -358,6 +358,7 @@
{
#if CONFIG(SOC_AMD_COMMON_BLOCK_I2C3_TPM_SHARED_WITH_PSP)
Name (_HID, "AMDI0019")
+ Name (_CID, "AMDI0010")
#else
Name (_HID, "AMDI0010")
#endif
diff --git a/src/soc/amd/phoenix/acpi/mmio.asl b/src/soc/amd/phoenix/acpi/mmio.asl
index f5b27d1..c6fb13b 100644
--- a/src/soc/amd/phoenix/acpi/mmio.asl
+++ b/src/soc/amd/phoenix/acpi/mmio.asl
@@ -358,6 +358,7 @@
{
#if CONFIG(SOC_AMD_COMMON_BLOCK_I2C3_TPM_SHARED_WITH_PSP)
Name (_HID, "AMDI0019")
+ Name (_CID, "AMDI0010")
#else
Name (_HID, "AMDI0010")
#endif
--
To view, visit https://review.coreboot.org/c/coreboot/+/77629?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2081e4abe3137e8fda1ec9d3ecbce1ac9dfbac55
Gerrit-Change-Number: 77629
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-MessageType: newchange