coreboot-gerrit September 2023

coreboot-gerrit@coreboot.org

1 participants
3824 discussions

[S] Change in coreboot[master]: device/pci_rom: Set VBIOS checksum when filling VFCT table
by Matt DeVillier (Code Review) 04 Sep '23

04 Sep '23

Attention is currently required from: CoolStar, Martin L Roth, Paul Menzel. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77628?usp=email ) Change subject: device/pci_rom: Set VBIOS checksum when filling VFCT table ...................................................................... Patch Set 1: (3 comments) File src/device/pci_rom.c: https://review.coreboot.org/c/coreboot/+/77628/comment/3eed7542_55395b72 : PS1, Line 221: #define ATOMBIOS_CHECKSUM_OFFSET 0x21 > Would it make more sense to put this in a header file like acpi/acpi. […] will do https://review.coreboot.org/c/coreboot/+/77628/comment/399f711d_2e8871f4 : PS1, Line 254: /* Calculate checksum for VBIOS data. */ > I don't think that this is something that can be done universally. […] acpi_create_vfct(), which calls pci_rom_acpi_fill_vfct(), is only called on VGA oproms with a VID = PCI_VID_ATI, so Intel ones won't be touched. I actually did test this on Zork (running VBIOS, not GOP) and no problem there. But if preferred, would guarding this with CONFIG(RUN_FSP_GOP) suffice? File src/include/acpi/acpi.h: https://review.coreboot.org/c/coreboot/+/77628/comment/f16f03c5_d56e4be0 : PS1, Line 481: VbiosContent[1] > We're actually getting rid of all 0 & 1 length arrays in coreboot right now. […] will do -- To view, visit https://review.coreboot.org/c/coreboot/+/77628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I809f87865fd2a25fb106444574b619746aec068d Gerrit-Change-Number: 77628 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Comment-Date: Sun, 03 Sep 2023 23:18:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: 3rdparty/open-power-signing-utils: add SecureBoot utility for OpenPOWER
by Martin L Roth (Code Review) 04 Sep '23

04 Sep '23

Attention is currently required from: Arthur Heymans, Krystian Hebel, Sergii Dmytruk. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67065?usp=email ) Change subject: 3rdparty/open-power-signing-utils: add SecureBoot utility for OpenPOWER ...................................................................... Patch Set 18: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67065?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id88baef5ecb1f8ffd74a7f464bbbaaaea0ca643d Gerrit-Change-Number: 67065 Gerrit-PatchSet: 18 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Sun, 03 Sep 2023 22:56:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Makefile.inc: compile ECC tools and inject ECC to final image
by Martin L Roth (Code Review) 04 Sep '23

04 Sep '23

Attention is currently required from: Krystian Hebel, Michał Żygowski, Sergii Dmytruk. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67064?usp=email ) Change subject: Makefile.inc: compile ECC tools and inject ECC to final image ...................................................................... Patch Set 17: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67064?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8541aa6f1429ed6143830ed11c47c150183ddf0d Gerrit-Change-Number: 67064 Gerrit-PatchSet: 17 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Sun, 03 Sep 2023 22:45:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/raptor-cs/talos-2: add basic mainboard structure
by Martin L Roth (Code Review) 04 Sep '23

04 Sep '23

Attention is currently required from: Krystian Hebel, Michał Kopeć, Michał Żygowski, Sergii Dmytruk, ron minnich. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67063?usp=email ) Change subject: mb/raptor-cs/talos-2: add basic mainboard structure ...................................................................... Patch Set 17: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c4f74c7b27c8bb5599d68305adf369ddc6fcc70 Gerrit-Change-Number: 67063 Gerrit-PatchSet: 17 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Sun, 03 Sep 2023 22:44:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/ibm/power9/*: add file structure for SOC
by Martin L Roth (Code Review) 04 Sep '23

04 Sep '23

Attention is currently required from: Igor Bagnucki, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Sergii Dmytruk. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67062?usp=email ) Change subject: soc/ibm/power9/*: add file structure for SOC ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67062?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie74b1e34f9aebe151d0fdb0e95c003510fd864c3 Gerrit-Change-Number: 67062 Gerrit-PatchSet: 14 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Igor Bagnucki <bagnucki02(a)gmail.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Igor Bagnucki <igor.bagnucki(a)3mdeb.com> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Igor Bagnucki <bagnucki02(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Sun, 03 Sep 2023 22:41:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: drivers/ipmi: add BT interface
by Martin L Roth (Code Review) 04 Sep '23

04 Sep '23

Attention is currently required from: Christian Walter, Jonathan Zhang, Krystian Hebel, Martin Roth, Michał Żygowski, Sergii Dmytruk. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67057?usp=email ) Change subject: drivers/ipmi: add BT interface ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67057?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb67972d1c38bbae04c7b4de3405350c229a05b9 Gerrit-Change-Number: 67057 Gerrit-PatchSet: 12 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Sun, 03 Sep 2023 22:39:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: docs: Build in parallel
by Martin L Roth (Code Review) 04 Sep '23

04 Sep '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77452?usp=email ) Change subject: docs: Build in parallel ...................................................................... docs: Build in parallel Use all available cores to speed up building the documentation. As $(SPHINXOPTS) has no default in `Makefile.sphinx`, we can communicate it to all sub-makes via `export`. Change-Id: I25996f17348505722f3489a15a975de620331b5a Signed-off-by: Simon Glass <sjg(a)chromium.org> Signed-off-by: Nico Huber <nico.h(a)gmx.de> Original-reviewed-on: https://review.coreboot.org/c/coreboot/+/77363 Reviewed-on: https://review.coreboot.org/c/coreboot/+/77452 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M Documentation/Makefile 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Martin L Roth: Looks good to me, approved build bot (Jenkins): Verified diff --git a/Documentation/Makefile b/Documentation/Makefile index 54306a2..4d08c93 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -6,6 +6,9 @@ PDFLATEX = pdflatex -t a4 BUILDDIR ?= _build +SPHINXOPTS ?= -j auto + +export SPHINXOPTS FIGS=codeflow.pdf hypertransport.pdf @@ -57,7 +60,7 @@ rm -f corebootPortingGuide.pdf livesphinx: $(BUILDDIR) - $(MAKE) -f Makefile.sphinx livehtml SPHINXOPTS="$(SPHINXOPTS)" BUILDDIR="$(BUILDDIR)" + $(MAKE) -f Makefile.sphinx livehtml BUILDDIR="$(BUILDDIR)" test: @echo "Test for logging purposes - Failing tests will not fail the build" -- To view, visit https://review.coreboot.org/c/coreboot/+/77452?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25996f17348505722f3489a15a975de620331b5a Gerrit-Change-Number: 77452 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: device/pci_rom: Set VBIOS checksum when filling VFCT table
by Martin L Roth (Code Review) 04 Sep '23

04 Sep '23

Attention is currently required from: CoolStar, Paul Menzel. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77628?usp=email ) Change subject: device/pci_rom: Set VBIOS checksum when filling VFCT table ...................................................................... Patch Set 1: (3 comments) File src/device/pci_rom.c: https://review.coreboot.org/c/coreboot/+/77628/comment/000b5f65_cdac369e : PS1, Line 221: #define ATOMBIOS_CHECKSUM_OFFSET 0x21 Would it make more sense to put this in a header file like acpi/acpi.h along with the acpi_vfct_image_hdr structure? https://review.coreboot.org/c/coreboot/+/77628/comment/66d2ec0b_f8a7b176 : PS1, Line 254: /* Calculate checksum for VBIOS data. */ I don't think that this is something that can be done universally. It's looks like it's overwriting the 3rd byte of the 4-byte Option Rom "Init Entry" field. We should probably make sure that this is only run on AtomBIOS option ROMs that will just be used for the GOP driver. See table A2 on page 33 of the Bios Boot Specification V1.01 https://www.intel.com/content/www/us/en/content-details/772756/bios-boot-sp… File src/include/acpi/acpi.h: https://review.coreboot.org/c/coreboot/+/77628/comment/9cfd2cb3_68f52b97 : PS1, Line 481: VbiosContent[1] We're actually getting rid of all 0 & 1 length arrays in coreboot right now. Please change this to a C99 flexible array: `VbiosContent[];` See https://developers.redhat.com/articles/2022/09/29/benefits-limitations-flex… -- To view, visit https://review.coreboot.org/c/coreboot/+/77628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I809f87865fd2a25fb106444574b619746aec068d Gerrit-Change-Number: 77628 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Comment-Date: Sun, 03 Sep 2023 22:25:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: device/pci_rom: Set VBIOS checksum when filling VFCT table
by Matt DeVillier (Code Review) 04 Sep '23

04 Sep '23

Attention is currently required from: CoolStar, Paul Menzel. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77628?usp=email ) Change subject: device/pci_rom: Set VBIOS checksum when filling VFCT table ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/77628/comment/dad23962_65758b00 : PS1, Line 12: > Do you have more background? Do you get a black screen? Is there some error message? Windows will fail to load the GPU drivers with a code 43 error -- To view, visit https://review.coreboot.org/c/coreboot/+/77628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I809f87865fd2a25fb106444574b619746aec068d Gerrit-Change-Number: 77628 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Comment-Date: Sun, 03 Sep 2023 22:21:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: device/pci_rom: Set VBIOS checksum when filling VFCT table
by Paul Menzel (Code Review) 03 Sep '23

03 Sep '23

Attention is currently required from: CoolStar, Matt DeVillier. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77628?usp=email ) Change subject: device/pci_rom: Set VBIOS checksum when filling VFCT table ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/77628/comment/4288cd41_1318048b : PS1, Line 12: Do you have more background? Do you get a black screen? Is there some error message? -- To view, visit https://review.coreboot.org/c/coreboot/+/77628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I809f87865fd2a25fb106444574b619746aec068d Gerrit-Change-Number: 77628 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Comment-Date: Sun, 03 Sep 2023 20:23:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2023