coreboot-gerrit September 2023

coreboot-gerrit@coreboot.org

1 participants
3824 discussions

[S] Change in coreboot[main]: mb/emulation/qemu-q35: Support SPI flash
by Nico Huber (Code Review) 28 Sep '23

28 Sep '23

Attention is currently required from: Kyösti Mälkki, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78089?usp=email ) Change subject: mb/emulation/qemu-q35: Support SPI flash ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Are any new command line parameters needed or just a new/patched QEMU? -- To view, visit https://review.coreboot.org/c/coreboot/+/78089?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifba2bfa381fead6ad4c86ed81de7f961a472f1c7 Gerrit-Change-Number: 78089 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Thu, 28 Sep 2023 14:37:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/corsola: Move common selects to BOARD_GOOGLE_CORSOLA_COMMON
by Nico Huber (Code Review) 28 Sep '23

28 Sep '23

Attention is currently required from: Elyes Haouas, Felix Singer, Hung-Te Lin, Yidi Lin. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75086?usp=email ) Change subject: mb/google/corsola: Move common selects to BOARD_GOOGLE_CORSOLA_COMMON ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/75086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I498c6671b2dfc72820fc522744af7ce3b0a62930 Gerrit-Change-Number: 75086 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 28 Sep 2023 14:33:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: cpu/x86/Kconfig: Enhance SMM Kconfig help
by Nico Huber (Code Review) 28 Sep '23

28 Sep '23

Attention is currently required from: Maximilian Brune. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77973?usp=email ) Change subject: cpu/x86/Kconfig: Enhance SMM Kconfig help ...................................................................... Patch Set 1: Code-Review+1 (3 comments) File src/cpu/x86/Kconfig: https://review.coreboot.org/c/coreboot/+/77973/comment/f59f9123_18aa32aa : PS1, Line 158: legacy Nit: upper-case *L*egacy. https://review.coreboot.org/c/coreboot/+/77973/comment/218f1f61_abd9704a : PS1, Line 159: qemu *the QEMU* emulation target https://review.coreboot.org/c/coreboot/+/77973/comment/0a26aa68_075b22e0 : PS1, Line 169: access maybe *targets*? Otherwise, one of the 'access' should actually be 'accesses'. Either plural, '[multiple] processor accesses to TSEG access DRAM', or singular, '[a] processor access to TSEG accesses DRAM'. -- To view, visit https://review.coreboot.org/c/coreboot/+/77973?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia0a5c48c6314f53c4ed72958f5d6f839f0a5c2ca Gerrit-Change-Number: 77973 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 28 Sep 2023 14:29:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/amd/genoa: Enable ECAM MMCONF support
by Varshit Pandya (Code Review) 28 Sep '23

28 Sep '23

Attention is currently required from: Arthur Heymans, Felix Held, Martin Roth, Varshit Pandya. Varshit Pandya has uploaded a new patch set (#12) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/76504?usp=email ) Change subject: soc/amd/genoa: Enable ECAM MMCONF support ...................................................................... soc/amd/genoa: Enable ECAM MMCONF support Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Signed-off-by: Varshit Pandya <pandyavarshit(a)gmail.com> Change-Id: I70db8bf9f553fa9bfd2a5c20a1393119786047f8 --- M src/soc/amd/genoa/Kconfig 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/76504/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/76504?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I70db8bf9f553fa9bfd2a5c20a1393119786047f8 Gerrit-Change-Number: 76504 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: soc/amd/genoa/southbridge.h: Add PM related macros
by Varshit Pandya (Code Review) 28 Sep '23

28 Sep '23

Attention is currently required from: Arthur Heymans, Felix Held, Varshit Pandya. Varshit Pandya has uploaded a new patch set (#12) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/76502?usp=email ) Change subject: soc/amd/genoa/southbridge.h: Add PM related macros ...................................................................... soc/amd/genoa/southbridge.h: Add PM related macros All verified with PPR. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Signed-off-by: Varshit Pandya <pandyavarshit(a)gmail.com> Change-Id: If288079310ba74333f04173978f6a123ce95f4d9 --- M src/soc/amd/genoa/include/soc/southbridge.h 1 file changed, 109 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/76502/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/76502?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If288079310ba74333f04173978f6a123ce95f4d9 Gerrit-Change-Number: 76502 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: soc/mediatek: PCI: Fix translation window
by Nico Huber (Code Review) 28 Sep '23

28 Sep '23

Attention is currently required from: Hung-Te Lin, Jianjun Wang, Paul Menzel, Yidi Lin. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78044?usp=email ) Change subject: soc/mediatek: PCI: Fix translation window ...................................................................... Patch Set 14: Code-Review+1 (1 comment) File src/soc/mediatek/common/pcie.c: https://review.coreboot.org/c/coreboot/+/78044/comment/bd2003d1_d92e8fcf : PS14, Line 240: if (mtk_pcie_set_trans_window(&count, table_base, &conf->mmio_res_io) : < 0) { : printk(BIOS_ERR, "%s: Failed to set IO window, ignore it\n", : __func__); : count = 0; : } : : /* Initialize memory resources constraints. */ : if (mtk_pcie_set_trans_window(&count, table_base, &conf->mmio_res_mem) : < 0) Nit: there is no need to break lines here. 96 chars is our (soft) limit. -- To view, visit https://review.coreboot.org/c/coreboot/+/78044?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I42b0f0bf9222d284dee0c29f1a6ed6366d6e6689 Gerrit-Change-Number: 78044 Gerrit-PatchSet: 14 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Comment-Date: Thu, 28 Sep 2023 14:18:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/amd/genoa: Add timer & tsc support
by Varshit Pandya (Code Review) 28 Sep '23

28 Sep '23

Attention is currently required from: Arthur Heymans, Felix Held, Varshit Pandya. Varshit Pandya has uploaded a new patch set (#12) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/76501?usp=email ) Change subject: soc/amd/genoa: Add timer & tsc support ...................................................................... soc/amd/genoa: Add timer & tsc support Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Signed-off-by: Varshit Pandya <pandyavarshit(a)gmail.com> Change-Id: Ie1ae2ba4d4833570ca0621023bdeed67ccabe5cb --- M src/soc/amd/genoa/Kconfig M src/soc/amd/genoa/Makefile.inc A src/soc/amd/genoa/include/soc/msr.h D src/soc/amd/genoa/timer.c 4 files changed, 43 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/76501/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/76501?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie1ae2ba4d4833570ca0621023bdeed67ccabe5cb Gerrit-Change-Number: 76501 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: soc/amd/genoa: Add function to fetch common code dt configuration
by Varshit Pandya (Code Review) 28 Sep '23

28 Sep '23

Attention is currently required from: Arthur Heymans, Felix Held, Varshit Pandya. Varshit Pandya has uploaded a new patch set (#12) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/76500?usp=email ) Change subject: soc/amd/genoa: Add function to fetch common code dt configuration ...................................................................... soc/amd/genoa: Add function to fetch common code dt configuration Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Signed-off-by: Varshit Pandya <pandyavarshit(a)gmail.com> Change-Id: I5d5d3ff27ab0953844f9bbef30b6487fb480e29b --- M src/soc/amd/genoa/Makefile.inc A src/soc/amd/genoa/chip.h A src/soc/amd/genoa/config.c 3 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/76500/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/76500?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d5d3ff27ab0953844f9bbef30b6487fb480e29b Gerrit-Change-Number: 76500 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: soc/amd/genoa: Deal with memory map for 32M or larger flash
by Varshit Pandya (Code Review) 28 Sep '23

28 Sep '23

Attention is currently required from: Arthur Heymans, Bao Zheng, Felix Held, Martin L Roth, Matt DeVillier, Varshit Pandya. Varshit Pandya has uploaded a new patch set (#12) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/76499?usp=email ) Change subject: soc/amd/genoa: Deal with memory map for 32M or larger flash ...................................................................... soc/amd/genoa: Deal with memory map for 32M or larger flash Only the lower half of the flash gets memory mapped below 4G in the current setup. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Signed-off-by: Varshit Pandya <pandyavarshit(a)gmail.com> Change-Id: Iffe5c17a50f3254411a4847c7e635ce0fd282fde --- M src/soc/amd/genoa/Kconfig M src/soc/amd/genoa/Makefile.inc A src/soc/amd/genoa/mmap_boot.c 3 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/76499/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/76499?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iffe5c17a50f3254411a4847c7e635ce0fd282fde Gerrit-Change-Number: 76499 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: soc/amd/genoa: Add Kconfig/Makefile to generate PSP image
by Varshit Pandya (Code Review) 28 Sep '23

28 Sep '23

Attention is currently required from: Arthur Heymans, Bao Zheng, Felix Held, Marshall Dawson, Martin L Roth. Varshit Pandya has uploaded a new patch set (#12) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/76498?usp=email ) Change subject: soc/amd/genoa: Add Kconfig/Makefile to generate PSP image ...................................................................... soc/amd/genoa: Add Kconfig/Makefile to generate PSP image TESTED: AMD onyx reaches x86 code Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Signed-off-by: Varshit Pandya <pandyavarshit(a)gmail.com> Change-Id: I95d84f93663a80f322fd4d7cdeb35ccfe0ec7d21 --- A src/mainboard/amd/onyx/Makefile.inc M src/soc/amd/genoa/Kconfig M src/soc/amd/genoa/Makefile.inc A src/soc/amd/genoa/fw.cfg 4 files changed, 244 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/76498/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/76498?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I95d84f93663a80f322fd4d7cdeb35ccfe0ec7d21 Gerrit-Change-Number: 76498 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2023