coreboot-gerrit July 2023

coreboot-gerrit@coreboot.org

1 participants
4441 discussions

[S] Change in coreboot[master]: soc/amd/phoenix: Remove TODO after review
by Felix Held (Code Review) 03 Jul '23

03 Jul '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76165?usp=email ) Change subject: soc/amd/phoenix: Remove TODO after review ...................................................................... soc/amd/phoenix: Remove TODO after review Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com> Change-Id: Ifd2b53ff24776238190eb946db7b12827fcfc804 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76165 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> --- M src/soc/amd/phoenix/Kconfig M src/soc/amd/phoenix/include/soc/espi.h M src/soc/amd/phoenix/include/soc/uart.h 3 files changed, 3 insertions(+), 9 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/soc/amd/phoenix/Kconfig b/src/soc/amd/phoenix/Kconfig index 4ab26ee..a9f124c 100644 --- a/src/soc/amd/phoenix/Kconfig +++ b/src/soc/amd/phoenix/Kconfig @@ -37,12 +37,12 @@ select SOC_AMD_COMMON_BLOCK_ACPI # TODO: Check if this is still correct select SOC_AMD_COMMON_BLOCK_ACPIMMIO # TODO: Check if this is still correct select SOC_AMD_COMMON_BLOCK_ACPI_ALIB # TODO: Check if this is still correct - select SOC_AMD_COMMON_BLOCK_ACPI_CPPC # TODO: Check if this is still correct + select SOC_AMD_COMMON_BLOCK_ACPI_CPPC select SOC_AMD_COMMON_BLOCK_ACPI_CPU_POWER_STATE select SOC_AMD_COMMON_BLOCK_ACPI_GPIO # TODO: Check if this is still correct select SOC_AMD_COMMON_BLOCK_ACPI_IVRS # TODO: Check if this is still correct select SOC_AMD_COMMON_BLOCK_AOAC - select SOC_AMD_COMMON_BLOCK_APOB # TODO: Check if this is still correct + select SOC_AMD_COMMON_BLOCK_APOB select SOC_AMD_COMMON_BLOCK_APOB_HASH select SOC_AMD_COMMON_BLOCK_BANKED_GPIOS select SOC_AMD_COMMON_BLOCK_CPUFREQ_FAM17H_19H @@ -77,7 +77,7 @@ select SOC_AMD_COMMON_BLOCK_UART select SOC_AMD_COMMON_BLOCK_UCODE select SOC_AMD_COMMON_BLOCK_XHCI - select SOC_AMD_COMMON_FSP_CCX_CPPC_HOB # TODO: Check if this is still correct + select SOC_AMD_COMMON_FSP_CCX_CPPC_HOB select SOC_AMD_COMMON_FSP_DMI_TABLES select SOC_AMD_COMMON_FSP_PCI # TODO: Check if this is still correct select SOC_AMD_COMMON_FSP_PRELOAD_FSPS diff --git a/src/soc/amd/phoenix/include/soc/espi.h b/src/soc/amd/phoenix/include/soc/espi.h index 057332a..5968da0e 100644 --- a/src/soc/amd/phoenix/include/soc/espi.h +++ b/src/soc/amd/phoenix/include/soc/espi.h @@ -1,7 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -/* TODO: Update for Phoenix */ - #ifndef AMD_PHOENIX_ESPI_H #define AMD_PHOENIX_ESPI_H diff --git a/src/soc/amd/phoenix/include/soc/uart.h b/src/soc/amd/phoenix/include/soc/uart.h index b8d6e17..5b941b2 100644 --- a/src/soc/amd/phoenix/include/soc/uart.h +++ b/src/soc/amd/phoenix/include/soc/uart.h @@ -1,12 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -/* TODO: Update for Phoenix */ - #ifndef AMD_PHOENIX_UART_H #define AMD_PHOENIX_UART_H -#include <types.h> - void clear_uart_legacy_config(void); /* disable legacy I/O decode for FCH UART */ #endif /* AMD_PHOENIX_UART_H */ -- To view, visit https://review.coreboot.org/c/coreboot/+/76165?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd2b53ff24776238190eb946db7b12827fcfc804 Gerrit-Change-Number: 76165 Gerrit-PatchSet: 3 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: drivers/spi_flash: Always exit 4-byte address mode when memory-mapped
by Felix Held (Code Review) 03 Jul '23

03 Jul '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76093?usp=email ) Change subject: drivers/spi_flash: Always exit 4-byte address mode when memory-mapped ...................................................................... drivers/spi_flash: Always exit 4-byte address mode when memory-mapped Always send the Exit 4-Byte Address Mode (E9h) command before the first access to the SPI flash in all stages when the SPI flash is memory-mapped. This is useful for x86 mainboards that do not access SPI flash in bootblock yet still need to exit 4-byte addressing mode in romstage or ramstage. Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com> Change-Id: I3a62bfa44a0a5645c1bb80b32d0b9f92075c66bf Reviewed-on: https://review.coreboot.org/c/coreboot/+/76093 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> --- M src/drivers/spi/spi_flash.c 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Julius Werner: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/drivers/spi/spi_flash.c b/src/drivers/spi/spi_flash.c index 5182684..7619f64 100644 --- a/src/drivers/spi/spi_flash.c +++ b/src/drivers/spi/spi_flash.c @@ -18,6 +18,9 @@ #define ADDR_MOD 0 #endif +#define SPI_FLASH_EXIT_4BYTE_STAGE \ + (ENV_INITIAL_STAGE || CONFIG(BOOT_DEVICE_MEMORY_MAPPED)) + static void spi_flash_addr(u32 addr, u8 *cmd) { /* cmd[0] is actual command */ @@ -548,8 +551,10 @@ CONFIG_ROM_SIZE); } - if (CONFIG(SPI_FLASH_EXIT_4_BYTE_ADDR_MODE) && ENV_INITIAL_STAGE) + if (CONFIG(SPI_FLASH_EXIT_4_BYTE_ADDR_MODE) && SPI_FLASH_EXIT_4BYTE_STAGE) { + printk(BIOS_DEBUG, "SF: Exiting 4-byte addressing mode\n"); spi_flash_cmd(&flash->spi, CMD_EXIT_4BYTE_ADDR_MODE, NULL, 0); + } return 0; } -- To view, visit https://review.coreboot.org/c/coreboot/+/76093?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a62bfa44a0a5645c1bb80b32d0b9f92075c66bf Gerrit-Change-Number: 76093 Gerrit-PatchSet: 3 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: soc/amd/phoenix/Makefile.inc: Refactor repeated lines to a variable
by Fred Reitberger (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk. Hello Felix Held, Jason Glenesk, Matt DeVillier, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76197?usp=email to look at the new patch set (#2). Change subject: soc/amd/phoenix/Makefile.inc: Refactor repeated lines to a variable ...................................................................... soc/amd/phoenix/Makefile.inc: Refactor repeated lines to a variable Rather than repeat the same line multiple times, save it in a variable once and use that variable in the rest of the file. TEST=timeless birman builds identical Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com> Change-Id: I4eb262adb3bbda04add79b2e2b8bee9a609a1e5b --- M src/soc/amd/phoenix/Makefile.inc 1 file changed, 7 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/76197/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76197?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4eb262adb3bbda04add79b2e2b8bee9a609a1e5b Gerrit-Change-Number: 76197 Gerrit-PatchSet: 2 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/amd/acpi/ivrs: Use specific IOMMU resource index on all SOC
by Felix Held (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Arthur Heymans. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75710?usp=email ) Change subject: soc/amd/acpi/ivrs: Use specific IOMMU resource index on all SOC ...................................................................... Patch Set 2: (1 comment) File src/soc/amd/common/block/acpi/ivrs.c: https://review.coreboot.org/c/coreboot/+/75710/comment/7d9f600d_097ce1e3 : PS2, Line 209: } else if (dev->link_list->secondary == 0) { : current = _acpi_fill_ivrs_ioapic(current, (u8 *)GNB_IO_APIC_ADDR, : PCI_DEVFN(0, 1), 0); > updated that one which is now the proper fix Done -- To view, visit https://review.coreboot.org/c/coreboot/+/75710?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10345e2337dcb709c2c1a8e57a1b7dd9c04adb9e Gerrit-Change-Number: 75710 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Naresh <naresh.solanki.2011(a)gmail.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 03 Jul 2023 13:06:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/sconfig: Improve usage and long options
by Felix Held (Code Review) 03 Jul '23

03 Jul '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/70524?usp=email ) Change subject: util/sconfig: Improve usage and long options ...................................................................... util/sconfig: Improve usage and long options Move usage function closer to main(), remove excessive printf() calls, use descriptive argument flags. Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: If5252de63692c5e43bfbde4d7d93e1d7a84e8dff Reviewed-on: https://review.coreboot.org/c/coreboot/+/70524 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/sconfig/main.c 1 file changed, 25 insertions(+), 24 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved diff --git a/util/sconfig/main.c b/util/sconfig/main.c index a246c01..2e6188f 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -1493,20 +1493,6 @@ } } -static void usage(void) -{ - printf("usage: sconfig <options>\n"); - printf(" -c | --output_c : Path to output static.c file (required)\n"); - printf(" -r | --output_h : Path to header static.h file (required)\n"); - printf(" -d | --output_d : Path to header static_devices.h file (required)\n"); - printf(" -f | --output_f : Path to header static_fw_config.h file (required)\n"); - printf(" -m | --mainboard_devtree : Path to mainboard devicetree file (required)\n"); - printf(" -o | --override_devtree : Path to override devicetree file (optional)\n"); - printf(" -p | --chipset_devtree : Path to chipset/SOC devicetree file (optional)\n"); - - exit(1); -} - static void parse_devicetree(const char *file, struct bus *parent) { FILE *filec = fopen(file, "r"); @@ -1999,17 +1985,32 @@ fprintf(f, "\n#endif /* __STATIC_FW_CONFIG_H */\n"); } +static void usage(const char *name) +{ + printf("Usage: %s <options>\n", name); + printf("Options:\n" + " -c | --output_c : Path to output static.c file (required)\n" + " -r | --output_h : Path to header static.h file (required)\n" + " -d | --output_d : Path to header static_devices.h file (required)\n" + " -f | --output_f : Path to header static_fw_config.h file (required)\n" + " -m | --mainboard_devtree : Path to mainboard devicetree file (required)\n" + " -o | --override_devtree : Path to override devicetree file (optional)\n" + " -p | --chipset_devtree : Path to chipset/SOC devicetree file (optional)\n"); + + exit(1); +} + int main(int argc, char **argv) { static const struct option long_options[] = { - { "mainboard_devtree", 1, NULL, 'm' }, - { "override_devtree", 1, NULL, 'o' }, - { "chipset_devtree", 1, NULL, 'p' }, - { "output_c", 1, NULL, 'c' }, - { "output_h", 1, NULL, 'r' }, - { "output_d", 1, NULL, 'd' }, - { "output_f", 1, NULL, 'f' }, - { "help", 1, NULL, 'h' }, + { "mainboard_devtree", required_argument, NULL, 'm' }, + { "override_devtree", required_argument, NULL, 'o' }, + { "chipset_devtree", required_argument, NULL, 'p' }, + { "output_c", required_argument, NULL, 'c' }, + { "output_h", required_argument, NULL, 'r' }, + { "output_d", required_argument, NULL, 'd' }, + { "output_f", required_argument, NULL, 'f' }, + { "help", no_argument, NULL, 'h' }, { } }; const char *override_devtree = NULL; @@ -2047,12 +2048,12 @@ break; case 'h': default: - usage(); + usage(argv[0]); } } if (!base_devtree || !outputc || !outputh || !outputd || !outputf) - usage(); + usage(argv[0]); if (chipset_devtree) { /* Use the chipset devicetree as the base, then override -- To view, visit https://review.coreboot.org/c/coreboot/+/70524?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5252de63692c5e43bfbde4d7d93e1d7a84e8dff Gerrit-Change-Number: 70524 Gerrit-PatchSet: 6 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jan Dabros <jsd(a)semihalf.com> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: cpu/x86: Reduce scope of MTRR functions used locally
by Felix Held (Code Review) 03 Jul '23

03 Jul '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76193?usp=email ) Change subject: cpu/x86: Reduce scope of MTRR functions used locally ...................................................................... cpu/x86: Reduce scope of MTRR functions used locally Change-Id: Ic00358ee5b05d011a95d85ec355adef71c39a529 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/76193 Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/cpu/x86/mtrr/mtrr.c M src/include/cpu/x86/mtrr.h 2 files changed, 3 insertions(+), 5 deletions(-) Approvals: Elyes Haouas: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c index d156d41..a3a89fe 100644 --- a/src/cpu/x86/mtrr/mtrr.c +++ b/src/cpu/x86/mtrr/mtrr.c @@ -346,13 +346,13 @@ fixed_mtrrs_hide_amd_rwdram(); } -void x86_setup_fixed_mtrrs_no_enable(void) +static void x86_setup_fixed_mtrrs_no_enable(void) { calc_fixed_mtrrs(); commit_fixed_mtrrs(); } -void x86_setup_fixed_mtrrs(void) +static void x86_setup_fixed_mtrrs(void) { x86_setup_fixed_mtrrs_no_enable(); diff --git a/src/include/cpu/x86/mtrr.h b/src/include/cpu/x86/mtrr.h index 298947a..5741afb 100644 --- a/src/include/cpu/x86/mtrr.h +++ b/src/include/cpu/x86/mtrr.h @@ -95,9 +95,7 @@ void fixed_mtrrs_expose_amd_rwdram(void); /* Hide Rd/WrDram bits and allow modification for AMD. */ void fixed_mtrrs_hide_amd_rwdram(void); -void x86_setup_fixed_mtrrs(void); -/* Set up fixed MTRRs but do not enable them. */ -void x86_setup_fixed_mtrrs_no_enable(void); + void x86_mtrr_check(void); /* Insert a temporary MTRR range for the duration of coreboot's runtime. -- To view, visit https://review.coreboot.org/c/coreboot/+/76193?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic00358ee5b05d011a95d85ec355adef71c39a529 Gerrit-Change-Number: 76193 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: mb/system76/{adl,tgl}: Add FMD files
by Felix Held (Code Review) 03 Jul '23

03 Jul '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76155?usp=email ) Change subject: mb/system76/{adl,tgl}: Add FMD files ...................................................................... mb/system76/{adl,tgl}: Add FMD files Replace `CBFS_SIZE` with FMD files to declare regions and sizes. This will be used to lock BIOS region (except SMMSTORE) on boot. `CBFS_SIZE` was incorrectly set to 10 MiB, so this also corrects the BIOS region size to match the FIT values. Change-Id: I0f068f4d9b376f12b46faa5bb0c6a08e6cb744d8 Signed-off-by: Tim Crawford <tcrawford(a)system76.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/76155 Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jeremy Soller <jeremy(a)system76.com> --- M src/mainboard/system76/adl/Kconfig A src/mainboard/system76/adl/board.fmd M src/mainboard/system76/tgl-h/Kconfig A src/mainboard/system76/tgl-h/board-gbe.fmd A src/mainboard/system76/tgl-h/board.fmd M src/mainboard/system76/tgl-u/Kconfig A src/mainboard/system76/tgl-u/board.fmd 7 files changed, 62 insertions(+), 9 deletions(-) Approvals: Paul Menzel: Looks good to me, but someone else must approve Jeremy Soller: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/system76/adl/Kconfig b/src/mainboard/system76/adl/Kconfig index f4fadc3..49a7b2b 100644 --- a/src/mainboard/system76/adl/Kconfig +++ b/src/mainboard/system76/adl/Kconfig @@ -98,15 +98,15 @@ default "oryp9" if BOARD_SYSTEM76_ORYP9 default "oryp10" if BOARD_SYSTEM76_ORYP10 -config CBFS_SIZE - default 0xA00000 - config CONSOLE_POST default y config DIMM_SPD_SIZE default 512 +config FMDFILE + default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/board.fmd" + config ONBOARD_VGA_IS_PRIMARY default y diff --git a/src/mainboard/system76/adl/board.fmd b/src/mainboard/system76/adl/board.fmd new file mode 100644 index 0000000..f50c357 --- /dev/null +++ b/src/mainboard/system76/adl/board.fmd @@ -0,0 +1,15 @@ +FLASH 32M { + SI_DESC 4K +#if CONFIG_MAINBOARD_USES_IFD_GBE_REGION + SI_GBE 8K +#endif + SI_ME 4824K + SI_BIOS@16M 16M { + RW_MRC_CACHE 64K + SMMSTORE(PRESERVE) 256K + WP_RO { + FMAP 4K + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/system76/tgl-h/Kconfig b/src/mainboard/system76/tgl-h/Kconfig index 69ab4ae..bd886b8 100644 --- a/src/mainboard/system76/tgl-h/Kconfig +++ b/src/mainboard/system76/tgl-h/Kconfig @@ -57,12 +57,13 @@ config OVERRIDE_DEVICETREE default "variants/\$(CONFIG_VARIANT_DIR)/overridetree.cb" -config CBFS_SIZE - default 0xA00000 - config CONSOLE_POST default y +config FMDFILE + default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/board.fmd" if !MAINBOARD_USES_IFD_GBE_REGION + default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/board-gbe.fmd" if MAINBOARD_USES_IFD_GBE_REGION + config ONBOARD_VGA_IS_PRIMARY default y diff --git a/src/mainboard/system76/tgl-h/board-gbe.fmd b/src/mainboard/system76/tgl-h/board-gbe.fmd new file mode 100644 index 0000000..2bfb31c --- /dev/null +++ b/src/mainboard/system76/tgl-h/board-gbe.fmd @@ -0,0 +1,13 @@ +FLASH 16M { + SI_DESC 4K + SI_GBE 8K + SI_ME 5108K + SI_BIOS 11M { + RW_MRC_CACHE 64K + SMMSTORE(PRESERVE) 256K + WP_RO { + FMAP 4K + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/system76/tgl-h/board.fmd b/src/mainboard/system76/tgl-h/board.fmd new file mode 100644 index 0000000..6f3a038 --- /dev/null +++ b/src/mainboard/system76/tgl-h/board.fmd @@ -0,0 +1,12 @@ +FLASH 16M { + SI_DESC 4K + SI_ME 5116K + SI_BIOS 11M { + RW_MRC_CACHE 64K + SMMSTORE(PRESERVE) 256K + WP_RO { + FMAP 4K + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/system76/tgl-u/Kconfig b/src/mainboard/system76/tgl-u/Kconfig index 0cd7b0d..d493fa8 100644 --- a/src/mainboard/system76/tgl-u/Kconfig +++ b/src/mainboard/system76/tgl-u/Kconfig @@ -55,12 +55,12 @@ default "galp5" if BOARD_SYSTEM76_GALP5 default "lemp10" if BOARD_SYSTEM76_LEMP10 -config CBFS_SIZE - default 0xA00000 - config CONSOLE_POST default y +config FMDFILE + default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/board.fmd" + config POST_DEVICE default n diff --git a/src/mainboard/system76/tgl-u/board.fmd b/src/mainboard/system76/tgl-u/board.fmd new file mode 100644 index 0000000..6f3a038 --- /dev/null +++ b/src/mainboard/system76/tgl-u/board.fmd @@ -0,0 +1,12 @@ +FLASH 16M { + SI_DESC 4K + SI_ME 5116K + SI_BIOS 11M { + RW_MRC_CACHE 64K + SMMSTORE(PRESERVE) 256K + WP_RO { + FMAP 4K + COREBOOT(CBFS) + } + } +} -- To view, visit https://review.coreboot.org/c/coreboot/+/76155?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f068f4d9b376f12b46faa5bb0c6a08e6cb744d8 Gerrit-Change-Number: 76155 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/system76: Add space for ramtop in CMOS layout
by Felix Held (Code Review) 03 Jul '23

03 Jul '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76154?usp=email ) Change subject: mb/system76: Add space for ramtop in CMOS layout ...................................................................... mb/system76: Add space for ramtop in CMOS layout Fixes building when `USE_OPTION_TABLE` is selected. Change-Id: I4fb017aa549b24eda6b9e0356bc1776d4044c95d Signed-off-by: Tim Crawford <tcrawford(a)system76.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/76154 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jeremy Soller <jeremy(a)system76.com> --- M src/mainboard/system76/addw1/cmos.layout M src/mainboard/system76/adl/cmos.layout M src/mainboard/system76/bonw14/cmos.layout M src/mainboard/system76/cml-u/cmos.layout M src/mainboard/system76/gaze15/cmos.layout M src/mainboard/system76/kbl-u/cmos.layout M src/mainboard/system76/oryp5/cmos.layout M src/mainboard/system76/oryp6/cmos.layout M src/mainboard/system76/rpl/cmos.layout M src/mainboard/system76/tgl-h/cmos.layout M src/mainboard/system76/tgl-u/cmos.layout M src/mainboard/system76/whl-u/cmos.layout 12 files changed, 12 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Jeremy Soller: Looks good to me, approved diff --git a/src/mainboard/system76/addw1/cmos.layout b/src/mainboard/system76/addw1/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/addw1/cmos.layout +++ b/src/mainboard/system76/addw1/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/adl/cmos.layout b/src/mainboard/system76/adl/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/adl/cmos.layout +++ b/src/mainboard/system76/adl/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/bonw14/cmos.layout b/src/mainboard/system76/bonw14/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/bonw14/cmos.layout +++ b/src/mainboard/system76/bonw14/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/cml-u/cmos.layout b/src/mainboard/system76/cml-u/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/cml-u/cmos.layout +++ b/src/mainboard/system76/cml-u/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/gaze15/cmos.layout b/src/mainboard/system76/gaze15/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/gaze15/cmos.layout +++ b/src/mainboard/system76/gaze15/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/kbl-u/cmos.layout b/src/mainboard/system76/kbl-u/cmos.layout index ac81752..4e9a300 100644 --- a/src/mainboard/system76/kbl-u/cmos.layout +++ b/src/mainboard/system76/kbl-u/cmos.layout @@ -12,6 +12,7 @@ 400 8 r 0 century 412 4 e 6 debug_level +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/oryp5/cmos.layout b/src/mainboard/system76/oryp5/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/oryp5/cmos.layout +++ b/src/mainboard/system76/oryp5/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/oryp6/cmos.layout b/src/mainboard/system76/oryp6/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/oryp6/cmos.layout +++ b/src/mainboard/system76/oryp6/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/rpl/cmos.layout b/src/mainboard/system76/rpl/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/rpl/cmos.layout +++ b/src/mainboard/system76/rpl/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/tgl-h/cmos.layout b/src/mainboard/system76/tgl-h/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/tgl-h/cmos.layout +++ b/src/mainboard/system76/tgl-h/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/tgl-u/cmos.layout b/src/mainboard/system76/tgl-u/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/tgl-u/cmos.layout +++ b/src/mainboard/system76/tgl-u/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/whl-u/cmos.layout b/src/mainboard/system76/whl-u/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/whl-u/cmos.layout +++ b/src/mainboard/system76/whl-u/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations -- To view, visit https://review.coreboot.org/c/coreboot/+/76154?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4fb017aa549b24eda6b9e0356bc1776d4044c95d Gerrit-Change-Number: 76154 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/system76: Select CBFS SMBIOS hooks
by Felix Held (Code Review) 03 Jul '23

03 Jul '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76153?usp=email ) Change subject: mb/system76: Select CBFS SMBIOS hooks ...................................................................... mb/system76: Select CBFS SMBIOS hooks Multiple users have requested to have the DMI values for product UUID and serial number be populated. Enable the drivers so that we may set them when flashing or updating firmware. Change-Id: I710363d9df626d51756a265f0099f26ef28411c2 Signed-off-by: Tim Crawford <tcrawford(a)system76.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/76153 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jeremy Soller <jeremy(a)system76.com> --- M src/mainboard/system76/addw1/Kconfig M src/mainboard/system76/adl/Kconfig M src/mainboard/system76/bonw14/Kconfig M src/mainboard/system76/cml-u/Kconfig M src/mainboard/system76/gaze15/Kconfig M src/mainboard/system76/kbl-u/Kconfig M src/mainboard/system76/oryp5/Kconfig M src/mainboard/system76/oryp6/Kconfig M src/mainboard/system76/rpl/Kconfig M src/mainboard/system76/tgl-h/Kconfig M src/mainboard/system76/tgl-u/Kconfig M src/mainboard/system76/whl-u/Kconfig 12 files changed, 24 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Jeremy Soller: Looks good to me, approved diff --git a/src/mainboard/system76/addw1/Kconfig b/src/mainboard/system76/addw1/Kconfig index f152392..d037504 100644 --- a/src/mainboard/system76/addw1/Kconfig +++ b/src/mainboard/system76/addw1/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select DRIVERS_I2C_TAS5825M select EC_SYSTEM76_EC diff --git a/src/mainboard/system76/adl/Kconfig b/src/mainboard/system76/adl/Kconfig index a7fca4f..f4fadc3 100644 --- a/src/mainboard/system76/adl/Kconfig +++ b/src/mainboard/system76/adl/Kconfig @@ -1,6 +1,8 @@ config BOARD_SYSTEM76_ADL_COMMON def_bool n select BOARD_ROMSIZE_KB_32768 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select DRIVERS_INTEL_PMC select DRIVERS_INTEL_USB4_RETIMER diff --git a/src/mainboard/system76/bonw14/Kconfig b/src/mainboard/system76/bonw14/Kconfig index b3f1707..570cb3b 100644 --- a/src/mainboard/system76/bonw14/Kconfig +++ b/src/mainboard/system76/bonw14/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select EC_SYSTEM76_EC select EC_SYSTEM76_EC_COLOR_KEYBOARD diff --git a/src/mainboard/system76/cml-u/Kconfig b/src/mainboard/system76/cml-u/Kconfig index fa6c9bf..e8899ac 100644 --- a/src/mainboard/system76/cml-u/Kconfig +++ b/src/mainboard/system76/cml-u/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select EC_SYSTEM76_EC select EC_SYSTEM76_EC_COLOR_KEYBOARD if BOARD_SYSTEM76_DARP6 diff --git a/src/mainboard/system76/gaze15/Kconfig b/src/mainboard/system76/gaze15/Kconfig index 3627cb1..882992e 100644 --- a/src/mainboard/system76/gaze15/Kconfig +++ b/src/mainboard/system76/gaze15/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select EC_SYSTEM76_EC select EC_SYSTEM76_EC_COLOR_KEYBOARD diff --git a/src/mainboard/system76/kbl-u/Kconfig b/src/mainboard/system76/kbl-u/Kconfig index f14af3b..3c35017 100644 --- a/src/mainboard/system76/kbl-u/Kconfig +++ b/src/mainboard/system76/kbl-u/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_CMOS_DEFAULT diff --git a/src/mainboard/system76/oryp5/Kconfig b/src/mainboard/system76/oryp5/Kconfig index 7cba2c2..9a10add 100644 --- a/src/mainboard/system76/oryp5/Kconfig +++ b/src/mainboard/system76/oryp5/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select DRIVERS_I2C_TAS5825M select EC_SYSTEM76_EC diff --git a/src/mainboard/system76/oryp6/Kconfig b/src/mainboard/system76/oryp6/Kconfig index 0aef4a6..85eb9d1 100644 --- a/src/mainboard/system76/oryp6/Kconfig +++ b/src/mainboard/system76/oryp6/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select DRIVERS_I2C_TAS5825M select EC_SYSTEM76_EC diff --git a/src/mainboard/system76/rpl/Kconfig b/src/mainboard/system76/rpl/Kconfig index f3f56e7..b0b9f52 100644 --- a/src/mainboard/system76/rpl/Kconfig +++ b/src/mainboard/system76/rpl/Kconfig @@ -1,6 +1,8 @@ config BOARD_SYSTEM76_RPL_COMMON def_bool n select BOARD_ROMSIZE_KB_32768 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select EC_SYSTEM76_EC select HAVE_ACPI_RESUME diff --git a/src/mainboard/system76/tgl-h/Kconfig b/src/mainboard/system76/tgl-h/Kconfig index cefee16..69ab4ae 100644 --- a/src/mainboard/system76/tgl-h/Kconfig +++ b/src/mainboard/system76/tgl-h/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select DRIVERS_I2C_TAS5825M if BOARD_SYSTEM76_ORYP8 select EC_SYSTEM76_EC diff --git a/src/mainboard/system76/tgl-u/Kconfig b/src/mainboard/system76/tgl-u/Kconfig index ea2419b..0cd7b0d 100644 --- a/src/mainboard/system76/tgl-u/Kconfig +++ b/src/mainboard/system76/tgl-u/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select DRIVERS_INTEL_PMC select DRIVERS_INTEL_USB4_RETIMER diff --git a/src/mainboard/system76/whl-u/Kconfig b/src/mainboard/system76/whl-u/Kconfig index f6bebe6..6a23901 100644 --- a/src/mainboard/system76/whl-u/Kconfig +++ b/src/mainboard/system76/whl-u/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select EC_SYSTEM76_EC select EC_SYSTEM76_EC_COLOR_KEYBOARD if BOARD_SYSTEM76_DARP5 -- To view, visit https://review.coreboot.org/c/coreboot/+/76153?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I710363d9df626d51756a265f0099f26ef28411c2 Gerrit-Change-Number: 76153 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: mb/system76: Select TPM read delay on all boards
by Felix Held (Code Review) 03 Jul '23

03 Jul '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76095?usp=email ) Change subject: mb/system76: Select TPM read delay on all boards ...................................................................... mb/system76: Select TPM read delay on all boards The Infineon chip occasionally fails Startup or Resume. Adding the delay makes it work more reliably. Change-Id: I4a8f98633154888e2167a3d55192b86e13ffcb62 Signed-off-by: Tim Crawford <tcrawford(a)system76.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/76095 Reviewed-by: Jeremy Soller <jeremy(a)system76.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/system76/adl/Kconfig M src/mainboard/system76/cml-u/Kconfig M src/mainboard/system76/kbl-u/Kconfig M src/mainboard/system76/oryp5/Kconfig M src/mainboard/system76/whl-u/Kconfig 5 files changed, 5 insertions(+), 0 deletions(-) Approvals: Jeremy Soller: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/system76/adl/Kconfig b/src/mainboard/system76/adl/Kconfig index e505ebb..a7fca4f 100644 --- a/src/mainboard/system76/adl/Kconfig +++ b/src/mainboard/system76/adl/Kconfig @@ -19,6 +19,7 @@ select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select SPD_READ_BY_WORD select SYSTEM_TYPE_LAPTOP + select TPM_RDRESP_NEED_DELAY config BOARD_SYSTEM76_DARP8 select BOARD_SYSTEM76_ADL_COMMON diff --git a/src/mainboard/system76/cml-u/Kconfig b/src/mainboard/system76/cml-u/Kconfig index 992f8dc..fa6c9bf 100644 --- a/src/mainboard/system76/cml-u/Kconfig +++ b/src/mainboard/system76/cml-u/Kconfig @@ -24,6 +24,7 @@ select SPD_READ_BY_WORD select SYSTEM_TYPE_LAPTOP select TPM_MEASURED_BOOT + select TPM_RDRESP_NEED_DELAY config MAINBOARD_DIR default "system76/cml-u" diff --git a/src/mainboard/system76/kbl-u/Kconfig b/src/mainboard/system76/kbl-u/Kconfig index f5cb968..f14af3b 100644 --- a/src/mainboard/system76/kbl-u/Kconfig +++ b/src/mainboard/system76/kbl-u/Kconfig @@ -18,6 +18,7 @@ select SPD_READ_BY_WORD select SYSTEM_TYPE_LAPTOP select TPM_MEASURED_BOOT + select TPM_RDRESP_NEED_DELAY config DISABLE_HECI1_AT_PRE_BOOT default y diff --git a/src/mainboard/system76/oryp5/Kconfig b/src/mainboard/system76/oryp5/Kconfig index 9a0a323..7cba2c2 100644 --- a/src/mainboard/system76/oryp5/Kconfig +++ b/src/mainboard/system76/oryp5/Kconfig @@ -23,6 +23,7 @@ select SPD_READ_BY_WORD select SYSTEM_TYPE_LAPTOP select TPM_MEASURED_BOOT + select TPM_RDRESP_NEED_DELAY config MAINBOARD_DIR default "system76/oryp5" diff --git a/src/mainboard/system76/whl-u/Kconfig b/src/mainboard/system76/whl-u/Kconfig index 470de97..f6bebe6 100644 --- a/src/mainboard/system76/whl-u/Kconfig +++ b/src/mainboard/system76/whl-u/Kconfig @@ -22,6 +22,7 @@ select SPD_READ_BY_WORD select SYSTEM_TYPE_LAPTOP select TPM_MEASURED_BOOT + select TPM_RDRESP_NEED_DELAY config MAINBOARD_DIR default "system76/whl-u" -- To view, visit https://review.coreboot.org/c/coreboot/+/76095?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a8f98633154888e2167a3d55192b86e13ffcb62 Gerrit-Change-Number: 76095 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2023