Attention is currently required from: Eric Lai, Jakub Czapiga, Tarun Tuli, zhongtian wu.
Hello Eric Lai, Jakub Czapiga, Kapil Porwal, Kun Liu, Subrata Banik, Tarun Tuli, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76169?usp=email
to look at the new patch set (#6).
Change subject: mb/google/rex/var/screebo:Change t-HIGH\Frequency\Thd:dat for touchpad test failure
......................................................................
mb/google/rex/var/screebo:Change t-HIGH\Frequency\Thd:dat for touchpad test failure
Change i2c[3] parameter to meet below timing:
t-HIGH > 600ns;
Frequency < 400kHZ;
900ns > Thd:dat > 300ns.
BUG=b:286030723
BRANCH=none
TEST=Test success by EE.
Change-Id: I4b2d958a5a0d41e2cfa1087f5cb94cc83bbb1739
Signed-off-by: Zhongtian Wu <wuzhongtian(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/rex/variants/screebo/overridetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/76169/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/76169?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b2d958a5a0d41e2cfa1087f5cb94cc83bbb1739
Gerrit-Change-Number: 76169
Gerrit-PatchSet: 6
Gerrit-Owner: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76219?usp=email )
Change subject: mb/google/corsola: Add support for AW37503 Power IC
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/common/tps65132s.c:
https://review.coreboot.org/c/coreboot/+/76219/comment/cd66b640_008cb6cd :
PS1, Line 33: /* Initialize I2C bus for PMIC TPS65132 */
: mtk_i2c_bus_init(cfg->i2c_bus, I2C_SPEED_FAST);
: mdelay(10);
> This change seems unrelated? Please split it out, or better motivate it in the commit message.
We need to initialize i2c bus in advance to read the vendor id to distinguish which IC in used.
Hi Yidi, WDYT? Can I get your advice about this?
--
To view, visit https://review.coreboot.org/c/coreboot/+/76219?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ccd4db19c93a032226f006eab0427f78f7b6dc8
Gerrit-Change-Number: 76219
Gerrit-PatchSet: 2
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 04 Jul 2023 01:03:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76219?usp=email )
Change subject: mb/google/corsola: Add support for AW37503 Power IC
......................................................................
Patch Set 2:
(4 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/76219/comment/68d864dc_6f4f53ca :
PS1, Line 11: program the registers to control the positive/negative output supply.
> > 'ouput' may be misspelled - perhaps 'output'? […]
Done
https://review.coreboot.org/c/coreboot/+/76219/comment/c9338878_d031122e :
PS1, Line 15: In the starmie, we need +-6V supply for the MIPI panel. So we setting
> > 'programing' may be misspelled - perhaps 'programming'? […]
Done
https://review.coreboot.org/c/coreboot/+/76219/comment/3bbe5aff_cc846bf3 :
PS1, Line 15: we setting
> Imperative mood: set
Done
File src/mainboard/google/corsola/mainboard.c:
https://review.coreboot.org/c/coreboot/+/76219/comment/66af24de_c089a638 :
PS1, Line 59: /* Initialize I2C bus for PMIC */
> The comment seems redundant, as the code line below basically reads the same.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/76219?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ccd4db19c93a032226f006eab0427f78f7b6dc8
Gerrit-Change-Number: 76219
Gerrit-PatchSet: 2
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 04 Jul 2023 00:59:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Kapil Porwal, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76224?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Revert "mb/google/rex/var/ovis: Enable crashlog and IOE die"
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
this is also required
--
To view, visit https://review.coreboot.org/c/coreboot/+/76224?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97c709c43541af4fc203a285d1805fe3ac55d07f
Gerrit-Change-Number: 76224
Gerrit-PatchSet: 1
Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Tue, 04 Jul 2023 00:54:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment