coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: soc/intel/rtd3: Hook up supported states to Kconfig
by Sean Rhodes (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Matt DeVillier, Angel Pons, Eric Lai. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72765 ) Change subject: soc/intel/rtd3: Hook up supported states to Kconfig ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72765/comment/a9c76c61_5f16cab0 PS3, Line 12: When D3COLD_SUPPORT is enabled, return `3` (D3Hot). > not enabled? Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/72765 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a4b89132b594ad568a5851137575f921f8e2a2e Gerrit-Change-Number: 72765 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 11:17:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/rtd3: Hook up supported states to Kconfig
by Sean Rhodes (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Sean Rhodes, Matt DeVillier, Angel Pons. Hello build bot (Jenkins), Matt DeVillier, Angel Pons, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72765 to look at the new patch set (#4). Change subject: soc/intel/rtd3: Hook up supported states to Kconfig ...................................................................... soc/intel/rtd3: Hook up supported states to Kconfig Report `4` in `_S0W` only when D3COLD_SUPPORT is enabled, as if it is not, it will break S3 exit. When D3COLD_SUPPORT is not enabled, return `3` (D3Hot). This fixed S3 exit on both TGL and ADL. Tested on StarBook Mk V and Mk VI. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I3a4b89132b594ad568a5851137575f921f8e2a2e --- M src/soc/intel/common/block/pcie/rtd3/rtd3.c 1 file changed, 22 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/72765/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/72765 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a4b89132b594ad568a5851137575f921f8e2a2e Gerrit-Change-Number: 72765 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/rtd3: Hook up supported states to Kconfig
by Eric Lai (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Sean Rhodes, Matt DeVillier, Angel Pons. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72765 ) Change subject: soc/intel/rtd3: Hook up supported states to Kconfig ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72765/comment/8a58d713_974b79c1 PS3, Line 12: When D3COLD_SUPPORT is enabled, return `3` (D3Hot). not enabled? -- To view, visit https://review.coreboot.org/c/coreboot/+/72765 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a4b89132b594ad568a5851137575f921f8e2a2e Gerrit-Change-Number: 72765 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 11:16:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Remove unused S0IX variable
by Eric Lai (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Sean Rhodes, Tarun Tuli. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72797 ) Change subject: soc/intel/alderlake: Remove unused S0IX variable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85fc5dabf10c6df7f11fd1defe8a39afc9f95325 Gerrit-Change-Number: 72797 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 11:13:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: soc/intel/xeon_sp: add ebg (Emmitsburg PCH) directory
by Jian-Ming Wang (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Subrata Banik, Simon Chou, TimLiu-SMCI, Jonathan Zhang, Johnny Lin, Paul Menzel, David Hendricks, Christian Walter, Angel Pons, Arthur Heymans, Shuming Chu (Shuming), Elyes Haouas. Jian-Ming Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71945 ) Change subject: soc/intel/xeon_sp: add ebg (Emmitsburg PCH) directory ...................................................................... Patch Set 11: (9 comments) File src/soc/intel/xeon_sp/ebg/include/soc/gpio_soc_defs.h: https://review.coreboot.org/c/coreboot/+/71945/comment/0a193515_ab34702b PS8, Line 204: #define GPPC_H8 144 : #define GPPC_H9 145 : #define GPPC_H10 146 : #define GPPC_H11 147 : #define GPPC_H12 148 : #define GPPC_H13 149 : #define GPPC_H14 150 > Tim, could you check this? They are not declared as unrouted GPIOs in EDS. However the offsets were reserved by Emmitsburg PCH for PAD_CFG_DW* registers for these unused pins. To manage the related offsets, these setting shall be kept. Please check #606161 page 20, the offset assigned for GPPC_H7 and GPPC_H15. https://review.coreboot.org/c/coreboot/+/71945/comment/ac335c89_23b8fe67 PS8, Line 227: #define GPP_J9 165 : #define GPP_J10 166 : #define GPP_J11 167 > Tim, could you check this? They are not declared as unrouted GPIOs in EDS. However the offsets were reserved by Emmitsburg PCH for PAD_CFG_DW* registers for these unused pins. To manage the related offsets, these setting shall be kept. Please check #606161 page 21, the offset assigned for GPPC_J8 and GPPC_J12. https://review.coreboot.org/c/coreboot/+/71945/comment/9eb582ba_9a01535f PS8, Line 234: #define GPP_J16 172 : #define GPP_J17 173 > Tim, could you check this? GPP_J15 is the last pad configuration in EDS for GPIO community 4. GPP_J16 and GPP_J17 are defined as unrouted GPIOs in #606161 page 1692. https://review.coreboot.org/c/coreboot/+/71945/comment/9d8b5432_08dff3a7 PS8, Line 244: define GPP_I3 183 : #define GPP_I4 184 : #define GPP_I5 185 : #define GPP_I6 186 : #define GPP_I7 187 : #define GPP_I8 188 : #define GPP_I9 189 : #define GPP_I10 190 : #define GPP_I11 191 > Tim, could you check this? They are not declared as unrouted GPIOs in EDS. However the offsets were reserved by Emmitsburg PCH for PAD_CFG_DW* registers for these unused pins. To manage the related offsets, these setting shall be kept. Please check #606161 page 23, the offset assigned for GPPC_I12. https://review.coreboot.org/c/coreboot/+/71945/comment/f96f77d7_045cc315 PS8, Line 259: #define GPP_I18 198 : #define GPP_I19 199 : #define GPP_I20 200 > Tim, could you check this? They are not declared as unrouted GPIOs in EDS. However the offsets were reserved by Emmitsburg PCH for PAD_CFG_DW* registers for these unused pins. To manage the related offsets, these setting shall be kept. Please check #606161 page 23, the offset assigned for GPPC_I17 and GPPC_I21. https://review.coreboot.org/c/coreboot/+/71945/comment/cd3eba78_6efeb631 PS8, Line 276: #define GPP_L9 213 : #define GPP_L10 214 : #define GPP_L11 215 : #define GPP_L12 216 : #define GPP_L13 217 : #define GPP_L14 218 : #define GPP_L15 219 : #define GPP_L16 220 : #define GPP_L17 221 > Tim, could you check this? They are not declared as unrouted GPIOs in EDS. However the offsets were reserved by Emmitsburg PCH for PAD_CFG_DW* registers for these unused pins. To manage the related offsets, these setting shall be kept. I think the reserved entries are correct based on the calculation of offset of PAD_CFG_DW0_GPP_L_8 and PAD_CFG_DW0_CPP_M_0. Please check #606161 page 24, the offset assigned for GPPC_L8 and GPPC_M0. https://review.coreboot.org/c/coreboot/+/71945/comment/bff7fea9_b7cecb6d PS8, Line 296: #define GPP_M9 231 : #define GPP_M10 232 > Tim, could you check this? They are not declared as unrouted GPIOs in EDS. However the offsets were reserved by Emmitsburg PCH for PAD_CFG_DW* registers for these unused pins. To manage the related offsets, these setting shall be kept. Please check #606161 page 24, the offset assigned for GPPC_M8 and GPPC_M11. https://review.coreboot.org/c/coreboot/+/71945/comment/f883a01f_ec001f45 PS8, Line 300: #define GPP_M13 235 : #define GPP_M14 236 > Tim, could you check this? They are not declared as unrouted GPIOs in EDS. However the offsets were reserved by Emmitsburg PCH for PAD_CFG_DW* registers for these unused pins. To manage the related offsets, these setting shall be kept. Please check #606161 page 25, the offset assigned for GPPC_M12 and GPPC_M15. https://review.coreboot.org/c/coreboot/+/71945/comment/3d54e3f4_79f66077 PS8, Line 312: #define GPP_N5 245 : #define GPP_N6 246 : #define GPP_N7 247 : #define GPP_N8 248 : #define GPP_N9 249 : #define GPP_N10 250 : #define GPP_N11 251 : #define GPP_N12 252 : #define GPP_N13 253 : #define GPP_N14 254 : #define GPP_N15 255 : #define GPP_N16 256 : #define GPP_N17 257 > Tim, could you check this? GPP_N4 is the last pad configuration in EDS for GPIO community 5. However, GPP_N5 to GPP_N17 were defined in "Unrouted GPIOs". -- To view, visit https://review.coreboot.org/c/coreboot/+/71945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I393c1df75a344519fca7d680116f41f5f8bd9e87 Gerrit-Change-Number: 71945 Gerrit-PatchSet: 11 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 06 Feb 2023 10:50:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com> Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya: Create aurash variant
by Zoey Wu (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Tarun Tuli, Ricky Chang. Zoey Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72837 ) Change subject: mb/google/brya: Create aurash variant ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I595102778071f822c5cf69ceadeed174e5ea4836 Gerrit-Change-Number: 72837 Gerrit-PatchSet: 2 Gerrit-Owner: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 10:34:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/geralt: Add power-on sequence for BOE_TV110C9M_LL0
by Liju-Clr Chen (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu. Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72749 ) Change subject: mb/google/geralt: Add power-on sequence for BOE_TV110C9M_LL0 ...................................................................... Patch Set 4: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/72749/comment/9fa6b520_0d067385 PS1, Line 7: power on > power-on Done https://review.coreboot.org/c/coreboot/+/72749/comment/9611e5ae_c559955a PS1, Line 9: Add power sequence to power on BOE_TV110C9M_LL0 on Geralt proto board. > For Geralt, we use BOE_TV110C9M_LL0 as mipi firmware display, so […] Done https://review.coreboot.org/c/coreboot/+/72749/comment/d663e651_7bdb240a PS1, Line 12: on Geralt proto : board > on Geralt. Done File src/mainboard/google/geralt/panel_geralt.c: https://review.coreboot.org/c/coreboot/+/72749/comment/35ab73e8_39a0bd99 PS1, Line 22: static int mipi_panel_reg_mask (u8 addr, u8 val, u8 mask) > move to panel.c. Done https://review.coreboot.org/c/coreboot/+/72749/comment/a8aa8f3e_87750746 PS1, Line 26: if (i2c_read_field(MIPI_PANEL_I2C, MIPI_PANEL_SLAVE, addr, &msg, 0xFF, 0)) : printk(BIOS_ERR, "Rex: failed to read i2c: %d\n", addr); > ` […] Done https://review.coreboot.org/c/coreboot/+/72749/comment/30ca66fb_3d16d88d PS1, Line 66: ret = mipi_panel_reg_mask(0x00, 0x11, 0x1F); : : /* Set AVEE = -5.7V */ : ret = mipi_panel_reg_mask(0x01, 0x11, 0x1F); : : /* Disable AVDD & AVEE discharge when power on*/ : ret = mipi_panel_reg_mask(0x03, 0x30, 0xFF); > do some error handling Done File src/mainboard/google/geralt/panel_geralt.c: https://review.coreboot.org/c/coreboot/+/72749/comment/433f58aa_c21823e6 PS3, Line 51: mt6359p_init > mt6359 has been initialized in romstage. Can we just initialize it only once? […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/72749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ef0b2e26d8cc0dc35c2985363ee4c3557dac8a9 Gerrit-Change-Number: 72749 Gerrit-PatchSet: 4 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 10:31:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/geralt: Add API to control VM18 in regulator.c
by Liju-Clr Chen (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu. Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72748 ) Change subject: mb/google/geralt: Add API to control VM18 in regulator.c ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/72748/comment/317613af_b7e90460 PS1, Line 7: Add regulator VM18 support to supply power for BOE_TV110C9M_LL0 > Add API to control VM18 in regulator. […] Done https://review.coreboot.org/c/coreboot/+/72748/comment/a8ab95a0_c17ed4ad PS1, Line 12: on Geralt proto : board > on Geralt. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/72748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13bafbe10a18a18e253575fd107c9b415f28ef01 Gerrit-Change-Number: 72748 Gerrit-PatchSet: 3 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 10:30:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya: Create aurash variant
by Zoey Wu (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Tarun Tuli, Zoey Wu, Raihow Shi. Zoey Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72837 ) Change subject: mb/google/brya: Create aurash variant ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/72837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I595102778071f822c5cf69ceadeed174e5ea4836 Gerrit-Change-Number: 72837 Gerrit-PatchSet: 2 Gerrit-Owner: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 10:30:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek: Add support for regulator VM18
by Liju-Clr Chen (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu. Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72747 ) Change subject: soc/mediatek: Add support for regulator VM18 ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/72747/comment/f6d793f2_360a4a7d PS1, Line 7: Implement VM18 enable interface to supply power for BOE_TV110C9M_LL0 > soc/mediatek: Add support for regulator VM18 Done https://review.coreboot.org/c/coreboot/+/72747/comment/dd64c4ef_677c1ce7 PS1, Line 9: Implement VM18 enable interface to supply power for BOE_TV110C9M_LL0. > mipi -> MIPI Done https://review.coreboot.org/c/coreboot/+/72747/comment/69435144_d1fff6b7 PS1, Line 12: test firmware display pass for BOE_TV110C9M_LL0 on Geralt proto : board > test firmware display pass for BOE_TV110C9M_LL0 on Geralt. Done Patchset: PS2: > We may change the `regulator_id` array to a function similar to Geralt's `get_mt6359p_regulator_id() […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/72747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8c3b2df1157b23b37492b1e9b1716903ea67799 Gerrit-Change-Number: 72747 Gerrit-PatchSet: 3 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 10:30:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023