coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[M] Change in coreboot[master]: src/soc/intel/common/block/pcie/rtd3: Fix root port _STA logic
by Jérémy Compostella (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Bora Guvendik, Hannah Williams, Cliff Huang, Tarun Tuli, Subrata Banik, Nick Vaccaro. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72421 ) Change subject: src/soc/intel/common/block/pcie/rtd3: Fix root port _STA logic ...................................................................... Patch Set 2: (2 comments) File src/soc/intel/common/block/pcie/rtd3/rtd3.c: https://review.coreboot.org/c/coreboot/+/72421/comment/b9fed257_e27a0b38 PS2, Line 264: /* for enable pin: This is clearly not a one liner comment and therefore the syntax you used is incorrect. I also think that: 1. The explanation could use a little bit more text 2. This should actually be the function comment instead of an in-function comment. Here is what I suggest. ``` /* * Depending on the board configuration we use either the "enable" or the * "reset" pin to detect the status of the device. The logic for each pin is * detailed below. * * 1. For the "enable" pin: * | polarity | tx value | get_tx_gpio() | State | * |-------------+----------+---------------+-------| * | active high | 0 | 0 | 0 | * | active high | 1 | 1(active) | 1 | * | active low | 0 | 1(active) | 1 | * | active low | 1 | 0 | 0 | * * 2. For the the "reset" pin: * | polarity | tx value | get_tx_gpio() | State | * |-------------+----------+---------------+-------| * | active high | 0 | 0 | 1 | * | active high | 1 | 1(active) | 0 | * | active low | 0 | 1(active) | 0 | * | active low | 1 | 0 | 1 | */ ``` https://review.coreboot.org/c/coreboot/+/72421/comment/ed2d6439_fbf29ceb PS2, Line 286: acpigen_write_xor(LOCAL0_OP, 1, LOCAL0_OP); Can't we use `acpigen_write_not(LOCAL0_OP, LOCAL0_OP)` instead ? -- To view, visit https://review.coreboot.org/c/coreboot/+/72421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie6f1e7a5b3e9fd0ea00e1e5b54058a14c6e9e09e Gerrit-Change-Number: 72421 Gerrit-PatchSet: 2 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cordelia Huang <cordelia1396(a)gmail.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 17:22:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/testing: Allow scanbuild test to be skipped
by Martin L Roth (Code Review) 06 Feb '23

06 Feb '23

Martin L Roth has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/72801 ) Change subject: util/testing: Allow scanbuild test to be skipped ...................................................................... util/testing: Allow scanbuild test to be skipped This is currently killing the jenkins builds. This patch allows it to be disabled until the reason is found. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I16dba80a88953aa95f7f647ba12b2ec3297ab81f --- M util/testing/Makefile.inc 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/72801/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I16dba80a88953aa95f7f647ba12b2ec3297ab81f Gerrit-Change-Number: 72801 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/testing: Allow scanbuild test to be skipped.
by build bot (Jenkins) (Code Review) 06 Feb '23

06 Feb '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72801 ) Change subject: util/testing: Allow scanbuild test to be skipped. ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169976): https://review.coreboot.org/c/coreboot/+/72801/comment/e42921ec_521f6640 PS1, Line 6: Subject line should not end with a period. -- To view, visit https://review.coreboot.org/c/coreboot/+/72801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I16dba80a88953aa95f7f647ba12b2ec3297ab81f Gerrit-Change-Number: 72801 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 06 Feb 2023 17:13:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/testing: Allow scanbuild test to be skipped.
by Martin L Roth (Code Review) 06 Feb '23

06 Feb '23

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72801 ) Change subject: util/testing: Allow scanbuild test to be skipped. ...................................................................... util/testing: Allow scanbuild test to be skipped. This is currently killing the jenkins builds. This patch allows it to be disabled until the reason is found. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I16dba80a88953aa95f7f647ba12b2ec3297ab81f --- M util/testing/Makefile.inc 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/72801/1 diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc index 6f14c2d..ff55df0 100644 --- a/util/testing/Makefile.inc +++ b/util/testing/Makefile.inc @@ -115,7 +115,9 @@ util/lint/lint lint-extended $(JUNIT) test-abuild: +ifneq ($(JENKINS_SKIP_SCANBUILD_TEST),y) NAME=scanbuild; SCANBUILD_ARGS='-k -plist-html -maxloop 10' util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/$${NAME} $(ABUILD_OPTIONS) -scan-build --target EMULATION_QEMU_X86_Q35 --exitcode --name $${NAME} +endif ifneq ($(JENKINS_SKIP_GCC_TESTS),y) NAME=gcc-chromeos; util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/$${NAME} $(ABUILD_OPTIONS) -x --name $${NAME} --clean NAME=gcc; util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/$${NAME} $(ABUILD_OPTIONS) --name $${NAME} --clean-somewhat -- To view, visit https://review.coreboot.org/c/coreboot/+/72801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I16dba80a88953aa95f7f647ba12b2ec3297ab81f Gerrit-Change-Number: 72801 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: src/acpi: add function gen: if_lgreater_ and namestr assignment
by Anil Kumar K (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Bora Guvendik, Lance Zhao, Hannah Williams, Anil Kumar K, Cliff Huang, Tim Wawrzynczak. Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72825 ) Change subject: src/acpi: add function gen: if_lgreater_ and namestr assignment ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffe1b23362a7ab58bdc2aa8daf45cd6f086ee818 Gerrit-Change-Number: 72825 Gerrit-PatchSet: 1 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cordelia Huang <cordelia1396(a)gmail.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 17:11:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: src/acpi: add function gen: if_lgreater_ and namestr assignment
by Jérémy Compostella (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Bora Guvendik, Lance Zhao, Hannah Williams, Anil Kumar K, Cliff Huang, Tim Wawrzynczak. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72825 ) Change subject: src/acpi: add function gen: if_lgreater_ and namestr assignment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffe1b23362a7ab58bdc2aa8daf45cd6f086ee818 Gerrit-Change-Number: 72825 Gerrit-PatchSet: 1 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cordelia Huang <cordelia1396(a)gmail.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 17:00:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya: Add usb_lpm_incapable for Type-C port with PS8815
by Kapil Porwal (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Tarun Tuli, Martin L Roth, Ron Lee. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71925 ) Change subject: mb/google/brya: Add usb_lpm_incapable for Type-C port with PS8815 ...................................................................... Patch Set 6: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/71925/comment/c1929832_8b6865a4 PS6, Line 17: osiris MLB: C1 Why not both ports? What is the criteria? https://review.coreboot.org/c/coreboot/+/71925/comment/33b3cd1f_582503e7 PS6, Line 24: marasov changes are missing for marasov. -- To view, visit https://review.coreboot.org/c/coreboot/+/71925 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9246ff7908887404f49ec10ee781c8cba410557 Gerrit-Change-Number: 71925 Gerrit-PatchSet: 6 Gerrit-Owner: Ron Lee <ron.lee(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Ron Lee <ron.lee(a)intel.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 16:41:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [WIP] src/drivers/s3_save_restore: Initial support for SMM payload
by Patrick Rudolph (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Michał Żygowski, Martin L Roth, Benjamin Doron. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70378 ) Change subject: [WIP] src/drivers/s3_save_restore: Initial support for SMM payload ...................................................................... Patch Set 8: (2 comments) File src/drivers/s3_save_restore/cbtable.c: https://review.coreboot.org/c/coreboot/+/70378/comment/4dd1d691_e3a54abb PS8, Line 52: void lb_save_restore(struct lb_header *header) Everything in here is platform specific and could be 1) be part of Edk2Platforms and hardcode those values 2) be part of UefiPayloadPkg and detect those values by matching MCH/PCH IDs. https://review.coreboot.org/c/coreboot/+/70378/comment/89c26e0a_c5663a47 PS8, Line 172: LB_TAG_PLD_NV_VARIABLE_INFO there's no need for such table: - The payload is coreboot aware - The payload has a platform specific SPI driver Thus the payload can find and parse the FMAP by itself. -- To view, visit https://review.coreboot.org/c/coreboot/+/70378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3dd505a154175b6da8929b1157723de1645ca8fa Gerrit-Change-Number: 70378 Gerrit-PatchSet: 8 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 16:36:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/phoenix/include/cpu: rename CPUID define to match CPU model
by ritul guru (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger, Felix Held. ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72843 ) Change subject: soc/amd/phoenix/include/cpu: rename CPUID define to match CPU model ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie7500130d5470fdd824980b81746f3a0f6d277d4 Gerrit-Change-Number: 72843 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 06 Feb 2023 16:11:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/kano: Update ELAN TS delay time to 150ms
by David Wu (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Paz Zcharya, Tarun Tuli, Ren Kuo, Nick Vaccaro. David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72784 ) Change subject: mb/google/brya/var/kano: Update ELAN TS delay time to 150ms ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Please also update the datasheet in AVL and then mark this as resolved Done -- To view, visit https://review.coreboot.org/c/coreboot/+/72784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42a7737060a82c0b27717f1510b8ec64abd1465a Gerrit-Change-Number: 72784 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 15:44:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paz Zcharya <pazz(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023