coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: soc/intel/xeon_sp/finalize.c: Set BIOS_DONE MSR as applicable
by Jonathan Zhang (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Simon Chou, TimLiu-SMCI, Johnny Lin, Paul Menzel, Christian Walter, Arthur Heymans, Jian-Ming Wang, Srinidhi N Kaushik, Tim Chu, Shelly Chang. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71964 ) Change subject: soc/intel/xeon_sp/finalize.c: Set BIOS_DONE MSR as applicable ...................................................................... Patch Set 17: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f19a7c54818231ebbccd2b6f8b23f47b117eb1f Gerrit-Change-Number: 71964 Gerrit-PatchSet: 17 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 18:20:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/system76: Rename adl-p to adl
by Tim Crawford (Code Review) 06 Feb '23

06 Feb '23

Tim Crawford has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72802 ) Change subject: mb/system76: Rename adl-p to adl ...................................................................... mb/system76: Rename adl-p to adl The directory holds boards other than ADL-P, such as ADL-U and ADL-H, and will also contain the RPL boards. Change-Id: I8e1b67f83d649cd07645a4a519ba1bf2f6f5e7c6 Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- R src/mainboard/system76/adl/Kconfig R src/mainboard/system76/adl/Kconfig.name R src/mainboard/system76/adl/Makefile.inc R src/mainboard/system76/adl/acpi/backlight.asl R src/mainboard/system76/adl/acpi/mainboard.asl R src/mainboard/system76/adl/acpi/sleep.asl R src/mainboard/system76/adl/board_info.txt R src/mainboard/system76/adl/bootblock.c R src/mainboard/system76/adl/cmos.default R src/mainboard/system76/adl/cmos.layout R src/mainboard/system76/adl/devicetree.cb R src/mainboard/system76/adl/dsdt.asl R src/mainboard/system76/adl/include/mainboard/gpio.h R src/mainboard/system76/adl/ramstage.c R src/mainboard/system76/adl/variants/darp8/board_info.txt R src/mainboard/system76/adl/variants/darp8/data.vbt R src/mainboard/system76/adl/variants/darp8/gpio.c R src/mainboard/system76/adl/variants/darp8/gpio_early.c R src/mainboard/system76/adl/variants/darp8/hda_verb.c R src/mainboard/system76/adl/variants/darp8/overridetree.cb R src/mainboard/system76/adl/variants/darp8/romstage.c R src/mainboard/system76/adl/variants/galp6/board_info.txt R src/mainboard/system76/adl/variants/galp6/data.vbt R src/mainboard/system76/adl/variants/galp6/gpio.c R src/mainboard/system76/adl/variants/galp6/gpio_early.c R src/mainboard/system76/adl/variants/galp6/hda_verb.c R src/mainboard/system76/adl/variants/galp6/overridetree.cb R src/mainboard/system76/adl/variants/galp6/romstage.c 28 files changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/72802/1 diff --git a/src/mainboard/system76/adl-p/Kconfig b/src/mainboard/system76/adl/Kconfig similarity index 98% rename from src/mainboard/system76/adl-p/Kconfig rename to src/mainboard/system76/adl/Kconfig index 80c42a8..a450534 100644 --- a/src/mainboard/system76/adl-p/Kconfig +++ b/src/mainboard/system76/adl/Kconfig @@ -24,7 +24,7 @@ select SYSTEM_TYPE_LAPTOP config MAINBOARD_DIR - default "system76/adl-p" + default "system76/adl" config VARIANT_DIR default "darp8" if BOARD_SYSTEM76_DARP8 diff --git a/src/mainboard/system76/adl-p/Kconfig.name b/src/mainboard/system76/adl/Kconfig.name similarity index 100% rename from src/mainboard/system76/adl-p/Kconfig.name rename to src/mainboard/system76/adl/Kconfig.name diff --git a/src/mainboard/system76/adl-p/Makefile.inc b/src/mainboard/system76/adl/Makefile.inc similarity index 100% rename from src/mainboard/system76/adl-p/Makefile.inc rename to src/mainboard/system76/adl/Makefile.inc diff --git a/src/mainboard/system76/adl-p/acpi/backlight.asl b/src/mainboard/system76/adl/acpi/backlight.asl similarity index 100% rename from src/mainboard/system76/adl-p/acpi/backlight.asl rename to src/mainboard/system76/adl/acpi/backlight.asl diff --git a/src/mainboard/system76/adl-p/acpi/mainboard.asl b/src/mainboard/system76/adl/acpi/mainboard.asl similarity index 100% rename from src/mainboard/system76/adl-p/acpi/mainboard.asl rename to src/mainboard/system76/adl/acpi/mainboard.asl diff --git a/src/mainboard/system76/adl-p/acpi/sleep.asl b/src/mainboard/system76/adl/acpi/sleep.asl similarity index 100% rename from src/mainboard/system76/adl-p/acpi/sleep.asl rename to src/mainboard/system76/adl/acpi/sleep.asl diff --git a/src/mainboard/system76/adl-p/board_info.txt b/src/mainboard/system76/adl/board_info.txt similarity index 100% rename from src/mainboard/system76/adl-p/board_info.txt rename to src/mainboard/system76/adl/board_info.txt diff --git a/src/mainboard/system76/adl-p/bootblock.c b/src/mainboard/system76/adl/bootblock.c similarity index 100% rename from src/mainboard/system76/adl-p/bootblock.c rename to src/mainboard/system76/adl/bootblock.c diff --git a/src/mainboard/system76/adl-p/cmos.default b/src/mainboard/system76/adl/cmos.default similarity index 100% rename from src/mainboard/system76/adl-p/cmos.default rename to src/mainboard/system76/adl/cmos.default diff --git a/src/mainboard/system76/adl-p/cmos.layout b/src/mainboard/system76/adl/cmos.layout similarity index 100% rename from src/mainboard/system76/adl-p/cmos.layout rename to src/mainboard/system76/adl/cmos.layout diff --git a/src/mainboard/system76/adl-p/devicetree.cb b/src/mainboard/system76/adl/devicetree.cb similarity index 100% rename from src/mainboard/system76/adl-p/devicetree.cb rename to src/mainboard/system76/adl/devicetree.cb diff --git a/src/mainboard/system76/adl-p/dsdt.asl b/src/mainboard/system76/adl/dsdt.asl similarity index 100% rename from src/mainboard/system76/adl-p/dsdt.asl rename to src/mainboard/system76/adl/dsdt.asl diff --git a/src/mainboard/system76/adl-p/include/mainboard/gpio.h b/src/mainboard/system76/adl/include/mainboard/gpio.h similarity index 100% rename from src/mainboard/system76/adl-p/include/mainboard/gpio.h rename to src/mainboard/system76/adl/include/mainboard/gpio.h diff --git a/src/mainboard/system76/adl-p/ramstage.c b/src/mainboard/system76/adl/ramstage.c similarity index 100% rename from src/mainboard/system76/adl-p/ramstage.c rename to src/mainboard/system76/adl/ramstage.c diff --git a/src/mainboard/system76/adl-p/variants/darp8/board_info.txt b/src/mainboard/system76/adl/variants/darp8/board_info.txt similarity index 100% rename from src/mainboard/system76/adl-p/variants/darp8/board_info.txt rename to src/mainboard/system76/adl/variants/darp8/board_info.txt diff --git a/src/mainboard/system76/adl-p/variants/darp8/data.vbt b/src/mainboard/system76/adl/variants/darp8/data.vbt similarity index 100% rename from src/mainboard/system76/adl-p/variants/darp8/data.vbt rename to src/mainboard/system76/adl/variants/darp8/data.vbt Binary files differ diff --git a/src/mainboard/system76/adl-p/variants/darp8/gpio.c b/src/mainboard/system76/adl/variants/darp8/gpio.c similarity index 100% rename from src/mainboard/system76/adl-p/variants/darp8/gpio.c rename to src/mainboard/system76/adl/variants/darp8/gpio.c diff --git a/src/mainboard/system76/adl-p/variants/darp8/gpio_early.c b/src/mainboard/system76/adl/variants/darp8/gpio_early.c similarity index 100% rename from src/mainboard/system76/adl-p/variants/darp8/gpio_early.c rename to src/mainboard/system76/adl/variants/darp8/gpio_early.c diff --git a/src/mainboard/system76/adl-p/variants/darp8/hda_verb.c b/src/mainboard/system76/adl/variants/darp8/hda_verb.c similarity index 100% rename from src/mainboard/system76/adl-p/variants/darp8/hda_verb.c rename to src/mainboard/system76/adl/variants/darp8/hda_verb.c diff --git a/src/mainboard/system76/adl-p/variants/darp8/overridetree.cb b/src/mainboard/system76/adl/variants/darp8/overridetree.cb similarity index 100% rename from src/mainboard/system76/adl-p/variants/darp8/overridetree.cb rename to src/mainboard/system76/adl/variants/darp8/overridetree.cb diff --git a/src/mainboard/system76/adl-p/variants/darp8/romstage.c b/src/mainboard/system76/adl/variants/darp8/romstage.c similarity index 100% rename from src/mainboard/system76/adl-p/variants/darp8/romstage.c rename to src/mainboard/system76/adl/variants/darp8/romstage.c diff --git a/src/mainboard/system76/adl-p/variants/galp6/board_info.txt b/src/mainboard/system76/adl/variants/galp6/board_info.txt similarity index 100% rename from src/mainboard/system76/adl-p/variants/galp6/board_info.txt rename to src/mainboard/system76/adl/variants/galp6/board_info.txt diff --git a/src/mainboard/system76/adl-p/variants/galp6/data.vbt b/src/mainboard/system76/adl/variants/galp6/data.vbt similarity index 100% rename from src/mainboard/system76/adl-p/variants/galp6/data.vbt rename to src/mainboard/system76/adl/variants/galp6/data.vbt Binary files differ diff --git a/src/mainboard/system76/adl-p/variants/galp6/gpio.c b/src/mainboard/system76/adl/variants/galp6/gpio.c similarity index 100% rename from src/mainboard/system76/adl-p/variants/galp6/gpio.c rename to src/mainboard/system76/adl/variants/galp6/gpio.c diff --git a/src/mainboard/system76/adl-p/variants/galp6/gpio_early.c b/src/mainboard/system76/adl/variants/galp6/gpio_early.c similarity index 100% rename from src/mainboard/system76/adl-p/variants/galp6/gpio_early.c rename to src/mainboard/system76/adl/variants/galp6/gpio_early.c diff --git a/src/mainboard/system76/adl-p/variants/galp6/hda_verb.c b/src/mainboard/system76/adl/variants/galp6/hda_verb.c similarity index 100% rename from src/mainboard/system76/adl-p/variants/galp6/hda_verb.c rename to src/mainboard/system76/adl/variants/galp6/hda_verb.c diff --git a/src/mainboard/system76/adl-p/variants/galp6/overridetree.cb b/src/mainboard/system76/adl/variants/galp6/overridetree.cb similarity index 100% rename from src/mainboard/system76/adl-p/variants/galp6/overridetree.cb rename to src/mainboard/system76/adl/variants/galp6/overridetree.cb diff --git a/src/mainboard/system76/adl-p/variants/galp6/romstage.c b/src/mainboard/system76/adl/variants/galp6/romstage.c similarity index 100% rename from src/mainboard/system76/adl-p/variants/galp6/romstage.c rename to src/mainboard/system76/adl/variants/galp6/romstage.c -- To view, visit https://review.coreboot.org/c/coreboot/+/72802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e1b67f83d649cd07645a4a519ba1bf2f6f5e7c6 Gerrit-Change-Number: 72802 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: security/vboot: Add store/validate methods for VBIOS FMAP cache
by Matt DeVillier (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Andrey Pronin, Raul Rangel, Martin L Roth, Julius Werner, Martin Roth, Yu-Ping Wu, Karthik Ramasubramanian. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72401 ) Change subject: security/vboot: Add store/validate methods for VBIOS FMAP cache ...................................................................... Patch Set 4: (1 comment) File src/security/vboot/secdata_tpm.c: https://review.coreboot.org/c/coreboot/+/72401/comment/075b3c2a_9c273c08 PS4, Line 520: return > Why would we choose to always return instead of continuing to write the buffer out after setting up […] it appears that setup_space() calls safe_write() as long as define_space() succeeds, so 1) the buffer is getting written, and 2) the RV will only be successful if safe_write() succeeds, so we're ok there -- To view, visit https://review.coreboot.org/c/coreboot/+/72401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I030017d3bf956b8593bc09073ad6545b80a5b52b Gerrit-Change-Number: 72401 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andrey Pronin <apronin(a)google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Andrey Pronin <apronin(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 17:54:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp/finalize.c: Set BIOS_DONE MSR as applicable
by Johnny Lin (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Simon Chou, TimLiu-SMCI, Jonathan Zhang, Paul Menzel, Christian Walter, Arthur Heymans, Jian-Ming Wang, Srinidhi N Kaushik, Tim Chu, Shelly Chang. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71964 ) Change subject: soc/intel/xeon_sp/finalize.c: Set BIOS_DONE MSR as applicable ...................................................................... Patch Set 17: (1 comment) File src/soc/intel/xeon_sp/finalize.c: https://review.coreboot.org/c/coreboot/+/71964/comment/06de990d_ae3fd0e1 PS16, Line 89: #if (CO > if (!(CONFIG_INTEL_HAS_BIOS_DONE_MSR)) […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f19a7c54818231ebbccd2b6f8b23f47b117eb1f Gerrit-Change-Number: 71964 Gerrit-PatchSet: 17 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 17:49:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp/finalize.c: Set BIOS_DONE MSR as applicable
by Johnny Lin (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Simon Chou, TimLiu-SMCI, Jonathan Zhang, Johnny Lin, Paul Menzel, Christian Walter, Jian-Ming Wang, Srinidhi N Kaushik, Tim Chu, Shelly Chang. Johnny Lin has uploaded a new patch set (#17) to the change originally created by Simon Chou. ( https://review.coreboot.org/c/coreboot/+/71964 ) Change subject: soc/intel/xeon_sp/finalize.c: Set BIOS_DONE MSR as applicable ...................................................................... soc/intel/xeon_sp/finalize.c: Set BIOS_DONE MSR as applicable If BIOS_DONE MSR is supported, set it after ReadyToBoot, because FSP programs certain registers via Notify phase ReadyToBoot and it cannot be modified by FSP after coreboot has set BIOS_DONE MSR, therefore we try to set BIOS_DONE MSR as late as possible to avoid this. Signed-off-by: Tim Chu <Tim.Chu(a)quantatw.com> Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> Signed-off-by: Jonathan Zhang <jonzhang(a)meta.com> Change-Id: I4f19a7c54818231ebbccd2b6f8b23f47b117eb1f --- M src/soc/intel/xeon_sp/finalize.c M src/soc/intel/xeon_sp/include/soc/util.h 2 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/71964/17 -- To view, visit https://review.coreboot.org/c/coreboot/+/71964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f19a7c54818231ebbccd2b6f8b23f47b117eb1f Gerrit-Change-Number: 71964 Gerrit-PatchSet: 17 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[master]: soc/intel/xeon_sp/spr: Add header files and romstage code
by Johnny Lin (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: TimLiu-SMCI, Jonathan Zhang, Johnny Lin, Christian Walter, Angel Pons, Jian-Ming Wang, Arthur Heymans, Srinidhi N Kaushik, Tim Chu. Johnny Lin has uploaded a new patch set (#5) to the change originally created by Jonathan Zhang. ( https://review.coreboot.org/c/coreboot/+/72442 ) Change subject: soc/intel/xeon_sp/spr: Add header files and romstage code ...................................................................... soc/intel/xeon_sp/spr: Add header files and romstage code Change-Id: Ia022534e5206dbeec946d3e5f3c66bcb5628748f Signed-off-by: Jonathan Zhang <jonzhang(a)meta.com> Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> --- A src/soc/intel/xeon_sp/spr/ddr.c A src/soc/intel/xeon_sp/spr/hob_display.c A src/soc/intel/xeon_sp/spr/include/soc/cpu.h A src/soc/intel/xeon_sp/spr/include/soc/crashlog.h A src/soc/intel/xeon_sp/spr/include/soc/ddr.h A src/soc/intel/xeon_sp/spr/include/soc/pci_devs.h A src/soc/intel/xeon_sp/spr/include/soc/soc_util.h A src/soc/intel/xeon_sp/spr/include/soc/xhci.h A src/soc/intel/xeon_sp/spr/romstage.c A src/soc/intel/xeon_sp/spr/soc_util.c A src/soc/intel/xeon_sp/spr/upd_display.c 11 files changed, 1,401 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/72442/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/72442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia022534e5206dbeec946d3e5f3c66bcb5628748f Gerrit-Change-Number: 72442 Gerrit-PatchSet: 5 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel: Use common codeflow for MP init
by Jonathan Zhang (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Johnny Lin, Kapil Porwal, Christian Walter, Arthur Heymans, Werner Zeh, Tim Chu. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72604 ) Change subject: soc/intel: Use common codeflow for MP init ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Thanks. Was this patch tested on DeltaLake and Tiogapass servers? -- To view, visit https://review.coreboot.org/c/coreboot/+/72604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia822468a6f15565b97e57612a294a0b80b45b932 Gerrit-Change-Number: 72604 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 17:30:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: src/soc/intel/common/block/pcie/rtd3: Fix root port _ON logic
by Jérémy Compostella (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Bora Guvendik, Hannah Williams, Anil Kumar K, Cliff Huang. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72826 ) Change subject: src/soc/intel/common/block/pcie/rtd3: Fix root port _ON logic ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72826/comment/dcdf0474_5298382d PS3, Line 16: aslo also -- To view, visit https://review.coreboot.org/c/coreboot/+/72826 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1ea2e78e98d334a90294ee6cdd14ae2de9b9b62 Gerrit-Change-Number: 72826 Gerrit-PatchSet: 3 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 17:29:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [WIP] src/drivers/s3_save_restore: Initial support for SMM payload
by Paul Menzel (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Michał Żygowski, Martin L Roth, Benjamin Doron. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70378 ) Change subject: [WIP] src/drivers/s3_save_restore: Initial support for SMM payload ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/70378/comment/414af055_7d488188 PS6, Line 7: Initial Please make it a statement by adding a verb (in imperative mood): Add initial -- To view, visit https://review.coreboot.org/c/coreboot/+/70378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3dd505a154175b6da8929b1157723de1645ca8fa Gerrit-Change-Number: 70378 Gerrit-PatchSet: 8 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 17:25:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/prodrive/hermes: Add SATA hotplug EEPROM setting
by Paul Menzel (Code Review) 06 Feb '23

06 Feb '23

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72712 ) Change subject: mb/prodrive/hermes: Add SATA hotplug EEPROM setting ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Why is it not needed? -- To view, visit https://review.coreboot.org/c/coreboot/+/72712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7dcd12049bdf7c2d200530acd8a6da5df726203 Gerrit-Change-Number: 72712 Gerrit-PatchSet: 2 Gerrit-Owner: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 06 Feb 2023 17:24:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023