Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger, Felix Held.
ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72861 )
Change subject: soc/amd/phoenix/soc_util: add get_soc_type
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/phoenix/include/soc/soc_util.h:
https://review.coreboot.org/c/coreboot/+/72861/comment/97afb119_a41716a7
PS1, Line 4: AMD_PHOENIX_SOC_UTIL_
AMD_PHOENIX_SOC_UTIL_H
--
To view, visit https://review.coreboot.org/c/coreboot/+/72861
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f2b668b83432426b04e7f1354b694ddd6c300d6
Gerrit-Change-Number: 72861
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-CC: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 06 Feb 2023 19:10:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Felix Held has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/72859 )
Change subject: arch/x86/cpu: move cpuid_match to corresponding header file
......................................................................
arch/x86/cpu: move cpuid_match to corresponding header file
Since the functionality of cpuid_match is also useful outside of
arch/x86/cpu.c and it's a relatively simple function, move its
definition as inline function to the header file.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Ic96746b33b01781543f60cf91904af35418e572d
---
M src/arch/x86/cpu.c
M src/arch/x86/include/arch/cpu.h
2 files changed, 19 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/72859/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/72859
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic96746b33b01781543f60cf91904af35418e572d
Gerrit-Change-Number: 72859
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Venkat Thogaru, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72743 )
Change subject: soc/qualcomm/sc7280: update intf timing parameter calcualtion for eDP
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
This doesn't seem to be doing the right thing. Please see https://issuetracker.google.com/255870643#comment50 for details.
--
To view, visit https://review.coreboot.org/c/coreboot/+/72743
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I069ca351d8c60d071debb23a5e48840701441977
Gerrit-Change-Number: 72743
Gerrit-PatchSet: 1
Gerrit-Owner: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Mon, 06 Feb 2023 18:57:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72843 )
Change subject: soc/amd/phoenix/include/cpu: rename CPUID define to match CPU model
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/phoenix/include/soc/cpu.h:
https://review.coreboot.org/c/coreboot/+/72843/comment/773378f9_cda608de
PS1, Line 6: #define PHOENIX2_A0_CPUID 0x00a70f80
> i have a separate patch for that, but i'm waiting with uploading that one until i'm done with a tree […]
done in CB:72853
--
To view, visit https://review.coreboot.org/c/coreboot/+/72843
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7500130d5470fdd824980b81746f3a0f6d277d4
Gerrit-Change-Number: 72843
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Mon, 06 Feb 2023 18:33:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72856 )
Change subject: arch/x86/include/cpu: introduce CPUID_FROM_FMS macro
......................................................................
arch/x86/include/cpu: introduce CPUID_FROM_FMS macro
Introduce a macro to get the raw CPUID leaf 1 EAX value from a given set
of CPU family, model and stepping. The processor type in bits 12 and 13
is assumed to be always be zero; at least this is the case for all
CPUIDs that are currently in the coreboot tree. This can be used to
make the device values in the CPU device ID tables easier to read.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Idab77453712b14983b1d02ca365f7924239fc2bf
---
M src/arch/x86/include/arch/cpu.h
1 file changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/72856/1
diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h
index ffa80a8..414acc0 100644
--- a/src/arch/x86/include/arch/cpu.h
+++ b/src/arch/x86/include/arch/cpu.h
@@ -111,6 +111,16 @@
struct device;
+#define CPUID_FROM_FMS(family, model, stepping) ( \
+ /* bits 31..28: reserved, set to 0 */ \
+ ((family) > 0xf ? ((family) - 0xf) & 0xff : 0) << 20 | \
+ ((model) >> 4 & 0xf) << 16 | \
+ /* bits 15..14: reserved, set to 0 */ \
+ /* bits 13..12: processor type, set to 0 */ \
+ ((family) > 0xf ? 0xf : family & 0xf) << 8 | \
+ ((model) & 0xf) << 4 | \
+ ((stepping) & 0xf) << 0)
+
#define CPUID_EXACT_MATCH_MASK 0xffffffff
#define CPUID_ALL_STEPPINGS_MASK 0xfffffff0
--
To view, visit https://review.coreboot.org/c/coreboot/+/72856
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idab77453712b14983b1d02ca365f7924239fc2bf
Gerrit-Change-Number: 72856
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange