coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: soc/amd: use CPUID_FROM_FMS macro instead of magic numbers
by Felix Held (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72862 ) Change subject: soc/amd: use CPUID_FROM_FMS macro instead of magic numbers ...................................................................... soc/amd: use CPUID_FROM_FMS macro instead of magic numbers Port over the remaining AMD SoCs to use CPUID_FROM_FMS. The Glinda CPUID still needs to be updated to the actual CPUID, but for now just change it to use CPUID_FROM_FMS. TEST=Resulting image of timeless build for Gardenia (Stoneyridge), Majolica (Cezanne), Chausie (Mendocino), Mayan (Phoenix) and Birman (Glinda) don't change. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ia508f857d06f3c15e3ac9f813302471348ce3d89 --- M src/soc/amd/cezanne/include/soc/cpu.h M src/soc/amd/glinda/include/soc/cpu.h M src/soc/amd/mendocino/include/soc/cpu.h M src/soc/amd/phoenix/include/soc/cpu.h M src/soc/amd/stoneyridge/cpu.c 5 files changed, 25 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/72862/1 diff --git a/src/soc/amd/cezanne/include/soc/cpu.h b/src/soc/amd/cezanne/include/soc/cpu.h index 926fd05..0239e19 100644 --- a/src/soc/amd/cezanne/include/soc/cpu.h +++ b/src/soc/amd/cezanne/include/soc/cpu.h @@ -3,7 +3,7 @@ #ifndef AMD_CEZANNE_CPU_H #define AMD_CEZANNE_CPU_H -#define CEZANNE_A0_CPUID 0x00a50f00 +#define CEZANNE_A0_CPUID CPUID_FROM_FMS(0x19, 0x50, 0) #define CEZANNE_VBIOS_VID_DID 0x10021638 #define BARCELO_VBIOS_VID_DID 0x100215e7 diff --git a/src/soc/amd/glinda/include/soc/cpu.h b/src/soc/amd/glinda/include/soc/cpu.h index 42b76c8..e7207da 100644 --- a/src/soc/amd/glinda/include/soc/cpu.h +++ b/src/soc/amd/glinda/include/soc/cpu.h @@ -3,6 +3,6 @@ #ifndef AMD_GLINDA_CPU_H #define AMD_GLINDA_CPU_H -#define GLINDA_A0_CPUID 0x008a0f00 /* TODO: Update for Glinda */ +#define GLINDA_A0_CPUID CPUID_FROM_FMS(0x17, 0xa0, 0) /* TODO: Update for Glinda */ #endif /* AMD_GLINDA_CPU_H */ diff --git a/src/soc/amd/mendocino/include/soc/cpu.h b/src/soc/amd/mendocino/include/soc/cpu.h index e0202bb..1890306 100644 --- a/src/soc/amd/mendocino/include/soc/cpu.h +++ b/src/soc/amd/mendocino/include/soc/cpu.h @@ -3,6 +3,6 @@ #ifndef AMD_MENDOCINO_CPU_H #define AMD_MENDOCINO_CPU_H -#define MENDOCINO_A0_CPUID 0x008a0f00 +#define MENDOCINO_A0_CPUID CPUID_FROM_FMS(0x17, 0xa0, 0) #endif /* AMD_MENDOCINO_CPU_H */ diff --git a/src/soc/amd/phoenix/include/soc/cpu.h b/src/soc/amd/phoenix/include/soc/cpu.h index 34784c4..19e7a95 100644 --- a/src/soc/amd/phoenix/include/soc/cpu.h +++ b/src/soc/amd/phoenix/include/soc/cpu.h @@ -3,7 +3,7 @@ #ifndef AMD_PHOENIX_CPU_H #define AMD_PHOENIX_CPU_H -#define PHOENIX_A0_CPUID 0x00a70f40 -#define PHOENIX2_A0_CPUID 0x00a70f80 +#define PHOENIX_A0_CPUID CPUID_FROM_FMS(0x19, 0x74, 0) +#define PHOENIX2_A0_CPUID CPUID_FROM_FMS(0x19, 0x78, 0) #endif /* AMD_PHOENIX_CPU_H */ diff --git a/src/soc/amd/stoneyridge/cpu.c b/src/soc/amd/stoneyridge/cpu.c index 5ecf0c6..25549d0 100644 --- a/src/soc/amd/stoneyridge/cpu.c +++ b/src/soc/amd/stoneyridge/cpu.c @@ -60,8 +60,8 @@ }; static struct cpu_device_id cpu_table[] = { - { X86_VENDOR_AMD, 0x660f00, CPUID_ALL_STEPPINGS_MASK }, - { X86_VENDOR_AMD, 0x670f00, CPUID_ALL_STEPPINGS_MASK }, + { X86_VENDOR_AMD, CPUID_FROM_FMS(0x15, 0x60, 0), CPUID_ALL_STEPPINGS_MASK }, + { X86_VENDOR_AMD, CPUID_FROM_FMS(0x15, 0x70, 0), CPUID_ALL_STEPPINGS_MASK }, { 0, 0, 0 }, }; -- To view, visit https://review.coreboot.org/c/coreboot/+/72862 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia508f857d06f3c15e3ac9f813302471348ce3d89 Gerrit-Change-Number: 72862 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/amd/picasso/soc_util: use cpuid_match
by Felix Held (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger. Hello Jason Glenesk, Matt DeVillier, Fred Reitberger, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72860 to look at the new patch set (#3). Change subject: soc/amd/picasso/soc_util: use cpuid_match ...................................................................... soc/amd/picasso/soc_util: use cpuid_match Now that there is a cpuid_match function, we can use it instead of doing basically the same thing manually. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I758f9564c08c62c747cc4f93a8d6b540a1834a62 --- M src/soc/amd/picasso/soc_util.c 1 file changed, 18 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/72860/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/72860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I758f9564c08c62c747cc4f93a8d6b540a1834a62 Gerrit-Change-Number: 72860 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/amd/picasso: use CPUID_FROM_FMS macro instead of magic numbers
by Felix Held (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger. Hello Jason Glenesk, Matt DeVillier, Fred Reitberger, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72857 to look at the new patch set (#2). Change subject: soc/amd/picasso: use CPUID_FROM_FMS macro instead of magic numbers ...................................................................... soc/amd/picasso: use CPUID_FROM_FMS macro instead of magic numbers TEST=Resulting image of timeless build for Mandolin doesn't change. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I44cb7759206e9e1ce79fd57f62b9a844e52f7394 --- M src/soc/amd/picasso/include/soc/cpu.h 1 file changed, 15 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/72857/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44cb7759206e9e1ce79fd57f62b9a844e52f7394 Gerrit-Change-Number: 72857 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: console: Add SimNow console logging
by Felix Held (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72751 ) Change subject: console: Add SimNow console logging ...................................................................... Patch Set 1: (1 comment) File src/soc/amd/common/block/simnow/Makefile.inc: https://review.coreboot.org/c/coreboot/+/72751/comment/2bb4f383_1c65d1b8 PS1, Line 6: CONFIG_AMD_SOC_CONSOLE_UART did you mean CONFIG_CONSOLE_AMD_SIMNOW? maybe have a ifeq ($(CONFIG_CONSOLE_AMD_SIMNOW),y) around both and smm-$(CONFIG_DEBUG_SMI) += .. here -- To view, visit https://review.coreboot.org/c/coreboot/+/72751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42a431f48ea14ba4adacbd4a32e15abe7c5e4951 Gerrit-Change-Number: 72751 Gerrit-PatchSet: 1 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 21:22:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/x86/include/cpu: introduce CPUID_FROM_FMS macro
by Felix Held (Code Review) 06 Feb '23

06 Feb '23

Felix Held has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/72856 ) Change subject: arch/x86/include/cpu: introduce CPUID_FROM_FMS macro ...................................................................... arch/x86/include/cpu: introduce CPUID_FROM_FMS macro Introduce a macro to get the raw CPUID leaf 1 EAX value from a given set of CPU family, model and stepping. The processor type in bits 12 and 13 is assumed to be always be zero; at least this is the case for all CPUIDs that are currently in the coreboot tree. This can be used to make the device values in the CPU device ID tables easier to read. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Idab77453712b14983b1d02ca365f7924239fc2bf --- M src/arch/x86/include/arch/cpu.h 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/72856/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idab77453712b14983b1d02ca365f7924239fc2bf Gerrit-Change-Number: 72856 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/amd/stoneyridge/cpu: use CPUID_ALL_STEPPINGS_MASK
by Felix Held (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Matt DeVillier. Hello Matt DeVillier, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72855 to look at the new patch set (#2). Change subject: soc/amd/stoneyridge/cpu: use CPUID_ALL_STEPPINGS_MASK ...................................................................... soc/amd/stoneyridge/cpu: use CPUID_ALL_STEPPINGS_MASK Use CPUID_ALL_STEPPINGS_MASK as CPUID match mask to support all family 15h model 60h and 70h steppings. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Id05f849d59c04efa9f38dd66892f3cb99d94e3ff --- M src/soc/amd/stoneyridge/cpu.c 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/72855/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72855 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id05f849d59c04efa9f38dd66892f3cb99d94e3ff Gerrit-Change-Number: 72855 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: ec/google/chromeec: Update ec_commands.h
by Caveh Jalali (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Subrata Banik, Caveh Jalali, Nick Vaccaro, Boris Mittelberg. Hello build bot (Jenkins), Subrata Banik, Jon Murphy, Nick Vaccaro, Boris Mittelberg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72640 to look at the new patch set (#3). Change subject: ec/google/chromeec: Update ec_commands.h ...................................................................... ec/google/chromeec: Update ec_commands.h Update ec_commands.h from the EC repo at: "8b6f7de2a7 fan: update fan stalled value reporting" This is an exact copy of the EC repo's ec_commands.h with the exception of updating the copyright message. BUG=b:258110734 BRANCH=none TEST=built coreboot for brya Change-Id: I4ce15e1af40cc54a6cf2ebd6f5d5adf8953dee60 Signed-off-by: Caveh Jalali <caveh(a)chromium.org> --- M src/ec/google/chromeec/ec_commands.h 1 file changed, 450 insertions(+), 130 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/72640/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/72640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ce15e1af40cc54a6cf2ebd6f5d5adf8953dee60 Gerrit-Change-Number: 72640 Gerrit-PatchSet: 3 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[master]: ec/google/chromeec: clang-format ec_commands.h
by Caveh Jalali (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Martin L Roth, Subrata Banik, Nick Vaccaro, Yu-Ping Wu, Elyes Haouas, Boris Mittelberg. Hello build bot (Jenkins), Subrata Banik, Jon Murphy, Nick Vaccaro, Boris Mittelberg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72639 to look at the new patch set (#3). Change subject: ec/google/chromeec: clang-format ec_commands.h ...................................................................... ec/google/chromeec: clang-format ec_commands.h This is a format-only change: Reformat ec_commands.h using clang-format according to the EC repo's current formatting style. The command is: clang-format --style=file:$EC/.clang-format -i ec_commands.h where $EC points to the chromeos EC repo. The EC repo has recently adpoted the practice of formatting all files through clang-format using its own style. So, run ec_commands.h through the EC's clang-format so future updates don't get overwhelmed by inconsequential style changes. BUG=b:258110734 BRANCH=none TEST=built coreboot for brya Change-Id: Icbd6d00922dc5fd4c44ee109d54cea612e15db06 Signed-off-by: Caveh Jalali <caveh(a)chromium.org> --- M src/ec/google/chromeec/ec_commands.h 1 file changed, 827 insertions(+), 838 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/72639/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/72639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbd6d00922dc5fd4c44ee109d54cea612e15db06 Gerrit-Change-Number: 72639 Gerrit-PatchSet: 3 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[master]: ec/google/chromeec: clang-format ec_commands.h
by build bot (Jenkins) (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Martin L Roth, Subrata Banik, Nick Vaccaro, Yu-Ping Wu, Elyes Haouas, Boris Mittelberg. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72639 ) Change subject: ec/google/chromeec: clang-format ec_commands.h ...................................................................... Patch Set 2: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169998): https://review.coreboot.org/c/coreboot/+/72639/comment/1e0ddfc2_4652b510 PS2, Line 11: 'comand' may be misspelled - perhaps 'command'? -- To view, visit https://review.coreboot.org/c/coreboot/+/72639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbd6d00922dc5fd4c44ee109d54cea612e15db06 Gerrit-Change-Number: 72639 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Mon, 06 Feb 2023 20:46:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: ec/google/chromeec: Update ec_commands.h
by Caveh Jalali (Code Review) 06 Feb '23

06 Feb '23

Attention is currently required from: Subrata Banik, Caveh Jalali, Nick Vaccaro, Boris Mittelberg. Hello build bot (Jenkins), Subrata Banik, Jon Murphy, Nick Vaccaro, Boris Mittelberg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72640 to look at the new patch set (#2). Change subject: ec/google/chromeec: Update ec_commands.h ...................................................................... ec/google/chromeec: Update ec_commands.h Update ec_commands.h from the EC repo at: "8b6f7de2a7 fan: update fan stalled value reporting" This is an exact copy of the EC repo's ec_commands.h with the exception of updating the copyright message. BUG=b:258110734 BRANCH=none TEST=built coreboot for brya Change-Id: I4ce15e1af40cc54a6cf2ebd6f5d5adf8953dee60 Signed-off-by: Caveh Jalali <caveh(a)chromium.org> --- M src/ec/google/chromeec/ec_commands.h 1 file changed, 450 insertions(+), 130 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/72640/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ce15e1af40cc54a6cf2ebd6f5d5adf8953dee60 Gerrit-Change-Number: 72640 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023