coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: mb/intel/mtlrvp: Enable WWAN ACPI
by Jamie Ryu (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Harsha B R, Usha P. Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72779 ) Change subject: mb/intel/mtlrvp: Enable WWAN ACPI ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72779 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I870cc0782fb989f1bdbe369a4a12630a62729d8e Gerrit-Change-Number: 72779 Gerrit-PatchSet: 7 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 16:53:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/haswell/pcie.c: Make UBSAN shut up
by Nico Huber (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Felix Singer, Paul Menzel, Angel Pons, Arthur Heymans. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72806 ) Change subject: nb/intel/haswell/pcie.c: Make UBSAN shut up ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72806/comment/b6d1a1c3_86f685d8 PS1, Line 7: nb/intel/haswell/pcie.c: Make UBSAN shut up > But it fixes undefined behavior, so maybe: […] You can't fix undefined behavior, but you can avoid it... IMO "fix" is used wrong most of the time in commit messages. -- To view, visit https://review.coreboot.org/c/coreboot/+/72806 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf8710a5ae4e05d9f41f40f9e3617e155027800c Gerrit-Change-Number: 72806 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 07 Feb 2023 16:40:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: soc/intel/xeon_sp: add ebg (Emmitsburg PCH) directory
by Jonathan Zhang (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Subrata Banik, Simon Chou, TimLiu-SMCI, Johnny Lin, Paul Menzel, David Hendricks, Christian Walter, Angel Pons, Jian-Ming Wang, Arthur Heymans, Shuming Chu (Shuming), Elyes Haouas. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71945 ) Change subject: soc/intel/xeon_sp: add ebg (Emmitsburg PCH) directory ...................................................................... Patch Set 11: (1 comment) File src/soc/intel/xeon_sp/ebg/include/soc/pmc.h: https://review.coreboot.org/c/coreboot/+/71945/comment/bf8466da_520545fa PS10, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */ > This file should be re-organized, check [CB:72399] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/71945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I393c1df75a344519fca7d680116f41f5f8bd9e87 Gerrit-Change-Number: 71945 Gerrit-PatchSet: 11 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 07 Feb 2023 16:40:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/dell: Add Latitude E6400
by Nicholas Chin (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Angel Pons, Elyes Haouas. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59704 ) Change subject: mb/dell: Add Latitude E6400 ...................................................................... Patch Set 11: (1 comment) File src/mainboard/dell/e6400/cmos.layout: https://review.coreboot.org/c/coreboot/+/59704/comment/b4935ab4_bf8e96bb PS10, Line 38: 1152 128 r 0 vbnv > VBNV is deprecated Done. Also cleaned up unused enums. By the way, do you have a reference for that deprecation? I couldn't find any commit on Gerrit relating to that -- To view, visit https://review.coreboot.org/c/coreboot/+/59704 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I516ebbf4390a3f6d242050da8d35dc267b8b3a28 Gerrit-Change-Number: 59704 Gerrit-PatchSet: 11 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 07 Feb 2023 16:39:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common/block/fast_spi: Add SPI BIOS decode lock
by Jonathan Zhang (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Simon Chou, TimLiu-SMCI, Ryback Hung, David Hendricks, Paul Menzel, Angel Pons, Tim Chu. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71953 ) Change subject: soc/intel/common/block/fast_spi: Add SPI BIOS decode lock ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3366817b42a5878f16575698ebc546fa7852e285 Gerrit-Change-Number: 71953 Gerrit-PatchSet: 9 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Ryback Hung <ryback.hung(a)quantatw.com> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Ryback Hung <ryback.hung(a)quantatw.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 16:38:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/dell: Add Latitude E6400
by Nicholas Chin (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Nicholas Chin, Elyes Haouas. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59704 to look at the new patch set (#11). Change subject: mb/dell: Add Latitude E6400 ...................................................................... mb/dell: Add Latitude E6400 Mainboard name is Compal JBL00. This is based on the GM45/ICH9M chipset and uses DDR2 RAM. The EC is a SMSC MEC5035 which has internal flash, so there's no issue about making sure to include the EC firmware in the BIOS region. This only supports the variant with integrated graphics only, the version with a discrete Nvidia Quadro NVS 160M is not supported. This port was based on the Lenovo T400 port. Working: - USB EHCI debug (lower USB port on right side) - Keyboard - Touchpad/trackpoint - VGA - Displayport - ExpressCard - Audio - Ethernet - mPCIe WiFi - mPCIe Bluetooth (uses USB) Not working: - Brightness hotkeys - Physical Wireless switch - SD card slot: Linux outputs an "irq 18: nobody cared" message when inserting a card, after which it disables the IRQ Unknown/untested: - Dock - Smartcard (slot and contactless) - Firewire - eSATA - TPM - Battery (my battery is at the end of its lifespan) Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> Change-Id: I516ebbf4390a3f6d242050da8d35dc267b8b3a28 --- A src/mainboard/dell/e6400/Kconfig A src/mainboard/dell/e6400/Kconfig.name A src/mainboard/dell/e6400/Makefile.inc A src/mainboard/dell/e6400/acpi/ec.asl A src/mainboard/dell/e6400/acpi/ich9_pci_irqs.asl A src/mainboard/dell/e6400/acpi/superio.asl A src/mainboard/dell/e6400/blc.c A src/mainboard/dell/e6400/board_info.txt A src/mainboard/dell/e6400/bootblock.c A src/mainboard/dell/e6400/cmos.default A src/mainboard/dell/e6400/cmos.layout A src/mainboard/dell/e6400/cstates.c A src/mainboard/dell/e6400/data.vbt A src/mainboard/dell/e6400/devicetree.cb A src/mainboard/dell/e6400/dsdt.asl A src/mainboard/dell/e6400/gma-mainboard.ads A src/mainboard/dell/e6400/gpio.c A src/mainboard/dell/e6400/hda_verb.c A src/mainboard/dell/e6400/mainboard.c A src/mainboard/dell/e6400/romstage.c 20 files changed, 649 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/59704/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/59704 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I516ebbf4390a3f6d242050da8d35dc267b8b3a28 Gerrit-Change-Number: 59704 Gerrit-PatchSet: 11 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: ec/dell: Add support for the SMSC MEC5035
by Nicholas Chin (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Paul Menzel, Felix Held, Elyes Haouas. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59703 ) Change subject: ec/dell: Add support for the SMSC MEC5035 ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59703/comment/08a5101f_e6ffe2dd PS9, Line 16: Part of this code is based on unmerged MEC5055 code written by Iru Cai. > Was it ever public? Yes, see CB:44975: (ec: Add support for MEC5055 for Dell laptops) -- To view, visit https://review.coreboot.org/c/coreboot/+/59703 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia420cd51e9a64be5eee4af2c0d113618575522b0 Gerrit-Change-Number: 59703 Gerrit-PatchSet: 9 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 07 Feb 2023 16:25:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/abuild: Add flags to allow abuild to skip boards
by Fred Reitberger (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Felix Singer, Martin L Roth, Paul Menzel. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71730 ) Change subject: util/abuild: Add flags to allow abuild to skip boards ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43336484cf25f83065ec7facf45c123d831024b5 Gerrit-Change-Number: 71730 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 07 Feb 2023 16:21:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: sb/intel/lynxpoint: Add PCI DIDs for 9 series PCHs
by Paul Menzel (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Angel Pons, Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68187 ) Change subject: sb/intel/lynxpoint: Add PCI DIDs for 9 series PCHs ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68187 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee93fee4f28b88a72c537944159fb7cbb2796235 Gerrit-Change-Number: 68187 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 07 Feb 2023 16:18:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: ec/dell: Add support for the SMSC MEC5035
by Paul Menzel (Code Review) 07 Feb '23

07 Feb '23

Attention is currently required from: Nicholas Chin, Felix Held, Elyes Haouas. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59703 ) Change subject: ec/dell: Add support for the SMSC MEC5035 ...................................................................... Patch Set 9: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59703/comment/4a71706d_e44c3bb7 PS9, Line 16: Part of this code is based on unmerged MEC5055 code written by Iru Cai. Was it ever public? -- To view, visit https://review.coreboot.org/c/coreboot/+/59703 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia420cd51e9a64be5eee4af2c0d113618575522b0 Gerrit-Change-Number: 59703 Gerrit-PatchSet: 9 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 07 Feb 2023 16:17:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023