coreboot-gerrit December 2023

coreboot-gerrit@coreboot.org

1 participants
2354 discussions

[S] Change in coreboot[main]: mb/intel/mtlrvp: define a new config for Chrome EC
by Eric Lai (Code Review) 26 Dec '23

26 Dec '23

Attention is currently required from: Balaji Manigandan, Deepti Deshatty, Kapil Porwal, Krishna P Bhat D, Paul Menzel, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79211?usp=email ) Change subject: mb/intel/mtlrvp: define a new config for Chrome EC ...................................................................... Patch Set 5: (1 comment) File src/mainboard/intel/mtlrvp/Kconfig: https://review.coreboot.org/c/coreboot/+/79211/comment/302a5c1d_77b514ad : PS5, Line 120: select EC_ACPI : select EC_GOOGLE_CHROMEEC : select EC_GOOGLE_CHROMEEC_ESPI : select EC_GOOGLE_CHROMEEC_BOARDID add common config like chorme_ec_common? -- To view, visit https://review.coreboot.org/c/coreboot/+/79211?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0b85cc48d5cefadb52edbb27bf6cf370b27c395f Gerrit-Change-Number: 79211 Gerrit-PatchSet: 5 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Comment-Date: Tue, 26 Dec 2023 07:56:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/intel/mtlrvp: add 512KB SI_EC FMAP region
by Eric Lai (Code Review) 26 Dec '23

26 Dec '23

Attention is currently required from: Balaji Manigandan, Deepti Deshatty, Kapil Porwal, Krishna P Bhat D, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79209?usp=email ) Change subject: mb/intel/mtlrvp: add 512KB SI_EC FMAP region ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79209?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I788dbeaad05e5d6904fb2c7c681a0bf653dc7d84 Gerrit-Change-Number: 79209 Gerrit-PatchSet: 7 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Comment-Date: Tue, 26 Dec 2023 07:52:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/qualcomm/sc7280: Check domain enabled before assigning pci ops
by Eric Lai (Code Review) 26 Dec '23

26 Dec '23

Attention is currently required from: Julius Werner, Shelley Chen, Sudheer Amrabadi, Veerabhadrarao Badiganti, mturney mturney. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73716?usp=email ) Change subject: soc/qualcomm/sc7280: Check domain enabled before assigning pci ops ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73716?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I772c426ac2dd3f296590b1bc40f8649eb3db3d5f Gerrit-Change-Number: 73716 Gerrit-PatchSet: 3 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Veerabhadrarao Badiganti <vbadigan(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Veerabhadrarao Badiganti <vbadigan(a)qualcomm.corp-partner.google.com> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Comment-Date: Tue, 26 Dec 2023 07:50:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/dell: Add OptiPlex 7020/9020 port
by nat ✨ (Code Review) 26 Dec '23

26 Dec '23

Attention is currently required from: Angel Pons, Michael Niewöhner, Michał Żygowski, Máté Kukri, Nicholas Chin, Paul Menzel. nat ✨ has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55232?usp=email ) Change subject: mb/dell: Add OptiPlex 7020/9020 port ...................................................................... Patch Set 31: (1 comment) Patchset: PS31: I got this running on my 9020 SFF. Major issue I had here was not working SATA that's used for ODD. To avoid rebooting million times, I enabled every non-IME device in the devicetree, changed SATA map to 0x3f and rebuilt - after a reflash, all SATA ports were working correctly. I'll try to tinker more tomorrow with GOP in EDK2 as I'm using an RX 6400 which makes libgfxinit a bit useless in my daily usage 😊 Also, would it be possible to enable ReBAR? I've tried enabling it and changing BAR size from 37 and below. Not sure if this idea was straight up insane and unrealistic but well - it didn't work. -- To view, visit https://review.coreboot.org/c/coreboot/+/55232?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a Gerrit-Change-Number: 55232 Gerrit-PatchSet: 31 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ben Westover <me(a)benthetechguy.net> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: nat ✨ <nat(a)nekopon.pl> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 25 Dec 2023 23:07:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/hp: Add Compaq Elite 8300 CMT port
by Riku Viitanen (Code Review) 25 Dec '23

25 Dec '23

Attention is currently required from: Paul Menzel. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79745?usp=email to look at the new patch set (#14). Change subject: mb/hp: Add Compaq Elite 8300 CMT port ...................................................................... mb/hp: Add Compaq Elite 8300 CMT port Based on autoport and Z220 SuperIO code. With SeaBIOS and Nouveau on Debian, only nomodeset works with GTX 780 (must use proprietary driver instead). Tested by xilynx / spot_ on #libreboot: - i3-3220, native raminit 2x2GB, M378B5773DH0-CH9 + MT8JTF25664AZ-1G6M1 - Celeron G1620, native raminit 1x4GB, MT8JTF51264AZ-1G6E1 - Booting Debian with Linux 6.1.0-16-amd64 via SeaBIOS - All SATA ports - Audio: internal speaker, headphone and microphone plugs - Rebooting - S3 suspend and wake - libgfxinit: VGA, DisplayPort - Ethernet - Super I/O: fan speeds stay in control - GPU in PEG slot Untested: - EHCI debugging - Other PCI/PCIe slots - PS/2 - Serial, parallel ports Change-Id: Ie6ec60d2f4ee50d5e3fa2847c19fa4cf0ab73363 Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com> --- A src/mainboard/hp/compaq_elite_8300_cmt/Kconfig A src/mainboard/hp/compaq_elite_8300_cmt/Kconfig.name A src/mainboard/hp/compaq_elite_8300_cmt/Makefile.inc A src/mainboard/hp/compaq_elite_8300_cmt/acpi/ec.asl A src/mainboard/hp/compaq_elite_8300_cmt/acpi/platform.asl A src/mainboard/hp/compaq_elite_8300_cmt/acpi/superio.asl A src/mainboard/hp/compaq_elite_8300_cmt/acpi_tables.c A src/mainboard/hp/compaq_elite_8300_cmt/board_info.txt A src/mainboard/hp/compaq_elite_8300_cmt/cmos.default A src/mainboard/hp/compaq_elite_8300_cmt/cmos.layout A src/mainboard/hp/compaq_elite_8300_cmt/data.vbt A src/mainboard/hp/compaq_elite_8300_cmt/devicetree.cb A src/mainboard/hp/compaq_elite_8300_cmt/dsdt.asl A src/mainboard/hp/compaq_elite_8300_cmt/early_init.c A src/mainboard/hp/compaq_elite_8300_cmt/gma-mainboard.ads A src/mainboard/hp/compaq_elite_8300_cmt/gpio.c A src/mainboard/hp/compaq_elite_8300_cmt/hda_verb.c A src/mainboard/hp/compaq_elite_8300_cmt/mainboard.c 18 files changed, 661 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/79745/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/79745?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie6ec60d2f4ee50d5e3fa2847c19fa4cf0ab73363 Gerrit-Change-Number: 79745 Gerrit-PatchSet: 14 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: mb/hp: Add Compaq Elite 8300 CMT port
by Riku Viitanen (Code Review) 25 Dec '23

25 Dec '23

Attention is currently required from: Paul Menzel. Riku Viitanen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79745?usp=email ) Change subject: mb/hp: Add Compaq Elite 8300 CMT port ...................................................................... Patch Set 13: (4 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/79745/comment/aad68f13_fa944b21 : PS11, Line 11: Tested by xilynx / spot_ on #libreboot: > What CPUs? Done https://review.coreboot.org/c/coreboot/+/79745/comment/448a0a0e_3f1efb97 : PS11, Line 12: Linux 6.1.0-16-amd64 > What distribution is that? Done https://review.coreboot.org/c/coreboot/+/79745/comment/cf17cbc6_7cb3e6fa : PS11, Line 13: 2x2GB > Please list the models. Done https://review.coreboot.org/c/coreboot/+/79745/comment/a2765c4c_f5e25fb1 : PS11, Line 18: - libgfxinit: VGA, DisplayPort > Don’t you need a VBT file? It worked without a VBT (only Linux was tested with iGPU) Thanks for the reminder though, I added the VBT. -- To view, visit https://review.coreboot.org/c/coreboot/+/79745?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie6ec60d2f4ee50d5e3fa2847c19fa4cf0ab73363 Gerrit-Change-Number: 79745 Gerrit-PatchSet: 13 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 25 Dec 2023 21:36:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/brox: Enable High Definition Audio
by Paul Menzel (Code Review) 25 Dec '23

25 Dec '23

Attention is currently required from: Poornima Tom, Shelley Chen, Vamshi Krishna Gopal. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79723?usp=email ) Change subject: mb/google/brox: Enable High Definition Audio ...................................................................... Patch Set 2: (8 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79723/comment/4efa1aec_30d11d30 : PS2, Line 7: Enable High Definition Audio : Please include the model names. https://review.coreboot.org/c/coreboot/+/79723/comment/e5065b9a_b4c45736 : PS2, Line 9: .Added Please add a space after the dot/period. https://review.coreboot.org/c/coreboot/+/79723/comment/f67b03ee_41ce62fb : PS2, Line 9: Added verbtable Add verb table … https://review.coreboot.org/c/coreboot/+/79723/comment/ef5a1555_1347909a : PS2, Line 10: added add https://review.coreboot.org/c/coreboot/+/79723/comment/c3b967bb_e6057a07 : PS2, Line 9: On Brox, HDA Codec used is ALC 256.Added verbtable : for the same. Also, added the related device tree : changes for HDA related registers. Please reflow for 72 characters per line. File src/mainboard/google/brox/hda_verb.c: https://review.coreboot.org/c/coreboot/+/79723/comment/321835b7_765a566c : PS2, Line 59: * Disable AGC and set AGC limit to -1.5d What unit is d? https://review.coreboot.org/c/coreboot/+/79723/comment/6f99c7a7_594102cc : PS2, Line 75: enableing enabling? https://review.coreboot.org/c/coreboot/+/79723/comment/9f764f47_88fcdf35 : PS2, Line 91: * Default setting-1 Please add a space. -- To view, visit https://review.coreboot.org/c/coreboot/+/79723?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1edd5aee053debe39b34048266703031c088cd00 Gerrit-Change-Number: 79723 Gerrit-PatchSet: 2 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com> Gerrit-Comment-Date: Mon, 25 Dec 2023 20:37:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/quandiso: Update P-sensor tuning
by Paul Menzel (Code Review) 25 Dec '23

25 Dec '23

Attention is currently required from: Eric Lai, Nick Vaccaro, Robert Chen, Shawn Ku, Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79724?usp=email ) Change subject: mb/google/nissa/var/quandiso: Update P-sensor tuning ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79724/comment/864846d3_49d67bf5 : PS3, Line 14: watch 'cat /sys/bus/iio/devices/iio:device*/*raw' How was the behavior before your patch? -- To view, visit https://review.coreboot.org/c/coreboot/+/79724?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5fc3bc5876594f2df79d628bd986113d37087c3d Gerrit-Change-Number: 79724 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 25 Dec 2023 20:27:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/liveiso: Update to 23.11 release
by Felix Singer (Code Review) 25 Dec '23

25 Dec '23

Attention is currently required from: Lennart Eichhorn, Marvin Evers, Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79416?usp=email ) Change subject: util/liveiso: Update to 23.11 release ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Hey all, could you have a look please? Just the usual changes. -- To view, visit https://review.coreboot.org/c/coreboot/+/79416?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf72c37205017b27012064b311a9510136351c0f Gerrit-Change-Number: 79416 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Lennart Eichhorn <lennarteichhorn(a)gmail.com> Gerrit-Reviewer: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Attention: Lennart Eichhorn <lennarteichhorn(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 25 Dec 2023 18:24:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/quandiso: Update P-sensor tuning
by Paul Menzel (Code Review) 25 Dec '23

25 Dec '23

Attention is currently required from: Eric Lai, Nick Vaccaro, Robert Chen, Shawn Ku, Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79724?usp=email ) Change subject: mb/google/nissa/var/quandiso: Update P-sensor tuning ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79724/comment/f3297382_3ab7366c : PS3, Line 9: Update proximity sensor tuning value from SX9324ICSTRT schematic. Was it copied and pasted before? The values look quite different? Please mention the version of the schematic. -- To view, visit https://review.coreboot.org/c/coreboot/+/79724?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5fc3bc5876594f2df79d628bd986113d37087c3d Gerrit-Change-Number: 79724 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 25 Dec 2023 14:32:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2023